cyther
Lord of the Dance
I was using the scenario counter earlier but I think it isn't active outside of Scenarios.
Modders Guide to FfH2
- Thread starter Kael
- Start date
The scenario counter should be available anytime. The epic game doesn't use it, but I havent blocked it.
MagisterCultuum
Great Sage
In scenarios, it seems to just use gc.getGame().changeScenarioCounter(1) and displays it like this:
I believe you could make an event that uses python to change the scenario counter and make ScenarioFunctions.py display goals even when not in a scenario.
You would probably want to disable these events during scenarios, or at least try not to use a counter number used in any scenario otherwise.
Edit: I see some people have mentioned the scenario counter already.
Code:
def getGoalTag(self, pPlayer):
szBuffer = u"<font=2>"
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_AGAINST_THE_WALL):
if gc.getGame().getScenarioCounter() == 0:
szBuffer = szBuffer + CyTranslator().getColorText("TXT_KEY_WB_AGAINST_THE_WALL_GOAL_1", (), gc.getInfoTypeForString("COLOR_RED"))I believe you could make an event that uses python to change the scenario counter and make ScenarioFunctions.py display goals even when not in a scenario.
You would probably want to disable these events during scenarios, or at least try not to use a counter number used in any scenario otherwise.
Edit: I see some people have mentioned the scenario counter already.
Kael,
I have a question - I am working on a modmod to add a new civ. As one of the functions, I want some of the civs units to be able to use the unitcreatefromcombat function. I have added this to the xml file for the unit and set the chance at 100% but my they don't seem to be creating the new units when sucessful in combat. Is there something more I'd need to do to enable this function to work?
I have a question - I am working on a modmod to add a new civ. As one of the functions, I want some of the civs units to be able to use the unitcreatefromcombat function. I have added this to the xml file for the unit and set the chance at 100% but my they don't seem to be creating the new units when sucessful in combat. Is there something more I'd need to do to enable this function to work?
xienwolf
Deity
Are you using the mod as a Module, or a straight Mod? Modules don't play nicely with the UnitCreateFromCombat and other text entry fields in the XML.
cyther
Lord of the Dance
Thanks everyone. For some reason the files I had started working for reasons I don't know.
Quick question: I was trying to tweak 0.40z so that trading over the ocean would become available with ocean-going vessels (optics), instead of being an end-game tech (astronomy).
This looked pretty straight forward: I moved this section from TECH_ASTRONOMY to TECH_OPTICS and figured I'd be good to go:
<TerrainTrades>
<TerrainTrade>
<TerrainType>TERRAIN_OCEAN</TerrainType>
<bTerrainTrade>1</bTerrainTrade>
</TerrainTrade>
</TerrainTrades>
I loaded up a save game, and sure enough, the ability appears now under Optics instead of under Astronomy on the tech screen. Great! Except, I have Optics, and still am not getting trade connections to anyone else (we are all on separate continents). I thought perhaps I needed to expose enough map to have a path to others' capitals, but this doesn't help either. I've discovered the Lanun capital, and I know they also have Optics because I got a message that the Black Wind had been built.
Is there more I need to do to get trade over oceans working?
thanks,
-gg
This looked pretty straight forward: I moved this section from TECH_ASTRONOMY to TECH_OPTICS and figured I'd be good to go:
<TerrainTrades>
<TerrainTrade>
<TerrainType>TERRAIN_OCEAN</TerrainType>
<bTerrainTrade>1</bTerrainTrade>
</TerrainTrade>
</TerrainTrades>
I loaded up a save game, and sure enough, the ability appears now under Optics instead of under Astronomy on the tech screen. Great! Except, I have Optics, and still am not getting trade connections to anyone else (we are all on separate continents). I thought perhaps I needed to expose enough map to have a path to others' capitals, but this doesn't help either. I've discovered the Lanun capital, and I know they also have Optics because I got a message that the Black Wind had been built.
Is there more I need to do to get trade over oceans working?
thanks,
-gg
Trading over ocean is enabled when you GET the tech. Since you already have it now you can't get trade over oceans. Not even if you go into WB and remove/readd the tech will you get it: removing it will cause your ability to trade over oceans to become *negative* and readding it will change it back to zero.
If you really want to do it in that specific save you can remove trading over ocean from optics, load the save and remove the tech from your civ in WB, save the game, put back trade over ocean at optics, load the new save and readd the tech in WB. When you remove / add the tech you should do it for all civs who had the tech when you first moved the ability.
If you really want to do it in that specific save you can remove trading over ocean from optics, load the save and remove the tech from your civ in WB, save the game, put back trade over ocean at optics, load the new save and readd the tech in WB. When you remove / add the tech you should do it for all civs who had the tech when you first moved the ability.
MagisterCultuum
Great Sage
Does pCity.applyBuildEffects(newUnit)give the units all the benefits as if it had been built in the city, including those granted in python? (Among other things, I'm thinking it may be better to have Barnaxus use this instead of seperate condition statements in case I add more golem boosting buildings.)
Hi Xienwolf - another question for you (sorry that your reward for being so helpful is another question - and gratitude!) I am having another wierd issue where for some reason all my units (even melee, non magic units like scouts) are all given Air2 and Air3 as a promotion option - even though they don't have channeling (or air mana, or Air 1). I haven't touched the promotions in the XML, although for my module I have added some new promotions, but nothing that would affect Air at all. I have only moved part of my files over from the module. Would using a module also maybe mess up the promotions prereqs? I am wondering if I should scrap using a module althogether if so and just merge my changes into the main FFH folder. I am trying to find the cause of this strange error first. Thanks for any thoughts you might have from you expertise - appreciate it.
Valkrionn
The Hamster King
Modular promotions tend not to work well if they require another promotion. I had that same issue. 
xienwolf
Deity
As Valk says, it is the module that is messing things up. You are overwriting all of the prereqs for the first couple of promotions in the base XML files.
Keep a backup copy of unmodded FfH around somewhere, and make all your changes directly to the mod instead of toying with modules, except in files where you only adjust numerical items and want to have an easy update to any new patches.
Keep a backup copy of unmodded FfH around somewhere, and make all your changes directly to the mod instead of toying with modules, except in files where you only adjust numerical items and want to have an easy update to any new patches.
Great- thanks Valk and Xienwolf - I appreciate it - that's good to know. I have been driving myself crazy trying to find out what could be causing this, going back through all the files I changed and not finding anything that would do this - so it's a relief to know what the cause is (and that I am not crazy). Thanks again for your help!
Minor Annoyance
Deity
OK while looking for capture code I found it was part of CvUnit::combatWon, which is all this:
Spoiler :
Now I think if I cut out everything that doesn't relate to the unit capturing code I want it looks like this:
Spoiler :
xienwolf
Deity
Took out too much.
The last chunk (getUnitConvertFromCombat()) is baby spiders upgrading to giant spiders, and wolves/lions upgrading to wolf packs/lion prides.
The first chunk (getCombatCapturePercent()) is Command Promotions. Moving the same unit into your control.
I think I remember you asking about enslavement (generating slaves) originally, so you want getEnslavementChance(), which can come from the unit (Taskmasters) or the Player (Slavery Civic).
This chunk defines your iUnit variable with the unit you will create. Then you need the chunk for if (iUnit != NO_UNIT) to actually spawn it.
The last chunk (getUnitConvertFromCombat()) is baby spiders upgrading to giant spiders, and wolves/lions upgrading to wolf packs/lion prides.
The first chunk (getCombatCapturePercent()) is Command Promotions. Moving the same unit into your control.
I think I remember you asking about enslavement (generating slaves) originally, so you want getEnslavementChance(), which can come from the unit (Taskmasters) or the Player (Slavery Civic).
This chunk defines your iUnit variable with the unit you will create. Then you need the chunk for if (iUnit != NO_UNIT) to actually spawn it.
Minor Annoyance
Deity
I thought that was something different but I couldn't find what it did.
Nope, I did want Command type promotions. Do I have that code right?
xienwolf
Deity
You still need the iUnit != NO_UNIT chunk at the end, or there will not be any new units created. For you there is only one way to have a new unit made, so you can safely combine the functions of course if you wanted to.
MagisterCultuum
Great Sage
Is there an easy way to check a leader's gender in python? I added more leaders to Lord of the Balors (different ones in different versions), and all the gay sex with Sallos seems so wrong. I guess I could hardcode all male leaders like you hardcoded Varn in the python, but it would be a lot simpler if I could just find a simple gender check.
