Sounds like the error you get when the mod folder is misnamed, it must be named "Caveman2Cosmos", misnaming the C2C mod causes some bad issues even without my modmod, but my modmod takes it further, hence you won't be able to start the game without the folder being named properly.
I didn't know about that, I'll look into it.
Nope the modmod is still compatible with the latest svn.
Nothing to adapt, my modmod doesn't cache all the tech buttons as UI image element like it is done in the code that you tweaked.
Ok, well you see what it is intended to switch right? Can you make sure your modmod adapts a similar approach to the display of religious icons in these cases?
Yeah, I think so, though I don't understand what the change would accomplish, does it have something to do with the praying hands on religions that are not founded, am I right in assuming that the praying hands does not show when using the "pick religion" game option? The praying hands show up correctly without the pick religion game-option with my modmod.
# loops through all techs in the game, and does this for those that can be researched by the player:
artPath = ""
if CyPlayer.canFoundReligion() and GAME.isTechCanFoundReligion(i):
for j in range(iReligionInfos):
if not GAME.isReligionSlotTaken(j):
CvReligionInfo = GC.getReligionInfo(j)
if CvReligionInfo.getTechPrereq() == i:
if self.GO_PICK_RELIGION:
artPath = CvReligionInfo.getGenericTechButton()
else:
artPath = CvReligionInfo.getTechButton()
break
if not artPath:
artPath = GC.getTechInfo(i).getButton()Yeah, pick religion or not, with all options the game should change out the praying hands icon when the tech is researched, nothing to do with whether the religion is founded yet.
Doesn't matter if it does or not, the intention of the difference is to allow for a later adjustment to the post researched button which should point to getGenericTechButton(). We're updating the xml and art references for that on our end.
You didn't answer this but I guess the intention in your change was to get the praying hands to show up when playing with the "Choose Religion" GO.
# loops through all techs in the game, and does this for those that can be researched by the player:
artPath = ""
if CyPlayer.canFoundReligion() and GAME.isTechCanFoundReligion(i):
for j in range(iReligionInfos):
if not GAME.isReligionSlotTaken(j):
CvReligionInfo = GC.getReligionInfo(j)
if CvReligionInfo.getTechPrereq() == i:
artPath = CvReligionInfo.getTechButton()
break
if not artPath:
artPath = GC.getTechInfo(i).getButton()That was the answer. Choose Religions (game option pick religion) should now be irrelevant to this switch. Under all options, the game should change out the praying hands icon (CvReligionInfo.getTechButton()) with the generic tech icon (CvReligionInfo.getGenericTechButton()) once the tech has been researched by any team in the game.
This is the equivalent piece of code from core C2C (latest rev):
szName = "ResearchButton" + str(i)
if(pPlayer.canFoundReligion() and gc.getGame().isTechCanFoundReligion(i)):
for j in range( gc.getNumReligionInfos() ):
if (gc.getReligionInfo(j).getTechPrereq() == i):
if( not gc.getGame().isReligionSlotTaken(j) ):
szName = "ReligionButton" + str(j)
breakartPath = ""
if CyPlayer.canFoundReligion() and GAME.isTechCanFoundReligion(i):
for j in range(iReligionInfos):
CvReligionInfo = GC.getReligionInfo(j)
if CvReligionInfo.getTechPrereq() == i:
artPath = CvReligionInfo.getTechButton()
break
if not artPath:
artPath = GC.getTechInfo(i).getButton()I thought I changed this last night. Can we change the call to isReligionSlotTaken to GAME.countKnownTechNumTeams(i) > 0?
My goal is:
GC.getTechInfo(i).getButton() should never be called for any use or purpose once the tech tree is also updated to this method. Essentially it would be the same as (CvReligionInfo.getGenericTechButton()) so if you want to use it as a fall back for the current XML not having filled out the GenericTechButton tags, by all means use it as a default if the previous comes up with basically nothing.
Using Thunderbords modified MainInterface.py along with the rest of this modmods files would be like having honey on the pizza instead of cheese. It's not compatible. Try using a compare program like winmerge on the modmods version of MainInterface and compare it to the core SVN version of that file. TB changed one line in that file, while my modmod changed thousands of lines.There was conflict when I updated to latest SVN.
Either I could use Thunderbords modified file or use your file.
When I extracted your mod, then his change here is not here
Looks like this change didn't do anything in tech tree (thunder forgot to post chagelog for SVN 9844)
You changed what button is cached as a UI element under the name "ReligionButton" + str(j)
Wouldn't that always produce the same result as:
No. In Divine Prophets and Limited Religions this can differ from whether the tech has been researched. The only call that works in ALL situations correctly is if the tech has been researched by any team.
