RFC Greek World UHV Project

Edmund Ironside

White Rabbit Object
Joined
Jun 27, 2017
Messages
1,089
Location
Michigan, USA.
My aim is to have a functional UHV for every civilization in RFCGW by the end of this summer.
I will update this opening post with my progress, and will post any questions or issues I have with coding in this thread (I don't want to fill up the main 'Welcome to the Rhye's and Fall of the Greek World' thread with questions regarding UHVs).

UHVs will all be tested to ensure they are functional, however they aren't currently being tested to see if they are balanced. So it is possible they may be too easy or too hard. Any feedback on UHV balance will be appreciated.

Etruscans 3/3 UHVs completed & added to mod.
Nubia 2/3 UHVs completed - 3rd UHV not functioning currently, pull request submitted.
Persia 2/3 UHVs completed - 3rd UHV not functioning currently, pull request submitted.
Rome 0/3 UHVs completed.
Macedonia 0/3 UHVs completed.
India 0/3 UHVs completed.
Bactria 0/3 UHVs completed.
Numidia 0/3 UHVs completed.
Germania 0/3 UHVs completed.
Sassanid 0/3 UHVs completed.
Byzantium 0/3 UHVs completed.
Huns 0/3 UHVs completed.
 
Last edited:

bluepotato

Prince
Joined
Dec 11, 2018
Messages
303
Thanks for your efforts. It would take ages to finish all UHVs myself at my current pace...

Just tested the Etruscan UHVs. The first one kind of feels like a freebie, got 1k gold by 536 BC just by settling a city and setting research to 0%. Maybe even 2k would be possible. (Provided you survive the Roman spawn...)

The second UHV has a bug where the text says it has to be reached by 270 BC but the actual code checks if it's reached in 671 BC. I assume your intention was the former?

(The final UHV looks fine to me.)
 

Edmund Ironside

White Rabbit Object
Joined
Jun 27, 2017
Messages
1,089
Location
Michigan, USA.
Just tested the Etruscan UHVs. The first one kind of feels like a freebie, got 1k gold by 536 BC just by settling a city and setting research to 0%. Maybe even 2k would be possible. (Provided you survive the Roman spawn...)

I've changed it to 2000.

The second UHV has a bug where the text says it has to be reached by 270 BC but the actual code checks if it's reached in 671 BC. I assume your intention was the former?

Yeah it should be 270 BC. When I test UHVs I normally use a much earlier date to just check it functions. I've updated it, the text for this UHV was wrong as well. It should have said "Control 4 cities in Italia, and 1 in Venetia and Corsica in 270 BC"
When I next do a pull request these things will be fixed.
On the subject of pull requests how often do you want me to submit them? Every time I complete a UHV or less frequently then that?
 

bluepotato

Prince
Joined
Dec 11, 2018
Messages
303
Yeah, separate pull requests for every civ would be ideal. Also, you don't have to open a new pull request if you just push the fixes on the (default) master branch, the current one should be updated automatically.

While we're at it, it looks like you're using the Github web UI to upload changes. Which I guess works, but you might want to look into switching to a proper git client like TortoiseGit or Github Desktop, they are a lot more convenient. Leoreth's guide should help.
 

Edmund Ironside

White Rabbit Object
Joined
Jun 27, 2017
Messages
1,089
Location
Michigan, USA.
While we're at it, it looks like you're using the Github web UI to upload changes. Which I guess works, but you might want to look into switching to a proper git client like TortoiseGit or Github Desktop, they are a lot more convenient. Leoreth's guide should help.

I download using tortoise git, but when I try to push using it, it asks for my github username and password, but then rejects them. :undecide:
I'm sure I am screwing something up, but am not sure what. Kind of pleased I am able to get Github web UI to at least work!
 

Edmund Ironside

White Rabbit Object
Joined
Jun 27, 2017
Messages
1,089
Location
Michigan, USA.
Fairly inevitably I have run into a coding issue.

The goal was "Make sure that at least one of every great person type is settled in Meroe by 350 AD."

I copied the UHV from RFCA and tried to make adjustments, but fairly predictably it doesn't work.

Code:
            if (self.getGoal(iNubia, 1) == -1):
                    bAllGSpecialists = True
                    for iGSpecialist in [7, 8, 9, 10, 11, 12, 13]:
                            if ( iNubia.getFreeSpecialistCount(iGSpecialist) <= 0 ):
                                    print (iGSpecialist, "nicht vorhanden")
                                    bAllGSpecialists = False
                                    break
                                                
                    if (bAllGSpecialists):
                            self.setGoal(iNubia, 1, 1)

I don't think freespecialist is defined which might be one of the reasons why the code doesn't function.
 

Edmund Ironside

White Rabbit Object
Joined
Jun 27, 2017
Messages
1,089
Location
Michigan, USA.
@bluepotato I submitted a new pull request for Nubia & Persia UHVs, though 2 of the UHVs sadly are not working currently.
 

Edmund Ironside

White Rabbit Object
Joined
Jun 27, 2017
Messages
1,089
Location
Michigan, USA.
I'll get the non-functioning ones working (then merge) when I have a bit more time.

Sounds good, let me know when you have had chance to merge them.
 
Top Bottom