AND2 and SVN Bug Reports - A New Dawn 2 ONLY

[45°38'N-13°47'E]

It's already in the original post but I'll type it BIGGER [emoji13]

Edit:done

 

[dbkblk]

We have a growing userbase, that's also why we are repeating more often

 

[Aciv4playerA]

here are the issues again, with the save file this time.

i found some info provided by the mod a bit confusing or maybe incorrect. Three examples that i can think of now:

1. the shipyard issue - see the city Yahodhar.. (My capital)
The info about the shipyard says "actual +5 hammers. Builds water units 50% faster" for a particular city (my capital in the save file previously uploaded). The "actual +5 hammers" part is confusing or incorrect. The shipyard does not add any actual *raw* hammers as far as my tests show, and the *equivalent* hammer that it adds when building water units (i.e., 50% faster) is more than 5 hammers for this city. So not sure where the "actual +5 hammers" part comes from.

2. the stonemason issue - see the city Otrar.
another example is the stonemason. The info says "actual +1 hammer. Building construction 15% faster". Again, I am not sure where the "actual +1 hammer" part comes from. I do not think it actually adds 1 raw hammers (or does it intend to?), nor does the equivalent hammer for +15% building construction translates into 1 hammer

 

[45°38'N-13°47'E]

I can't check now but I think those modifiers apply to raw city production. I mean, how many hammers are being produced by your capital tiles? Tiles only, without other modifiers. 10 hammers should be produced in this case.

 

[dbkblk]

To fix: The slinger and the archer have the same icon in the technology advisor.

 

[JosEPh_II]

In this screen shot the Research Icons at the top Athletics is a pink square. Missing art define or something like that iirc.

If this is wrong thread to post it in let me know.

JosEPh

 

[Vokarya]

In this screen shot the Research Icons at the top Athletics is a pink square. Missing art define or something like that iirc.

If this is wrong thread to post it in let me know.

JosEPh

If you've updated to v932, it should be fixed. I put in a new icon and art path for Athletics/unfounded Hellenism.

 

[MercuryBluefalc]

Okay, the last update made my save-games unplayable - i got a CTD with it. http://www.file-upload.net/download-10460729/Bismarck-n.-Chr.-1596.CivBeyondSwordSave.html

 

[dbkblk]

Okay, the last update made my save-games unplayable - i got a CTD with it. http://www.file-upload.net/download-10460729/Bismarck-n.-Chr.-1596.CivBeyondSwordSave.html

Currently under investigation. Thank you for report.

EDIT: It looks like a string error. Maybe something in the text files.

EDIT2: It happens only on savegame created before the update... and is finally not text related.

EDIT3: This is a memory leak. The RAM amount quickly increase to the max possible.

 

[Noyyau]

rev 937, just updated.

when using Spacebar the units instead of simply waiting (i.e. doing nothing), lose their movement points for the turn.

 

[dbkblk]

Did you had a crash while loading a savegame Noyyau?

@Afforess: I think rev936 broke old savegames. Currently looking for an error.

 

[Afforess]

Revision 936 is pretty short on changes: http://svn.afforess.com/comp.php?repname=RAND&compare[]=/@935&compare[]=/@936

It's possible the removed variable causes an issue with serialization. Try adding this code:

if (GC.getInitCore().getGameSaveSvnRev() < 936)
{
    bool bSkip = false;
    WRAPPER_READ_DECORATED(wrapper, "CvGame", &bSkip , "m_bGameStart");
}

Before this line:

WRAPPER_READ_CLASS_ARRAY_ALLOW_MISSING(wrapper, "CvGame", REMAPPED_CLASS_TYPE_TECHS, GC.getNumTechInfos(), m_abTechCanFoundReligion);

in CvGame. Hopefully that's the issue. I will investigate when I am home in 4 hours.

 

[dbkblk]

I suspect the CvGame change. I'm currently recompiling it without.
What is the purpose of those?

BINGO! I will release the fix so you can quietly look at the issue later.

 

[45°38'N-13°47'E]

I also had the feeling that something broke in Rev936 strange as it sounds.

 

[Afforess]

I suspect the CvGame change. I'm currently recompiling it without.
What is the purpose of those?

BINGO! I will release the fix so you can quietly look at the issue later.

m_bGameStart was removed because it is not needed.

I also had the feeling that something broke in Rev936 strange as it sounds.

Believe it or not, I did a bunch of local game tests on Rev936 to ensure religion founding on late starts did work. I didn't try to load an old save though.

 

[dbkblk]

Ok. I will try your changes before to release it.

 

[Afforess]

Ok. I will try your changes before to release it.

Yeah. If you just revert my changes you will just break religion founding again. My changes to CvGame are what fixed late start religion founding. So try my fix first.

Worst case, add the variable back into the header and the read/write and let me look at that again, but don't modify the functions for isGameStart().

 

[dbkblk]

Your fix has worked! Thank you for the quick debug

EDIT: I need to test it again. It seems I have mixed a revert and your fix at the same time :S

EDIT2: It definitely worked. Releasing changes...

 

[Combat Wombat]

45* Do you think you can update the OP of this thread with more specific bug reporting guidelines. I think 50% of my posts this week were some variation on the theme of "post a save".

Basically for 100% of bug reports we want a save. Screenshots are helpful if the bug has to deal with incorrect text in-game.

I'm kinda feeling like I'm reciting a script at this point...

Need an issue tracker. I would be happy to set one up and maintain it (clean up duplicate issues and the like) if it would be used.

 

[45°38'N-13°47'E]

Need an issue tracker. I would be happy to set one up and maintain it (clean up duplicate issues and the like) if it would be used.

Read first post, there's one already