AutoTips Issues

[Mentos]

The Great Lighthouse effect shown from the building itself is somehow strangely interpreted.

"+1 Sight" from "VisibilityChange 1" is correctly shown but "MovesChange 1" is somehow read from TXT_KEY_PROMOTION_GREAT_LIGHTHOUSE_HELP.

I've changed this help-tag to
[ICON_BULLET]+1 [ICON_MOVES] Movement[NEWLINE][ICON_BULLET]+1 Sight
where the building tooltip shows
[ICON_BULLET]+1 [ICON_MOVES] Movement
what obviously doesn't look that great with double [ICON_BULLET], unlike in the unit promotion tips itself which my help-tags are originally are changed for.

I haven't tested MovesChange alone yet, but can this be fixed that it won't read from the help-tag and rather show "+x Movement" or "+x [ICON_MOVES] Movement" depending what you set with MovesChange?

Same problem with Heroic Epic (CombatPercent) and Himeji Castle (FriendlyLandsModifier) where is read from help-tag instead of promotion attribute itself.


Another issue with FreeBuildingThisCity = "BUILDINGCLASS_MONASTERY".
It shows: TXT_KEY_BUILDING_MONASTERY

 

[Thalassicus]

Thank you for pointing out TXT_KEY_BUILDING_MONASTERY does not exist. I'll add it.

The reason I abandoned automatic data reading for promotions is twofold:

1. Complexity
2. Uniqueness of effect usage

1) Promotions have very complicated interconnections with unit classes. It requires scanning and interpreting all these tables to determine which unit types can get the promotion, and under which conditions:

• UnitPromotions_UnitCombats
• Policy_FreePromotions
• Policy_FreePromotionUnitCombats
• Trait_FreePromotions
• Trait_FreePromotionUnitCombats
• etc...

It's easier for the human to just say "this affects naval units" in the help text.

2) Unlike building data, there's not much repetition among promotion data - most effects are only used once or twice. Promotion information is also changed much less frequently than buildings or units. Because of this, automating the process would be a large up-front investment that would take much more time to pay off.

I could remove the [ICON_BULLET] in front of where it shows free promotions, if that would help?