v21 bugs and crashes

@Vokarya
if iTeam != loopTeam and loopTeam.isHasMet(iTeam):

This is still not changed
iTeam is team ID, an integer variable
loopTeam is gc.getTeam(xxx) => CyTeam variable

Comparing apple to orange will never be true and may even spawn errors

What if iTeam was pTeam instead? If I understand correctly, pTeam and loopTeam are both CyTeam variables, so that should work, right?

The other thought I had is maybe take out that test completely. What happens if you try and adjust a player's attitude toward itself? Is that even possible?
 
Personally I will prefer to compare integers than CyTeam variables, although that may work as well.

I never bother to do this test for my own wonders, and doesn't seems to matter anyway, attitude still 0
 
Personally I will prefer to compare integers than CyTeam variables, although that may work as well.

I never bother to do this test for my own wonders, and doesn't seems to matter anyway, attitude still 0

What variables should I test? I'm still really new at this, but I'm trying to learn.
 
Personally I will prefer to compare integers than CyTeam variables, although that may work as well.

I never bother to do this test for my own wonders, and doesn't seems to matter anyway, attitude still 0

Yes, test the IDs, otherwise you are comparing instances which I think could be different.
 
Fishermongers are the building you want - that is the building that gets this bonus.

The fish monger gives you bonus food for having access to the fishing resources (even for non coastal cities) and it is working fine (really cheap building, +7 food, turns any city into a food waster in no time.) The fish traps building says it increase food for having fish, crab, shrimp, and lobster in the city vicinity. This is not working.

Update:
I just noticed the fish traps are working now. Is there some tech not mentioned in the civolopedia or in the popup that is required for this building to fully function? New tech is the only thing I can think of that has changed.
 
Whoa. Just got Odin's Sanctuary. The movie screen was just a big pink box. Thought I'd mention it, just in case you didn't know.
 
I just had 2 CTDs, single player, V21 with Koshling's most recent patch.
Unfortunately i can't get them to repeat at end of turn, One happened, so I reloaded, and then was able to play 2 - 3 turns before it went again. If I can get it to repeat i'll post a save.
 
Got these two python errors with latest SVN (1902), one i already had, just putting it there again is all (goes with minidump).

Then i tried the Spy action plant a nuclear bomb again and this time it caused a CTD minidump?
 
Got these two python errors with latest SVN (1902), one i already had, just putting it there again is all (goes with minidump).

Traceback (most recent call last):
File "BugEventManager", line 363, in _handleDefaultEvent
File "GreatPersonEvents", line 42, in onGreatPersonBorn
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe8 in position 14: ordinal not in range(128)

I suspect that this one is one of the names I fixed. I should have changed the file name instead of the name in the XML.

Traceback (most recent call last):
File "BugEventManager", line 363, in _handleDefaultEvent
File "PlatyPingWonders", line 530, in onNukeExplosion
AttributeError: 'NoneType' object has no attribute 'getTeam'

I have not had chance to get back to NPT yet. It may be simpler if I remove it for now as I reckon it should be only buildable after the first nuke is exploded and affect the person after that.

BtW please test the following promotion for the hero units as requested. If it works OK please put it on the SVN when you add the promotions to the Heroes. Currently no one can get the promotion but that can be changed if you want me to.
 
I suspect that this one is one of the names I fixed. I should have changed the file name instead of the name in the XML.



I have not had chance to get back to NPT yet. It may be simpler if I remove it for now as I reckon it should be only buildable after the first nuke is exploded and affect the person after that.

BtW please test the following promotion for the hero units as requested. If it works OK please put it on the SVN when you add the promotions to the Heroes. Currently no one can get the promotion but that can be changed if you want me to.


Will take a look, i got it thx.
 
@ DH:

with the inclusion of the respawn I get this error now??

Traceback (most recent call last):
File "BugConfig", line 77, in parse
File "e:/main/civilization4/warlords/assets/python/system\xmllib.py", line 171, in feed
File "e:/main/civilization4/warlords/assets/python/system\xmllib.py", line 280, in goahead
File "e:/main/civilization4/warlords/assets/python/system\xmllib.py", line 598, in parse_starttag
File "BugConfig", line 122, in syntax_error
ConfigError: error parsing configuration: garbage in starttag
Traceback (most recent call last):
File "BugConfig", line 110, in unknown_endtag
File "BugConfig", line 334, in endChild
File "BugConfig", line 337, in end
File "BugConfig", line 318, in process
File "BugConfig", line 409, in handle
File "BugInit", line 64, in loadMod
File "BugConfig", line 77, in parse
File "e:/main/civilization4/warlords/assets/python/system\xmllib.py", line 171, in feed
File "e:/main/civilization4/warlords/assets/python/system\xmllib.py", line 280, in goahead
File "e:/main/civilization4/warlords/assets/python/system\xmllib.py", line 598, in parse_starttag
File "BugConfig", line 122, in syntax_error
ConfigError: error parsing configuration: garbage in starttag
 
@ DH:

with the inclusion of the respawn I get this error now??

Traceback (most recent call last):
File "BugConfig", line 77, in parse
File "e:/main/civilization4/warlords/assets/python/system\xmllib.py", line 171, in feed
File "e:/main/civilization4/warlords/assets/python/system\xmllib.py", line 280, in goahead
File "e:/main/civilization4/warlords/assets/python/system\xmllib.py", line 598, in parse_starttag
File "BugConfig", line 122, in syntax_error
ConfigError: error parsing configuration: garbage in starttag
Traceback (most recent call last):
File "BugConfig", line 110, in unknown_endtag
File "BugConfig", line 334, in endChild
File "BugConfig", line 337, in end
File "BugConfig", line 318, in process
File "BugConfig", line 409, in handle
File "BugInit", line 64, in loadMod
File "BugConfig", line 77, in parse
File "e:/main/civilization4/warlords/assets/python/system\xmllib.py", line 171, in feed
File "e:/main/civilization4/warlords/assets/python/system\xmllib.py", line 280, in goahead
File "e:/main/civilization4/warlords/assets/python/system\xmllib.py", line 598, in parse_starttag
File "BugConfig", line 122, in syntax_error
ConfigError: error parsing configuration: garbage in starttag

It is in the config file somewhere. I'll fix it and get back to you.
 
@StrategyOnly, I can see absolutly no differrenece between this one and the one you already have but then my dyslexia is going overboard today:mischief::rolleyes:

Edit Actually forget it, I'll try again tomorrow.
 
NPT
Spoiler :

Code:
def onNukeExplosion(argsList):
	'Nuke Explosion'
	pPlot, pNukeUnit = argsList

## NPT Start ##
	[COLOR="red"]if CyGame().getProjectCreatedCount(gc.getInfoTypeForString("PROJECT_NPT")) == 1:[/COLOR]
		iPlayer = pNukeUnit.getOwner()
		pPlayer = gc.getPlayer(iPlayer)
		[COLOR="Red"]if pPlayer.isNone() == false:[/COLOR]
			iTeam = pPlayer.getTeam()
			pTeam = gc.getTeam(iTeam)
			for iPlayerX in range(gc.getMAX_CIV_PLAYERS()):
				pPlayerX = gc.getPlayer(iPlayerX)
				if pPlayerX.isAlive() and iPlayerX != iPlayer:
					pPlayerX.AI_changeAttitudeExtra(iTeam, -1)
					if pPlayerX.AI_getAttitude(iPlayer) == gc.getInfoTypeForString("ATTITUDE_FURIOUS"):
						pTeamX = gc.getTeam(pPlayerX.getTeam())
						if pTeamX.canDeclareWar(iTeam):
							pTeamX.declareWar(iTeam, true, -1)
## NPT End ##

The reason it is causing trouble in C2C is because in BTS only Nuke units can be used to nuke, so pNukeUnit is valid and you can trace its owner, team etc.

This is the old version of NPT though, where war allies will still be angry and may even declare war on you while fighting the same enemy
 
Back
Top Bottom