Bug Reports

Ok, I better see now what the problem is with the "doughnut" bug.

When a unit is reloaded it now will Process all it's promotions. The problem is that changeExtraVisibilityRange function also changes the Players plot sight count. So, if a Unit stays in one plot each time you save and reload that plot gains one extra sight count.

Code: 
void CvUnit::changeExtraVisibilityRange(int iChange)
{
	if (iChange != 0)
	{
		plot()->changeAdjacentSight(getTeam(), visibilityRange(), false, this, true);

		m_iExtraVisibilityRange += iChange;
		FAssert(getExtraVisibilityRange() >= 0);

		plot()->changeAdjacentSight(getTeam(), visibilityRange(), true, this, true);
	}
}

The first changeAdjacentSight removes the count, the second adds it. This Promotion needs to be adjusted so that it does not call the changeAdjacentSight when reloading.

This makes me wonder though if there are any other promotions that effect the game world as such. It's something that needs investigating.

Ok, I believe I have fixed this issue. I added a new bLoading boolean to skip changing adjacent sight when loading a game.

Code: 
changeExtraVisibilityRange(int iChange, bool bLoading)

When I tested there were no more doughnuts:goodjob:

PS I also fixed it so that if a Trade Screen does not sell an item it will say "No Vendors" in the mouse over help text. Before it just listed the price as if it could be bought there.

PSS I've been real busy today. I also just fixed the "extra military profession bug" when changing plot professions and the military professions appear as well.
 
I have another confusing problem, not sure if it is a bug or just 'something'. anyway..

I have a silver mining town, and I have serfs working there, as they get plus 1 silver, but one of my serfs has stopped getting his plus 1 the other two make 2 silver but he only makes one and I can't figure out why? It is possible he may have been a soldier temporarily, defending the town, but I am not certain, I just saw that some how he is down to making one silver. It could also have been when I loaded the save game.

yep it is when you load a save, all my serfs lost there bonus... damn nit!! there goes my glorious silver mining operation!!
 

Attachments

Lib.Spi't said:
I have another confusing problem, not sure if it is a bug or just 'something'. anyway..

I have a silver mining town, and I have serfs working there, as they get plus 1 silver, but one of my serfs has stopped getting his plus 1 the other two make 2 silver but he only makes one and I can't figure out why? It is possible he may have been a soldier temporarily, defending the town, but I am not certain, I just saw that some how he is down to making one silver. It could also have been when I loaded the save game.

yep it is when you load a save, all my serfs lost there bonus... damn nit!! there goes my glorious silver mining operation!!
Click to expand...

Sob, I'll get right on this...
 
I believe I have fixed the issue...

Quick Fix 2.5.3

I attached a fixed saved game on the miner serfs. You will need to Delete each remaining Serf you have and readd them with world builder to fix their issue. There was one Archer serf with a few promotions, you can just give him experience in World Builder.


I didn't have the promotion effects in the saved and write functions. I've done that before when adding several new variables...grrrrr :mad:
 
This is a bug found in 2.5.2. Patch point 3 not installed yet.

The game crashes when razing a barbarian city.

Also I have still experienced the alternate equipment problem for building workers and the problem of not being able to go sentry has extended to more units other than workers. This last problem got fixed after saving and reloading.
I don’t mind workers starting to work on the next turn.
 

Attachments

New game after 2.5.2 installed.
Kailric, auto update was programmed after unpacking, wasn’t it? I believe I patched it right.
Don’t remember which other units didn’t go sentry. I think it was infantry and another one.
 
Trade Winds said:
New game after 2.5.2 installed.
Kailric, auto update was programmed after unpacking, wasn’t it? I believe I patched it right.
Don’t remember which other units didn’t go sentry. I think it was infantry and another one.
Click to expand...

I am thinking it wasn't patched correct as I can't load the game under my 2.5.2 branch. And I think it is because the Groomsman profession was removed and your saved game still has it....

There is no auto update...

Instructions:To install unzip the files then copy the /Assets folder in the zip. Paste the whole Folder over your Mods/Medieval/Assets folder. Say yes when asked if you want to merge or replace existing files. If there is more than one Update you must Paste them in their numerical/alphabetical order.

Edit: I am not sure what the deal is because I get a different crash if I add the Groomsman back, probably because I add a new Popup Enum in 2.5.2 as well. Anyway, I can try under the 2.5.1, but I don't have a branch for 2.5 anymore but I know we can revert back some how, just not sure about how to do that correctly.
 
I wasn’t asked to merge. I do remember I was asked in your previous 2.0i such updates.
I will patch now to point 3 directly if I can, and I’ll check the groomsman to see if the update was correct.
I will continue testing from this point.
 
Trade Winds said:
I wasn’t asked to merge. I do remember I was asked in your previous 2.0i such updates.
I will patch now to point 3 directly if I can, and I’ll check the groomsman to see if the update was correct.
I will continue testing from this point.
Click to expand...

You should be asked if you want to overwrite several files each time you patch as a general rule. If it doesn't then something wasn't done right. Unless we added only files that were not in original game would there be no overwrite.

You need to apply the 2.5.2 patch and then the 2.5.2 quickfix and they both overwrite files.

2.5.1 is included in 2.5.2
 
I know all the overwriting stuff. My mistake was dragging directly from the RAR into the directory, so windows had no opportunity to ask if merging.
I need to extract it first somewhere else and then merge it with the mod directory.
Noted that I have to patch onto the previous patch.
 
Looks to me like we are heading for upgrade hell like with 2.0. We may consider releasing a standalone 2.5.3. Also making a new release for each bugfix will result in 2.5.78 eventually, or at least it might. We may consider grouping the bugfixes into releases instead of quickly make one for each bugfix.

It should also be noted that cloning git and pulling master for all branches should provide you with the newest release, without considering numbering or patching. You will have to compile yourself though. Seeing that most bug reports came from people who would (likely) be able to use git and compile themselves, we should presumably make a release branch and ask people to use that one. We can then fix what people report and once we are without bugs in that branch for 2 weeks or something, we release a stable release. If we had done that with 2.5, then we wouldn't already have an additional 3 releases.
 
Nightinggale said:
Looks to me like we are heading for upgrade hell like with 2.0. We may consider releasing a standalone 2.5.3. Also making a new release for each bugfix will result in 2.5.78 eventually, or at least it might. We may consider grouping the bugfixes into releases instead of quickly make one for each bugfix.
Click to expand...

I did a "quick fix" so I didn't have to upload it to a file share site as you can upload anything to CivFanatics if its less than 10 mbs. But, I will merge it with the other update soon. I need to figure out the if my drop box would be more efficient and if everyone could download from there, and just start using that. I think we have like 7gb on a free microsoft drop box site. I know some countries can't download from just any place though, so I need to investigate.

Nightinggale said:
It should also be noted that cloning git and pulling master for all branches should provide you with the newest release, without considering numbering or patching. You will have to compile yourself though. Seeing that most bug reports came from people who would (likely) be able to use git and compile themselves, we should presumably make a release branch and ask people to use that one. We can then fix what people report and once we are without bugs in that branch for 2 weeks or something, we release a stable release. If we had done that with 2.5, then we wouldn't already have an additional 3 releases.
Click to expand...

Cloning git was the issue though as our testing players haven't been able to setup all that with any confidence and they were waiting for an official release.

I have discovered that people who are really interested in the mod will create a CivFanatics account just to report bugs, so a few bugs isn't always bad ;) as it gets people involved.
 
Kailric said:
Cloning git was the issue though as our testing players haven't been able to setup all that with any confidence and they were waiting for an official release.
Click to expand...
Which is yet another reason for me to write that git tutorial.

Kailric said:
I have discovered that people who are really interested in the mod will create a CivFanatics account just to report bugs, so a few bugs isn't always bad ;) as it gets people involved.
Click to expand...
People would still submit bug reports on the forum even if they use the git version. Technically they can submit them to SF too, but so far nobody have done that. SF is better though as open bugs will not be forgotten because they end up being 3 pages back.
 
You must log in or register to reply here.

Similar threads

A
  • Locked
New BETA Version – 4.18.4 (January 21, 2025)
6 7 8
Replies
156
Views
28K
Recursive
Recursive
Recursive
  • Locked
New BETA Version - 4.5.1 (February 28, 2024)
9 10 11
Replies
211
Views
35K
Recursive
Recursive
PDX Firefly
Developer Diary | After the Demo
Replies
5
Views
2K
Sephi
Sephi
Recursive
  • Locked
New Version - 2.6 (August 16, 2022)
12 13 14
Replies
266
Views
42K
Recursive
Recursive
S
  • Sticky
Tweak Mod for Xtended + Master of Mana Updates
27 28 29
Replies
562
Views
58K
SpyFanatic
S
Back
Top Bottom