Ahwaric
Shrubbery-hugger
Actually, your previous post gave me all info I needed.
I have identified and changed the right part of the code. All units that have defined leader promotion (including all totem animals in 23 b) or leader xp (granted on joining the unit) were eligible for spawning from xp.
I can add some leader xp to great generals and tie spawning to only these units that grant some leader xp. Or, simply hardcode it to spawn UNITCLASS_GREAT_GENERAL only.
Either way, it will be fixed in the next patch. Do you think I should add leader xp?
I have identified and changed the right part of the code. All units that have defined leader promotion (including all totem animals in 23 b) or leader xp (granted on joining the unit) were eligible for spawning from xp.
I can add some leader xp to great generals and tie spawning to only these units that grant some leader xp. Or, simply hardcode it to spawn UNITCLASS_GREAT_GENERAL only.
Either way, it will be fixed in the next patch. Do you think I should add leader xp?

)
I would say go with a global define that points at a specific unitclass to spawn (unitclass, not unittype, then you can make different Civs spawn different generals if you want)
Think I'll leave it that way then.