[MOD] v41 SVN and GithubDesktop Bugs and Crashes Single player

On latest SVN you can build myths land, air and sea in every city.
Edit: Forget to do recalc, stupid me.
 
Last edited:
Wow that's a serious deliberate bug, introduced recently. What about Mounted Infantry? They get all terrain defence benefits including fortification. Other units that don't get terrain defensive bonuses (eg. Rogues) can still get them through promos.

Please revert this mistake while you think about a better solution (personally I think none was needed before this change).
This has been in the game since before I was here. Mounted Infantry get defense adjustments thus they are part of the dismount line of mounted fighters that usually just fight from foot but use the mounts to get from one location to another. Otherwise, classic mounted units have never been able to gain defensive bonuses from terrain and thus could never take promos that gave additional defensive bonuses.

It was a rule in the DLL before I was here as well that you can't get a promo that gives you any terrain defense bonus if you are an offensive only unit. This is not something to simply reverse - it's the standard and has been through vanilla stock.

Opinion noted that while not being able to gain any defensive VALUE as stated from the promotions that give them, it should not necessarily be kept from a unit to upgrade into - but that WOULD mean that numerous promos stop being useful in the slightest to those units that take those promotions and nothing would be there to tell a player that.

The 'mistake' if there was one - and I pointed it out at the time - is that many promos give terrain defense but are assumed to be selectable by all units as they can provide mission critical benefits like avoiding terrain damage.
 
Last edited:
This has been in the game since before I was here. Mounted Infantry get defense adjustments thus they are part of the dismount line of mounted fighters that usually just fight from foot but use the mounts to get from one location to another. Otherwise, classic mounted units have never been able to gain defensive bonuses from terrain and thus could never take promos that gave additional defensive bonuses.
This is simply false, at least as applied to free starting promos due to the nature of the unit. When I had camel units in my last (Egypt) game, they all got their desert terrain promos. That was around a year ago.
 
This is simply false, at least as applied to free starting promos due to the nature of the unit. When I had camel units in my last (Egypt) game, they all got their desert terrain promos. That was around a year ago.
Free promos are supposed to ignore this and a few other rules so whoever was tampering with some things there didn't do it correctly but you cannot blame some newer modders for not realizing things have been overcomplicated for various reasons.
 
I think it was a mistake to make Arctic / Heat promotions require Combat I. The other promotions don't give terrain safety, or at least not at the first level.
 
The 'mistake' if there was one - and I pointed it out at the time - is that many promos give terrain defense but are assumed to be selectable by all units as they can provide mission critical benefits like avoiding terrain damage.
I suggest to concentrate on the fact that, in case of Mammoth Rider, for example, Arctic 3 promotion gives very important immunity from damage on taiga, tundra and permafrost. Plus mobility bonus on said terrain types.
I believe I've read somewhere in Pedia that mounted units don't get defensive bonuses.

With above I wanted to emphasize that those promotions must be given as said in Pedia. Maybe not completely, but 2/3 of bonuses are applied to units, if promotions are given.
 
I suggest to concentrate on the fact that, in case of Mammoth Rider, for example, Arctic 3 promotion gives very important immunity from damage on taiga, tundra and permafrost. Plus mobility bonus on said terrain types.
I believe I've read somewhere in Pedia that mounted units don't get defensive bonuses.

With above I wanted to emphasize that those promotions must be given as said in Pedia. Maybe not completely, but 2/3 of bonuses are applied to units, if promotions are given.
I'm just waiting for someone to redesign the promos tbh and have been ever since I brought up that they were an issue in the way they were designed.
 
Is it now impossible to make them work as they used to several SVN versions ago? If possible, I'd revert to as it was. It was working, at least. "Good enough" - very nice concept of living, BTW :)
 
Is it now impossible to make them work as they used to several SVN versions ago? If possible, I'd revert to as it was. It was working, at least. "Good enough" - very nice concept of living, BTW :)
Bill I think made some changes I'd have to figure out how to reinterpret into new coding and at some point I'll get to that. For now, it's just broken and not a high priority. To be specific, I'm speaking about how Free Promos shouldn't have some of the restrictions applying in these cases.

Some of this goes all the way back to when these promos were created and has been a problem all along in some aspects of those designs.
 
SVN This is a followup to a bug that happened before but i couldnt reproduce until now.

A minor civ leader decided to form an overseas colony, thus creating a vassal civ. This vassal civ was not considered minor, even though the mother civ is, which caused the colony to openly declare war on all civs in the world even those who were not met before.

Now the mother civ became a major civ which bugged the UI out. The civ list (with the points and all that) has disappeared and i don't get any tile/unit info popup on the map anymore. Its still possible to play but no info makes it quite frustrating.

Attached to this post are two saves.
One is the turn before the minor civ decided to make a colony. You have to end turn to make it happen.
The second save is after the minor civ turned major and bugged the UI.
 

Attachments

SVN This is a followup to a bug that happened before but i couldnt reproduce until now.

A minor civ leader decided to form an overseas colony, thus creating a vassal civ. This vassal civ was not considered minor, even though the mother civ is, which caused the colony to openly declare war on all civs in the world even those who were not met before.

Now the mother civ became a major civ which bugged the UI out. The civ list (with the points and all that) has disappeared and i don't get any tile/unit info popup on the map anymore. Its still possible to play but no info makes it quite frustrating.

Attached to this post are two saves.
One is the turn before the minor civ decided to make a colony. You have to end turn to make it happen.
The second save is after the minor civ turned major and bugged the UI.
Speaking for myself, I wouldn't be able to work on any vassal issues since I don't play with vassalage so wouldn't understand any code intentions I saw in that area.
 
"Meditation: The First who researched this Tech founds Buddhism."
Nope. Didn't happen.
My event log says: "You have discovered Meditation!" Doesn't say that I am the first, although I am. Waited two turns for reaction.
I checked with WorldBuilder and not a single other Civ, whether dead or alive, Barbarian or anyone else has discovered the Tech. They aren't even close. Therefore I think it's broken. SVN revision 11281.
 
"Meditation: The First who researched this Tech founds Buddhism."
In C2C, the first to research Buddhism founds Buddhism. You're quoting from vanilla BTS. There are explicit techs for all the religions in C2C. How do you not know this?
 
In C2C, the first to research Buddhism founds Buddhism. You're quoting from vanilla BTS. There are explicit techs for all the religions in C2C. How do you not know this?
Actually, I was quoting from C2C Wikipedia Meditation Tech description..., but nevermind
 
Speaking for myself, I wouldn't be able to work on any vassal issues since I don't play with vassalage so wouldn't understand any code intentions I saw in that area.

Its even more curious to me that they created the colony civ in the ancient era which i thought shouldnt be possible to begin with.
 
Actually, I was quoting from C2C Wikipedia Meditation Tech description..., but nevermind
Text stuff often is very outdated.

It could be even linked to vanilla texts.
 
Minor civs shouldn't be capable of creating colonies, nor have vassals, so I'll have to figure out what code is responsible for this and filter out minor civs from the evaluation.
Will look into the issue after fixing an edge case freeze when building the golden spike wonder if the building city is the only city on a landmass.
 
Actually, I was quoting from C2C Wikipedia Meditation Tech description..., but nevermind
Right so its a leftover display text issue. Got it. Thanks for pointing that out.
 
What's a colony?
I'm yet to found a city on another continent in like forever (such an event is quite outside of my normal strategy planning).
So, is this some actual specialized event you can choose or whatever?
Or is it literally founding a city overseas?
Or something in-between and inter-related, lol?
 
I can continually build Venture Industries, not sure why. Pretty sure not my fault, never touched Atompunk XML files. On SVN 11281.
Spoiler Screenshot :
upload_2021-1-16_19-6-20.png
 
Last edited:
Back
Top Bottom