Single Player bugs and crashes v35 plus (SVN) - After the 18th of August 2014

[Sparth]

I just had an error:

File: CvArtFileMgr.cpp
Line: 109
SVN-Rev: 8152
Expression: False
Message: Artinfo: 'ART_DEF_e Suffren' was not found

Try newest SVN. Should be ok now.

 

[Dancing Hoskuld]

@Sparth we use the BUG modular python method of doing python. This means that having a CvEventManager.py is a big no no. I created a folder in the Assets/Python folder called Sparth and placed your event manager module there. Your screen is still where you placed it.

There is, in my opinion, a small amount of work still needed to finish this. That is to make it easier for people who come later and want to modify or use the code.

While many C programmers will tell you that "the code is the documentation", this is only true if there is enough information in the code. Your screen code needs a short header comment saying what it is about. Plus it would be better if all the variables dealing with the same thing used a similar theme in their naming.

For example in the code the stuff about the Great Person portrait is

• _LEADER_ICON for the coordinates and size values
• sButton for the art definition information, and
• TechSplashIcon for the name of the widget

I would suggest something like _PORTRAIT instead of _LEADER_ICON, sPortrait instead of sButton and PortraitPanel instead of TechSplashIcon.

Similarly you have coordinate information for both _QUOTE and _TEXT but use quote and pedia elsewhere.

Cleaning the code up a bit will help who ever comes later. Most of the misunderstanding I had when helping you come from these simple differences in names of things that are about the same thing.

 

[Sparth]

Got it. Ill do the work ASAP.

 

[BlueGenie]

Latest SVN, ghost units still there for supply costs.

Cheers

 

[Toffer90]

End turn freeze; ↓ messege box at desktop.

Assert Failed

File: CvArtFileMgr.cpp
Line: 109
SVN-Rev: 8152
Expression: false
Message: ArtInfo: 'ART_DEF_y Beria' was not found

Assert Failed

File: CvArtFileMgr.cpp
Line: 109
SVN-Rev: 8152
Expression: false
Message: ArtInfo: 'ERROR' was not found

repeatable: Save View attachment 387002


Related to new GP screen. When I finally got my turn I got a GP screen without picture or text other than some error text. Lavrenty Beria (great Spy)


The first time I did only copy one of the errors as I was stupid enough to click debug instead of ignore once; debug caused a crash.

Assert Failed

File: CvArtFileMgr.cpp
Line: 109
SVN-Rev: 8152
Expression: false
Message: ArtInfo: 'ART_DEF_Ames' was not found

 

[Sparth]

Ok I know where is this bug. Ill remove it later today.

 

[Dancing Hoskuld]

The XML says that pigeons can't enter oceans of any type but I am getting attacked from ocean plots by pigeons. This is also true of other birds.

Subdued birds appear to be obeying the XML restrictions but not the removal of the restrictions with the tech as specified in the XML.

 

[Thunderbrd]

@BG: I tried to tackle ghost units in the field but not supply costs so that will still take some looking into - there may be a connection though... so keep looking for those ones in the field.

@Toffer: Debug will crash if you're not running the program attached to Visual Studio.

@DH: Ok that helps to have a better understanding of the issue there... interesting. These kinds of rules were written in such a twisted manner in the code it's always tough to tweak but I'll look into it sometime soon.

 

[Sparth]

End turn freeze; ↓ messege box at desktop...

Should be ok now

 

[Toffer90]

It doesn't make sense that food caravans can enter foreign culture without right of passage. The AI are using them to explore others territory a lot.

 

[JosEPh_II]

Started a game with 8143 and on the 15th updated to 8159. Today I get a hang at EoT and when I alt-tab out get this pop up msg:
File: CvArtFileMgr.cpp
Line: 109
SVN-Rev: 8152
Expression: false
Message: ArtInfo:'ART_DEF_yce' was not found.

I'm in the process of updating to 8164 will this fix this hang? Or is this a new bug?

Savegame can be attached if needed.

Thanks

JosEPh

 

[Toffer90]

@JosEPh_II:
I believe it was just recently fixed.

 

[ggm]

biodome spawns animals that cant move

 

[Dancing Hoskuld]

biodome spawns animals that cant move

That is because it has spawned a pheasant not a subdued pheasant like it should have. I got the index for the animal but forgot to use that in the array to find the actual unit id.

 

[ggm]

vienna congress gives massive negative overlow of votes. apostlic wonder gives correc votes. so does un.

ggm

 

[ggm]

vienna congress gives massive negative overlow of votes. apostlic wonder gives correc votes. so does un.

ggm

 

[Thunderbrd]

vienna congress gives massive negative overlow of votes. apostlic wonder gives correc votes. so does un.

ggm

I think we've had that bug report before. I don't know much about the vote systems - so to anyone who does have a clue here... would this be a python issue or dll matter? I've seen something about the vote popup structure in the code - I might be able to start from there to figure out what's wrong on this.

 

[Dancing Hoskuld]

I used WinGrep to look for any instances of Vienna in the python but did not find any.

 

[DocBuchanan]

Screen attached...

Assert Failed

File: CvArtFileMgr.cpp
Line: 102
SVN-Rev: 8152
Expression: false
Message: ArtInfo: 'ERROR' was not found


Also received a .py error a few turns prior related to BarbarianCivs, and an alert about missing slave building XML stuff when I launched C2C. Didn't screenshot those, sorry.

 

[Sparth]

[...]

Try to use newest SVN. Art errors was removed few versions ago.