1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

Single Player bugs and crashes v38 plus (SVN) - After the 20th of February 2018

Discussion in 'Bugs and Crashes' started by Dancing Hoskuld, Feb 24, 2018.

  1. Toffer90

    Toffer90 C2C Modder

    Joined:
    Oct 16, 2011
    Messages:
    5,255
    Location:
    Norway
    When all is said and done, we are usually on the same page. ^^
     
  2. Thunderbrd

    Thunderbrd C2C War Dog

    Joined:
    Jan 2, 2010
    Messages:
    24,747
    Gender:
    Male
    Location:
    Las Vegas
    I'm still considering removing the effect entirely for buildings and units though. Mostly this is due to considering what it does to city development. Pondering... pondering... It's on the table.
     
  3. Tajo

    Tajo Chieftain

    Joined:
    Jun 26, 2017
    Messages:
    166
    Gender:
    Male
    In V38 9916 AI seems to know how to build proper city defence units now as excess number of LEs are absent but almost all AI cities have green and red faces on them so it seems that AI has troubles keeping it's cities happy and clean. Quite unbalanced production values or 'prices' of the buildings are also an issue, as well as some early building seem to require too much hammers.
     
  4. Dancing Hoskuld

    Dancing Hoskuld Chieftain

    Joined:
    Jul 5, 2004
    Messages:
    22,875
    Gender:
    Male
    Location:
    Canberra, Australia
    The game option "More XP to level" is bugged. It needs to adjust the values of ANIMAL_MAX_XP_VALUE and BARBARIAN_MAX_XP_VALUE by the same amount. That is when they are used in game not in the XML file.
     
  5. raxo2222

    raxo2222 Warlord

    Joined:
    Jun 10, 2011
    Messages:
    4,782
    Location:
    Poland
    Industrial era has <iCreatePercent>80</iCreatePercent> and Nanotech era has <iCreatePercent>60</iCreatePercent>.
    All other CreatePercent tags are set at 100.
    @Thunderbrd
     
  6. Toffer90

    Toffer90 C2C Modder

    Joined:
    Oct 16, 2011
    Messages:
    5,255
    Location:
    Norway
    Obviously an oversight, I'll fix it.
     
    raxo2222 likes this.
  7. Whisperr

    Whisperr Chieftain

    Joined:
    Oct 15, 2011
    Messages:
    225
    There is an issue with these buttons.
     

    Attached Files:

  8. Thunderbrd

    Thunderbrd C2C War Dog

    Joined:
    Jan 2, 2010
    Messages:
    24,747
    Gender:
    Male
    Location:
    Las Vegas
    I wouldn't call it a 'bug' per se but I see the point of such an adjustment.
     
  9. Snofru1

    Snofru1 Chieftain

    Joined:
    Dec 29, 2005
    Messages:
    1,058
    Location:
    Germany
    Hawaiian Surfboard Carver has a "TXT_KEY_BUILDING_SURFBOARD_HELP" in its description.
     
  10. Tajo

    Tajo Chieftain

    Joined:
    Jun 26, 2017
    Messages:
    166
    Gender:
    Male
    Battlefield medicine tech claims that it now obsoletes field hospital but modern health care that comes much later is required to build it?? It used to be that battlefield medicine enabled or 'opened' the field hospital. How did this mess happen?
     
  11. Snofru1

    Snofru1 Chieftain

    Joined:
    Dec 29, 2005
    Messages:
    1,058
    Location:
    Germany
    Tiny mistake: There is "Heidelburg University" but the name of the city is Heidelberg.
     
  12. Raledon

    Raledon Chieftain

    Joined:
    Aug 15, 2008
    Messages:
    236
    Started a new game on latest SVN. Units' construction cost is bugged.
    *This seem to affect brute and stone thrower, the other units got what seem to be an allright hammer cost.
    Epic, NM, and Large (i think?).

    Spoiler :
    upload_2018-2-27_15-7-11.png
     
  13. Toffer90

    Toffer90 C2C Modder

    Joined:
    Oct 16, 2011
    Messages:
    5,255
    Location:
    Norway
    I'll fix these.
    I guess "field hospital" should require "battlefield medicine", and obsolete at "modern health care"; not the other way around? (@Thunderbrd )
    Strange bug, I'll investigate it.
     
    Snofru1 likes this.
  14. Toffer90

    Toffer90 C2C Modder

    Joined:
    Oct 16, 2011
    Messages:
    5,255
    Location:
    Norway
    It's probably caused by this line { in CvPlayer.cpp - getProductionNeeded() } :
    iModifier = GC.getEraInfo((EraTypes)GC.getUnitInfo(eUnit).getEraInfo()).getTrainPercent();

    GC.getUnitInfo(eUnit).getEraInfo() returns NO_ERA instead of ERA_PREHISTORIC for the "Brute" and "Stone Thrower", so it returns a -1 when it should return a 0
    NO_ERA = -1
    ERA_PREHISTORIC = 0
    ERA_ANCIENT = 1
    etc.

    Spoiler CvUnit.cpp :
    Code:
    int CvUnitInfo::getEraInfo() const
    {
        if (getPrereqAndTech() != NO_TECH)
        {
            return GC.getTechInfo((TechTypes)getPrereqAndTech()).getEra();
        }
        else
        {
            TechTypes eHighestTech = NO_TECH;
            for ( int i = 0; i < GC.getNUM_UNIT_AND_TECH_PREREQS(); i++)
            {
                if ( getPrereqAndTechs(i) != NO_TECH )
                {
                    if (eHighestTech == NO_TECH)
                    {
                        eHighestTech = (TechTypes)getPrereqAndTechs(i);
                    }
                    else if ((int)GC.getTechInfo((TechTypes)getPrereqAndTechs(i)).getEra() > (int)GC.getTechInfo(eHighestTech).getEra())
                    {
                        eHighestTech = (TechTypes)getPrereqAndTechs(i);
                    }
                }
            }
            if (eHighestTech != NO_TECH)
            {
                return GC.getTechInfo(eHighestTech).getEra();
            }
        }
        return NO_ERA;
    }
    So what does GC.getEraInfo(NO_ERA).getTrainPercent(); return?
    Or rather, what does NULL.getTrainPercent(); return? It returns a problem I'm sure.
     
    Last edited: Feb 27, 2018
  15. Snofru1

    Snofru1 Chieftain

    Joined:
    Dec 29, 2005
    Messages:
    1,058
    Location:
    Germany
    When you try to construct a "Myth - Seaturtle" (from a subdued seaturtle) you get a "TEXT_KEY_BUILDING_SEATURTLE_MYTH_EFFECT".
     
  16. Thunderbrd

    Thunderbrd C2C War Dog

    Joined:
    Jan 2, 2010
    Messages:
    24,747
    Gender:
    Male
    Location:
    Las Vegas
    Would've been an easy mistake to make. I'm sure you're right about the analysis.

    Ah... damn... forgot you would get units without tech prereqs. I'll have to resolve that tonight.
     
  17. MlnwY

    MlnwY Chieftain

    Joined:
    Dec 20, 2015
    Messages:
    24
    Gender:
    Male
    The same happened to Tradition - Aesthetics and Tradition - Work Ethic
     
  18. Toffer90

    Toffer90 C2C Modder

    Joined:
    Oct 16, 2011
    Messages:
    5,255
    Location:
    Norway
    @Dancing Hoskuld, you are more familiar with this content than me.
    I'll let you evaluate whether the techprereq and obsolete techs are swapped for those buildings.
     
    Last edited: Feb 27, 2018
    MlnwY likes this.
  19. Raledon

    Raledon Chieftain

    Joined:
    Aug 15, 2008
    Messages:
    236
    It seems the grand festivals construction cost is a bit on the high side.
    Normal buildings on that column cost 100 production or so, while they cost 650. I expected it should be around the 400.
     
  20. raxo2222

    raxo2222 Warlord

    Joined:
    Jun 10, 2011
    Messages:
    4,782
    Location:
    Poland
    Recosting oopsie by @Thunderbrd
     

Share This Page