1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

Single Player bugs and crashes v39 plus (SVN) - After the 20th of July 2019

Discussion in 'Bugs and Crashes' started by Thunderbrd, Jul 21, 2019.

  1. Yudishtira

    Yudishtira Spiritual/Creative

    Joined:
    Nov 2, 2012
    Messages:
    2,687
    Location:
    Brisbane
    I have to double check this. I've no idea now what I based this assertion on.

    It still looks pretty suss though doesn't it? It looks like it could happen repeatedly, if so the adjust fertility still needs dialling back, and the routine name refers to "Dormant Eruption" but the TXT_KEY says "Extinct"

    If I may try again...

    This code:
    Code:
    def doVolcanoNewEruption(argsList):
      kTriggeredData = argsList[0]
      pPlot = GC.getMap().plot(kTriggeredData.iPlotX, kTriggeredData.iPlotY)
      if pPlot.isNone():
        return
      player = GC.getPlayer(kTriggeredData.ePlayer)
      team = player.getTeam()
    
      doVolcanoPlot(pPlot)
      doVolcanoNeighbouringPlots(pPlot)
      doVolcanoAdjustFertility((pPlot, 1, team))
      doVolcanoReport((pPlot, BugUtil.getPlainText("TXT_KEY_EVENT_TRIGGER_VOLCANO_NEW")))
    
      return
    
    ...sends the message: "Reports from the ... empire speak of increased volcanic activity." That is the text of the TXT_KEY quoted, and that key is not referenced anywhere else.

    This should definitely use getText not getPlainText.

    I'm staring at the screen trying to decide if this could happen repeatedly. I'm unable to say for certain either way, so I'll assume there's no bug in the adjust fertility.

    So I'll leave it there: here lie the tattered but still useful remains of an ambitious bug report...
     
    Last edited: Oct 22, 2019

Share This Page