Thunderbrd
C2C War Dog
How did we setup new types or is that a standard?
Actually let me rephrase the question - did WE set up those new types or is there a coding standard already in play here?
Single Player bugs and crashes v40 plus (SVN) - After Oct 2019
- Thread starter Thunderbrd
- Start date
Actually let me rephrase the question - did WE set up those new types or is there a coding standard already in play here?
I think it's a standard.
When I were setting up unit upkeep as a "long long" I got some text errors long before the value should have overflowed, so I figured it was that %d was not compatible with "long long"; I looked after other usage of long long in the gametext cpp and saw that %lld and %llu were already in use for them, after switching to %lld for unit upkeep the text error went away in my save.
When I were setting up unit upkeep as a "long long" I got some text errors long before the value should have overflowed, so I figured it was that %d was not compatible with "long long"; I looked after other usage of long long in the gametext cpp and saw that %lld and %llu were already in use for them, after switching to %lld for unit upkeep the text error went away in my save.
It seems to be a C++11 standard: https://en.cppreference.com/w/cpp/io/c/fprintf
Thunderbrd
C2C War Dog
Thanks! I had no idea that existed so it's very good to know. It's one of those spots I couldn't think of a way to address if certain values were housed as long long.
Thunderbrd
C2C War Dog
I think you lost a lot when the amount stored in the Greater Culture variable was eliminated. There was not a transitional coding to update a game in progress inserted when the coding was changed and all the amount was then to be stored on the one Culture variable. So it's not 'bugged' so much as it's penalized by the update. You should be able to make up for this deficit by playing through it and it will hurt you but it hurts all competitors as well so it's up to you whether you want to continue the game or start a new one basically. Though you may be trying to debug it and not the player iirc.
I'll look into it soon, and I have an old save perfect to investigate with.
Attached is a screenshot that have these numbers:
Total culture:
Greater culture + normal culture from the old save is correctly translated to the new single long long culture variable.
100 greater culture + 185 440 culture
This is what the save had before the culture storage change.
None of these values would overflow a regular 32 bit integer, but irishhombres screenshot may have had just that for the next level threshold value.
Irishhombre's values:
Total culture:
It seems the thresholds for when you are supposed to get a new trait is somehow different now, that the old code had faulty logic in how it dealt with greater culture, or perhaps the new code was badly converted to not deal with greater culture.
Anyhow, I'll look into the matter tomorrow I think. My gut tells me it should be easy enough to fix.
Attached is a screenshot that have these numbers:
Total culture:
100 185 440
Next level at:40 000 000
Difference:-60 185 440
Greater culture + normal culture from the old save is correctly translated to the new single long long culture variable.
100 greater culture + 185 440 culture
This is what the save had before the culture storage change.
None of these values would overflow a regular 32 bit integer, but irishhombres screenshot may have had just that for the next level threshold value.
Irishhombre's values:
Total culture:
525 969 287 (probably a correct value)
Threshold:-416 677 888 (A bug. Negative!! May be an int 32 overflow at work here or a math/logic error in the calculation code)
Difference:-942 647 175 (This value is correct! -416 677 888 - 525 969 287 = -942 647 175)
It seems the thresholds for when you are supposed to get a new trait is somehow different now, that the old code had faulty logic in how it dealt with greater culture, or perhaps the new code was badly converted to not deal with greater culture.
Anyhow, I'll look into the matter tomorrow I think. My gut tells me it should be easy enough to fix.
Attachments
Last edited:
SVN 11221: Got a Python Exceltion error at the start of my turn, does it imply I was supposed to be granted sulphur by a random event and it bugged out? Here is the end of turn save from just before this happens, the bug is repeatable on my end so hopefully will be the case for others.
Attachments
https://github.com/caveman2cosmos/Caveman2Cosmos/pull/644/files
You'll have to wait a bit till svn is fixed. But you can do it yourself if you want.
You'll have to wait a bit till svn is fixed. But you can do it yourself if you want.
Thanks for that, I have the error messages on ever since I reported another bug and was shown how to put the python messages on to track it down easier.
Lol, loaded my game up and what a letdown, was hoping to see some sort of event that meant I'd discovered a source of Sulphur but it turned out to be "Hittite merchants are now selling gunpowder in record amounts" - curse those Hittites.....
Lol, loaded my game up and what a letdown, was hoping to see some sort of event that meant I'd discovered a source of Sulphur but it turned out to be "Hittite merchants are now selling gunpowder in record amounts" - curse those Hittites.....
Last edited:
GreatLordofPie
Prince
- Joined
- Nov 20, 2009
- Messages
- 386
You probably don't have this file for some reason (see attachment).
It's supposed to be in the root folder of the mod, so not inside the "assets" folder but alongside it.
GreatLordofPie
Prince
- Joined
- Nov 20, 2009
- Messages
- 386
That's probably it, I was copying the constituent folders individually since SVN was giving me trouble if I tried it with the whole thing
primem0ver
Emperor
I am encountering an odd issue. Lately I have been getting a CTD every time I start the game and then load my save. However, if I start the game again and load the save again, no issues. It might be related to the fact that I recently created a utility to generate build lists based on rules and store them in the profile file which is now quite large (418 KB). Not sure why it would crash one time and then work the next though. I may be willing to share the utility if there is a big enough demand. However, it is a bit quirky at this point (adding and removing rules is still a bit buggy... it easier to just type them in the ini using the example format).
EDIT: Does anyone know if there is a limit to the size of the building queue? Perhaps that is causing the problem. Each number is associated with over 1700 buildings based on different priorities.
EDIT: Does anyone know if there is a limit to the size of the building queue? Perhaps that is causing the problem. Each number is associated with over 1700 buildings based on different priorities.
Last edited:
primem0ver
Emperor
Nope. Not familiar with that process.
strategyonly
C2C Supreme Commander
REpeatable crash . . . . . . . .
Last edited:
Similar threads
- Sticky
- Sticky
