Single Player bugs and crashes v40 plus (SVN) - After Oct 2019

It was part of experimental change, where I removed ALL resource obsoletions.
I guess they could be obsolete, when latest thing referencing it obsoletes.
Just noticed rock gatherer which required by stone tools and rock arts obsolete with iron working. Dunno, though i remember in 1 my game had it in building screen providing nothing (which means iron working was researched already)
 
Screenshot_7.png
Hunter on auto-hunt + go to city for upgrades.
They just making event log junkyard. Every hunter spam tonns of messages that he arrived for upgrades :crazyeye: auto-upgrade and continuing hunt, without involving player but i cant see important stuff in event log cuz of this
 
View attachment 549399
Hunter on auto-hunt + go to city for upgrades.
They just making event log junkyard. Every hunter spam tonns of messages that he arrived for upgrades :crazyeye: auto-upgrade and continuing hunt, without involving player but i cant see important stuff in event log cuz of this
Yeah, I experimentally turned this ON (never did before) - and almost immediately turned it OFF when I saw how it not only flooded my log, but also still did nothing.
As in, the "hunters" (actually, clubmen and so on) didn't even do zilch, but kept sitting in the city for turns upon turns (I didn't wait much, but they still just idled there).
Note that I already had the civ trait that lets you upgrade units OUTSIDE your borders, so this was TWICE STUPID.
 
Yeah, I experimentally turned this ON (never did before) - and almost immediately turned it OFF when I saw how it not only flooded my log, but also still did nothing.
As in, the "hunters" (actually, clubmen and so on) didn't even do zilch, but kept sitting in the city for turns upon turns (I didn't wait much, but they still just idled there).
Note that I already had the civ trait that lets you upgrade units OUTSIDE your borders, so this was TWICE STUPID.
O.o they upped for me (i dont have that perk, maybe will pick later dunno, right now all i need is GOLD nightmare... ya know)
 
O.o they upped for me (i dont have that perk, maybe will pick later dunno, right now all i need is GOLD nightmare... ya know)
Maybe I misjudged the facts there, but they DID keep sitting in my city.
Plus, I did have "upgrade outside borders" ON, so this made little sense altogether.
Speaking of which - I still don't understand why Auto-Upgrade DOESN'T WORK AT ALL.
Or at least it does very weirdly.
Unless I managed to turn it OFF and didn't pay attention to it.
 
View attachment 549399
Hunter on auto-hunt + go to city for upgrades.
They just making event log junkyard. Every hunter spam tonns of messages that he arrived for upgrades :crazyeye: auto-upgrade and continuing hunt, without involving player but i cant see important stuff in event log cuz of this
It's a pretty new BUG option that @billw2015 added.
The message flood is, at least to me, a known issue, and I tried looking into it a week ago, but I couldn't figure out why it gave 30-40 messages when it should only be one, there was no erroneous "for/while" loop for the message code line..
 
Did a complete refresh of my SVN folder so I now have a fresh copy of 11135. I also made sure my user settings folder was created from scratch.

I started a new game as Fredrick of the Germans and found within a dozen turns, another AI player had won a scientific victory.

I have attached my UserSettings folder. Anyone else having this issue?
 

Attachments

lol, I did tinker a bit with the victory code, probably messed something up, will look into it asap.
Got this assert when I clicked on victory screen.
Code:
ASSERT FAILED
==============================================================================================================================================================================
File:        d:\modstuff\caveman2cosmos_git\sources\CvPython.h
Line:        229
Expression:  bOK
==============================================================================================================================================================================
MESSAGE:
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
CvScreensInterface.showVictoryScreen
==============================================================================================================================================================================
DLL CALLSTACK:
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
git\sources\cvpython.h (229): Cy::call
git\sources\cvgameinterface.cpp (2277): CvGame::doControl
04F5E7EA (CvGameCoreDLL): (filename not available): __security_error_handler
74636956 (module-name not available): (filename not available): (function-name not available)
FFFFFD24 (module-name not available): (filename not available): (function-name not available)
92490000 (module-name not available): (filename not available): (function-name not available)

Python error:
Traceback (most recent call last):

  File "CvScreensInterface", line 187, in showVictoryScreen

  File "CvVictoryScreen", line 112, in interfaceScreen

  File "CvVictoryScreen", line 688, in showVictoryConditionScreen

AttributeError: 'CvBuildingInfo' object has no attribute 'getVictoryThreshold'
ERR: Python function showVictoryScreen failed, module CvScreensInterface

I had all victory conditions selected except mastery.
It seems like you didn't test it.

I won scientific victory after 11 turns lol

On unrelated note there is building, that gets boost from stone tools, that obsoletes in Renaissance (Humanism).
Its Omega Child Crew.
I could make it obsolete at Iron Working together with Stone Tools Workshop.
Otherwise losing +3% hammers from one resource being obsolete looks weird.
 
Last edited:
On unrelated note there is building, that gets boost from stone tools, that obsoletes in Renaissance (Humanism).
Its Omega Child Crew.
I could make it obsolete at Iron Working together with Stone Tools Workshop.
Otherwise losing +3% hammers from one resource being obsolete looks weird.
At least in English history, the Industrial Era is the one most notorious for child labour. If this building is not to be replaced, it should not obsolete until Information Era, when newspaper delivery jobs cease to be a thing. (And even now I'm sure there are loopholes to exploit kids).
 
At least in English history, the Industrial Era is the one most notorious for child labour. If this building is not to be replaced, it should not obsolete until Information Era, when newspaper delivery jobs cease to be a thing. (And even now I'm sure there are loopholes to exploit kids).
It doesn't have replacements.
I think this one was hunter-gatherer child labor building.
It requires earliest civics if you want to build it, but doesn't require them to work.

It could be expanded into series of child labor buildings, that represent changing economy of civilizations.
That is hunter-gatherer/agricultural/industrial/services.

Agricultural one wouldn't have boost from stone tools, as they already would be common.
 
Last edited:
I had all victory conditions selected except mastery.
It seems like you didn't test it.

I won scientific victory after 11 turns lol
Even when I revert my code refactoring of the victoryTest code the error persist, so I'm thinking the error stems from the buildingclass removal;
something related to this tag:
Code:
<VictoryThresholds>
    <VictoryThreshold>
        <VictoryType>VICTORY_SCIENTIFIC</VictoryType>
        <iThreshold>1</iThreshold>
    </VictoryThreshold>
</VictoryThresholds>
belonging to BUILDING_ASCENSION_GATE.
Which was moved from BuildingClassInfo to BuildingInfo.

The python error from the victory advisor screen is easy to explain as MattOttawa didn't expose the getVictoryTreshold function to python after moving it from BuildingClassInfo to BuildingInffo.

I'm still struggling with figuring out why scientific victory is triggered right away though, not as easy to explain that.
 
Found this code in CvGame.cpp

Code:
    // Scientific Victory
    if (bValid)
    {
        for (int iK = 0; iK < GC.getNumBuildingInfos(); iK++)
        {
            if (GC.getBuildingInfo((BuildingTypes)iK).getVictoryThreshold(eVictory) > GET_TEAM(eTeam).getBuildingCount((BuildingTypes)iK))
            {
                bValid = false;
                break;
            }
        }
    }
 
Found this code in CvGame.cpp

Code:
    // Scientific Victory
    if (bValid)
    {
        for (int iK = 0; iK < GC.getNumBuildingInfos(); iK++)
        {
            if (GC.getBuildingInfo((BuildingTypes)iK).getVictoryThreshold(eVictory) > GET_TEAM(eTeam).getBuildingCount((BuildingTypes)iK))
            {
                bValid = false;
                break;
            }
        }
    }
That is related, yes, but it looks fine and hasn't really been changed for years.
 
It doesn't have replacements.
I think this one was hunter-gatherer child labor building.
It requires earliest civics if you want to build it, but doesn't require them to work.

It could be expanded into series of child labor buildings, that represent changing economy of civilizations.
That is hunter-gatherer/agricultural/industrial/services.

Agricultural one wouldn't have boost from stone tools, as they already would be common.
A series of buildings is unnecessary work imho, better idea is keep the one building but vary the yields on it.

And "appropriate name for era" isn't an issue, it's a Mr Azure name so it's inappropriate for all eras equally...:rolleyes:
 
A series of buildings is unnecessary work imho, better idea is keep the one building but vary the yields on it.

And "appropriate name for era" isn't an issue, it's a Mr Azure name so it's inappropriate for all eras equally...:rolleyes:
Well once stone tools are obsoleted building loses +3% boost to production from stone tools.
This is why now I made it so Stone Tools Workshop obsoletes together with Omega Child Crew.
This building upgrade chain would avoid that issue.
 
Last edited:
where is the POP limit gone??? should only be able to build 1 town first(1st tech), then 2-3(Chiefdom), etc something like that, was there before??

they didnt bother going too far from their area for a loooong time????
 

Attachments

  • max.JPG
    max.JPG
    311.7 KB · Views: 29
Back
Top Bottom