I noticed (and was confused by) an issue with the text presented for a potential building choice in the city screen yesterday. My game is C2C so the particular buuilding and civics may not apply to AND (not sure, but there are analogous cases definately). In my case the building was a Seminary which requires one of State Chruch or Free Church civics to be in operation. I was in Free Chrurch at the time.
When I hovered over the seminary in the choice list the text said 'requires state church' which confused me.
The requires XXX lines associated with civics are coded to only show the requirements that you lack. This makes a certain amount of sense in the AND requirements but is confusing for the OR ones (since it tells you that you need something when you already have the necessary requirements)
Initailly I was going to fix the code to only display OR requirements if NONE of them are currently fulfilled (which would be consistent in effect with what you get for AND requirements). However, it then occurred to me that if I am in civic X which is supporting a building I'd really like to know what alternative civic would ALSO support it to help with my civic-changing decisions. That would be an argument for always displaying the OR requirements regardless of whether one or more is fulfilled.
I'm not sure what the least confusing option is here, so I'd welcome some opinions. In the absence of other suggestiosn I'll probably just push a fix to hide the OR requiremenst if one is fulfilled, for semantic consistency with the AND display, but I don't really think this is ideal...
Edit - I understand what's going on better now, and I'm planning to change it (see below).
Currently help text (whether hover text or actual Civopedia entry generated text) only displays conditions that it cannot evaluate as met in the context of the particular text generation. Those it cannot evaluate as met it displays in red (so unevaluatable conditions like required pre-req buildings when viewing the Civopedia from a context other than a particular city screen, show up along with ones it KNOWS you don't meet). Some consequences of this are:
- Building (or unit) hover text in the city screen never shows the conditions required that are currently met, even if at some future time they may no longer be met (so a civic that is currently in force which is required for example). This measn when you check out the hover help you won't be aware that what you are building will cease to function when you change a civic (or at least which civic change will break it)
- OR conditions may 'half' show up as in my initial example, which caused me some confusion
- Worst of all (IMO) when you look at the Civopedia entry for a building/unit outside of the context of a city just to learn about it, any conditions on it that happen to be met at the time (civics is the best example) won't be mentioned at all. So even looking at things in the Civopedia won't clue you in that the building might go non-operational on some civic change (actually it will mention that civis are required but not which!)
I propose to change the text generation (at least for civic requirements on buildings for now - will consider more general application later) so that all conditions always appear but the color highlighting tells you whether the condition is currently met or not (so only conditions that are not currently met will appear in red, thsoe that are in normal non-warning text).
Opinions welcome...