A New Dawn Bug Reports and Feedback

[JosEPh_II]

Good job on the Coinage fix flitz!

@Jazzer32.
Those XML errors are things that are in C@C but not built upon in AND. Seems Afforess hasn't finished separating some of the additional C2C stuff from AND.

JosEPh

 

[flitz]

Good job on the Coinage fix flitz!

@Jazzer32.
Those XML errors are things that are in C@C but not built upon in AND. Seems Afforess hasn't finished separating some of the additional C2C stuff from AND.

JosEPh

Oh ... I an attempt to make the fix more general (currently it was limited to the coinage civic), I found out that it can be done way more simple than I thought:

The problem that the same bonus just got added over and over again (and resources where never given back) was due to the missing red factor:

changeBonusMintedPercent((BonusTypes)iI,[COLOR="Red"] iChange *[/COLOR] kCivic.getBonusMintedPercent(iI));

Doing it this way is actually standard procedure in the SDK. When changing a civic the bonuses that the old civic gave are first retracted and then the bonuses of the new civic are added. That way it is made sure that bonuses of the same type used across multiple civic categories stack correctly.
(In the first call to the function this factor is set to -1, meaning to subtract any current civic bonuses of the treated civic category, on the second run it is set to 1 meaning to add all bonuses of the new civic)

Only the bug was here that retracting the old bonus wasn't done, it was added another time. This only _increased_ the minted percentage for gold and silver. And as long as any resource has set a minted percentage of > 0, you are denied any further use of this resource. That's why after switching away from coinage, you didn't get your gold and silver back.

I also uploaded the newer version of the dll. But it shouldn't make a difference for the current state of the mod. But if somebody wanted to add a similar bonus to some civic for any resource, the first fix would not work, but the new one is generic enough to work in all cases - even future xml changes.

 

[Jazzer32]

Its OK now, It works with beta 2.0. Btw, I encountered some strange bug: I cannot build a single world or national wonder. For every wonder there is "Can construct only 0 world/national wonders per city". Am I missing some civic or what?

 

[flitz]

Its OK now, It works with beta 2.0.

Great

Btw, I encountered some strange bug: I cannot build a single world or national wonder. For every wonder there is "Can construct only 0 world/national wonders per city". Am I missing some civic or what?

I searched the xml files of the mod and the search found this:

  G:\Spiele\Civilization IV\Beyond the Sword\Mods\Rise of Mankind - A New Dawn\Assets\XML\GlobalDefines.xml (6 hits)
	Line 309: 		<DefineName>MAX_WORLD_WONDERS_PER_CITY</DefineName>
	Line 313: 		<DefineName>MAX_TEAM_WONDERS_PER_CITY</DefineName>
	Line 317: 		<DefineName>MAX_NATIONAL_WONDERS_PER_CITY</DefineName>
	Line 321: 		<DefineName>MAX_NATIONAL_WONDERS_PER_CITY_FOR_OCC</DefineName>
	Line 325: 		<DefineName>MAX_BUILDINGS_PER_CITY</DefineName>

So, look inside the Moderator Action: /assets/xml/CIV4GlobalDefines.xml
at those lines what values are defined inside those tags, please.

In my version for example there is:

		<DefineName>MAX_WORLD_WONDERS_PER_CITY</DefineName>
		<iDefineIntVal>5</iDefineIntVal>
	</Define>
	<Define>
		<DefineName>MAX_TEAM_WONDERS_PER_CITY</DefineName>
		<iDefineIntVal>5</iDefineIntVal>
	</Define>
	<Define>
		<DefineName>MAX_NATIONAL_WONDERS_PER_CITY</DefineName>
		<iDefineIntVal>6</iDefineIntVal>
	</Define>

Maybe you accidently changed something.
Please read the forum rules: http://forums.civfanatics.com/showthread.php?t=422889

 

[Jazzer32]

No man, I do not "accidentally" change xml files. Im even scared when i need to open it in viewer. And in my xml file its like :

<DefineName>MAX_WORLD_WONDERS_PER_CITY</DefineName>
<iDefineIntVal>5</iDefineIntVal>
</Define>
<Define>
<DefineName>MAX_TEAM_WONDERS_PER_CITY</DefineName>
<iDefineIntVal>5</iDefineIntVal>
</Define>
<Define>
<DefineName>MAX_NATIONAL_WONDERS_PER_CITY</DefineName>
<iDefineIntVal>6</iDefineIntVal>
</Define>

maybe savegame can help?

View attachment Miro BC-0775.CivBeyondSwordSave

 

[Jazzer32]

I discovered what is the problem...

When i was making a custom game I haven't checked "Unlimited wonders" box. So i Coudn't make a SINGLE wonder. I think that option shouldn't reduce world and national wonders to zero.

 

[45°38'N-13°47'E]

I discovered what is the problem...

When i was making a custom game I haven't checked "Unlimited wonders" box. So i Coudn't make a SINGLE wonder. I think that option shouldn't reduce world and national wonders to zero.

It was a bug of some early version 2.0; it should be ok in the latest SVN version, even with "unlimited wonders" unchecked.

 

[flitz]

It was a bug of some early version 2.0; it should be ok in the latest SVN version, even with "unlimited wonders" unchecked.

Ha, I just correctly guessed your home country based on your geographical information in your nickname

 

[45°38'N-13°47'E]

Ha, I just correctly guessed your home country based on your geographical information in your nickname

Since I am less than 10 km from the border with Slovenia, it's good Could have been a near miss

 

[flitz]

Since I am less than 10 km from the border with Slovenia, it's good Could have been a near miss

Yes I was lucky
I estimated myself as close to 15°E but that is off by about 3°E

 

[Stelmack]

I currently have a bug where 100's of resources become available. I have 0 iron, but once I get 1, I end up with like 30. Same with all other resources, and the AI.

 

[buck beach]

A variation of that posted on the Error tracking log. I was accumulating espionage points at 5% and they were showing. After some time I looked up and Espionage was gone from the funds allocation table. On the F9 screen it appeared they accumulated off the chart.

 

[Imiona]

Can someone tell me if its possible to play this mod without the custom Leaders?

 

[Pogman]

Game crashed to desktop when I clicked on/moused over The Vietnamese empire, ruled by Ho Chi Minh, on the bar at the side. He is a new revolution.
The save game file is here -
http://www.4shared.com/file/a7KTHuEX/Boeo_AD-1828.html?
I have some of the additional civs but not all.

 

[gdambrauskas]

That DLL doesn't work - when I overwrite old DLL I cannot load ROM-AND mod anymore.

could you attach source too? or it's already in the svn? i would like to make this part of my mod code, otherwise it's kinda useless if all i have is dll with the fix.
thanks

 

[gdambrauskas]

didn't read all of the post

changeBonusMintedPercent((BonusTypes)iI, iChange * kCivic.getBonusMintedPercent(iI));

will compile this into my dll. Good catch (i am often horrified at the changes made in mods ie i see comments 'made major changes in AI, didn't test, lets hope it works'... ).

 

[StormLord-711-]

I have a bug with furrier buildings in this game that I'm playing [attached]. One of them is giving way more than it is supposed to. (The other one actually starts to do the same thing in later turns.) I think what might be happening is that each time the furrier becomes inactive (when an enemy is standing on the nearby deer tile, which has happened a lot in this game) and then active again, +2 is added to the furrier. If you play further into this save the effect might get larger too.

EDIT: I just discovered that my stoneworker's hut in my capital is doing the same thing.

 

[JosEPh_II]

I currently have a bug where 100's of resources become available. I have 0 iron, but once I get 1, I end up with like 30. Same with all other resources, and the AI.

This is generally the map scripts fault.

JosEPh

 

[45°38'N-13°47'E]

This is generally the map scripts fault.

JosEPh

Isn't it a bug that was present in some older rev of AND2? Isn't it what we were talking about here 6 months ago?

http://forums.civfanatics.com/showpost.php?p=11218791&postcount=4287

I suppose it's been solved in the latest svn version, since I'm playing with the latest version since a couple of months and I've never seen this problem again.

 

[JosEPh_II]

Isn't it a bug that was present in some older rev of AND2? Isn't it what we were talking about here 6 months ago?

http://forums.civfanatics.com/showpost.php?p=11218791&postcount=4287

I suppose it's been solved in the latest svn version, since I'm playing with the latest version since a couple of months and I've never seen this problem again.

Yes iirc,I believe we did.

JosEPh