Bug Reports

[Lib.Spi't]

Spoiler :

Assert Failed

File: CvPlotGroup.cpp
Line: 404
Expression: m_iDomesticMarket >= 0
Message:

Had this appear. Don't know if it is important..

I also got a crash when trying to load a game from within a game. When I restarted the mod I was able to load the save from the main menu.

Spoiler :

Assert Failed

File: CvPlayer.cpp
Line: 21148
Expression: pPlotGroup != NULL
Message: city lacks a plotgroup

Also a crash when exiting game to main menu.

 

[Kailric]

Yeah, I am aware of those two bugs as well. The first one appeared once when I acquired a Vassal so something is erroneous in the code there, and the other happens when a Player is created during a game, such as a Vassal.

I also have had random crashes loading games, but the next time I attempt it it works, so not sure what the deal is there, may have to get Night to check that out when he can as I may have did some coding taboo I am unaware of. Some of the new arrays are saved but I bet I can make them not save and perhaps bypass some errors.

 

[Nightinggale]

I'm aware of the crash on quit. On quit, it can somehow manage to free some memory and then access it. It sounds like it is simple to solve, but the debugger doesn't tell me what the object is meaning I don't know which object I should fix.

I don't think it is possible to crash the game due to missing plotgroups. It will assert, but I attempted to make a fallback solution if that happens meaning the game will try to do something as good as possible and it should be possible to continue the game. Maybe the fallback is buggy (buggy bug protection ) or maybe Kailric added new code relying on plotgroups, which just assumes that there is one.

 

[Lib.Spi't]

Yeah, none of the errors broke my game, it carried on fine, I just posted it incase it was of some value or importance.

Fortunately the loading and exiting crash is not that big of a deal, just a minor nuissance.

 

[Lib.Spi't]

TXT_KEY_YIELD_BUILDING_CONSUMPTION_MULTIPLIER

In the Import/export box in city screen.

Assert Failed

File: CvCity.cpp
Line: 5752
Expression: (iYield == YIELD_FOOD) || (aiYields[iYield] >= 0)
Message:

I am not certain, but I don't think the +2 max pop is working for the wooden walls, I just built it, but I still have a max pop of 9?


Assert Failed

File: CvCity.cpp
Line: 4843
Expression: iValue >= 0 || eYield == YIELD_FOOD
Message:

I am not sure if the recruits upgrade is working as intended, he becomes a cavalryman if he does anything in the settlement, and if I place him in a school, it takes the same amount of time for him to upgrade as when he does anything else. In the description it mentions him upgrading when producing education? Misleading or not working right?

Assert Failed

File: CvUnit.cpp
Line: 6605
Expression: kCity.foodDifference() < 0
Message:

Assert Failed

File: CvPlotGroup.cpp
Line: 404
Expression: m_iDomesticMarket >= 0
Message:
This one may have led to a ctd, but I am not certain as the game was behaving strangely at the same time. (It does lead to a CTD, It seems to be some kind of infinite error I think.)

Oh well, up to that point I was having great fun.
The domestic markets really give me a decision about developing the auto market, travelling to villages, or travelling to the Trade screen for the best price.

 

[Kailric]

I am not sure if the recruits upgrade is working as intended, he becomes a cavalryman if he does anything in the settlement, and if I place him in a school, it takes the same amount of time for him to upgrade as when he does anything else. In the description it mentions him upgrading when producing education? Misleading or not working right?

It is working as intended at the moment. We should drop the Education part and just leave the "while working in your settlement".

Can you post a save to that CTD?

 

[Lib.Spi't]

There we go, that auto save is 1 or 2 turns from the crash.

 

[Kailric]

Ok, I found the crash bug. The AI had acquired a City and the Old one was Killed, but it didn't have a plotgroup, and my code assumed it did. Perhaps this has something to do with the other failed assert that a city plot doesn't have a plotgroup. Anyway, I fixed that issue and posted a new DLL below. Your saved game now continues on to the next turn. I didn't go any further than that

 

[Lib.Spi't]

Sweet!

 

[Lib.Spi't]

Assert Failed

File: c:\users\teddy mac\documents\my games\sid meier's civilization iv colonization\mods\medieval_conquest\sourcedll\dll_sources\CvPlayerAI.h
Line: 25
Expression: ePlayer < MAX_PLAYERS
Message: Player is not assigned a valid value

----------------------------------------------------------

Assert Failed

File: CvSelectionGroupAI.cpp
Line: 196
Expression: false
Message:

Assert Failed

File: CvGameTextMgr.cpp
Line: 9576
Expression: iBaseModifier == kCity.getBaseYieldRateModifier(eYieldType)
Message: Yield Modifier in setProductionHelp does not agree with actual value

----------------------------------------------------------


(not connected to the asserts)
I get a CTD from this turn, no idea why..

 

[Kailric]

I tried this but didn't get a crash? Was there anything else you did before next turn as the turn wasn't finished when I loaded it?

 

[Lib.Spi't]

no, not really, basically it was really weird, as it crashed before I finished the turn, and it crashed at a different moment each time, I was doing two different things when it gave out..

I also didn't get any errors.

Just tried it again, and it seemed to be fine, then I did a 'go to' move, with the mouse shortcut, hold right click or whatever it is, and when I released it crashed...

Tried again, and when I moved the silver miner at the bottom of the screen it crashed, same go to move as before, going to try again and see if it is that that is the error, and see if I can get to a specific action.

Yeah the turn after the load, you get a silverminer in the south, when I try to do a one space goto move it crashes.

Yep it definately seems to be linked to moving the silver miner in the south, I just tried moving him with the keys instead of goto and it crashed as well.

Very strange..

Yeah it is definately moving him that is the problem, I just skipped his turn and it was fine, then tried to move him next turn and crash.

 

[Kailric]

I'm moving him, the Silver Miner on the Snow at the farthest south, and there are no crashes. Is there a particular direction that causes crash or any direction?

 

[Lib.Spi't]

hmmm how strange, it must be some kind of random game session specific issue or something I don't know.

I tried moving him in several directions, and several distances, even inside or outside of the silk road.

I tried with keyboard and mouse click, all attempts led to a crash...

It must be something specific to my system or something..

Oh well I shall just start a new game and see how I go from scratch again.

I am a little bored with this playthrough, as there was no decent location to found my silk road camp, or mine silver.. at least on my continent.

I am also faqirly certain that when I posted it it wasn't crashing because of the silver miner.. So who knows what the cause was/is!

 

[Kailric]

You could try to delete the SilverMiner, and add another one. Or add another unit there and see if it crashes when you move that one. Yeah, it is very strange, and since I can't reproduce it I can't debug it

 

[Lib.Spi't]

Yeah, I might test out some more attempts. My thinking was just to delete the miner as you say, as the reason he was there was null as I could not found where I wanted to.

 

[Kailric]

Yeah, I might test out some more attempts. My thinking was just to delete the miner as you say, as the reason he was there was null as I could not found where I wanted to.

That is a good point, I noticed there was a Silver bonus down there. I need to add code so that Bonuses are not placed on Trade Screen access plots so that are not wasted.

 

[Lib.Spi't]

Yeah, it was also the fact that it was all ice and I wanted to get the crab and mountain plot.

I always like to get a town right on the spice route, so I can ship spice/silk between screens as quick as possible.

 

[Lib.Spi't]

CTD Bug on ending first turn:

Bug Post from Download Thread

 

[Kailric]

K, must not posted the files correct as it's working for me, or did you install it correctly?. Did you try another game, maybe that one was messed up