Single Player bugs and crashes v36 plus (SVN) - After the 24th of October 2015

[Dancing Hoskuld]

We have an old merge of Platyping's World Builder done by AIAndy. The newest has it all in one file but the old one has bits in a few files. I never got my head around it. See CvWBInterface.py in Python/EntryPoints

 

[Thunderbrd]

We have an old merge of Platyping's World Builder done by AIAndy. The newest has it all in one file but the old one has bits in a few files. I never got my head around it. See CvWBInterface.py in Python/EntryPoints

On review of that file, I found and fixed the problem. That simple. Good teamwork thanks!

 

[strategyonly]

1. I think someone changed this TXT by mistake (Neand)?? pic 1

2. Was the Neand Stone thrower taken out?? pic 2

3. I got a Great General, BUT the pop-up used a Great Statesman and also said i received one, BUT i didnt?? pic 3

 

[Thunderbrd]

1) No... no... that was me being stupid and forgetting to add the text for the text key. I'll get right on that.
2) Yes it was.
3) Too bad you didn't catch the popup. That's where the error would've been and I'm not sure what to look for there.

 

[Dancing Hoskuld]

3)

I have that happen also. The text in the log also said Great Statesman

 

[Thunderbrd]

3)

I have that happen also. The text in the log also said Great Statesman

I need to figure out which text key it is so I can track it back to the code's usage of it. Searching the text file for the specific words used (up to the variable term) is usually how I backtrack.

 

[strategyonly]

3)

I have that happen also. The text in the log also said Great Statesman

I looked all over for the text in the logs, but couldnt find it

 

[Thunderbrd]

@DH: Carvan Guards I, II, III and Caravan Land Movement I are missing their Alpha channels. I was also going to suggest using the iDefenseCombatModifierChange but it looks like you may really only want it to apply on those specific terrain types.

 

[Thunderbrd]

I looked all over for the text in the logs, but couldnt find it

We'll keep an eye out for it then. It will probably manifest reliably.

 

[Dancing Hoskuld]

@DH: Carvan Guards I, II, III and Caravan Land Movement I are missing their Alpha channels. I was also going to suggest using the iDefenseCombatModifierChange but it looks like you may really only want it to apply on those specific terrain types.

1) Every time I try and add an ALPHA channel I get a "size error in layers" message so none of my buttons have an alpha channel.
2) Some I do some I don't

Still
3) UNITCOMBAT_TRADE units are not getting access to the promotions.

 

[Thunderbrd]

@DH: How are we making the player get a free gatherer when reaching gathering? I know the extra is coming in if you're the FIRST to gathering and I see how and why that works but I'm curious about the one everyone gets for free at reaching that tech. The reason I'm asking is because it needs to be adjusted so every member of a team gets it. Now... if I don't understand the current setup like I thought I did and it really is ONLY the first team to reach the tech, then I can figure out how to make it so that all team members get a free one if that happens by making it so that if the first free unit isn't a Great Person then both players get one. I know where that is in the code.

 

[Thunderbrd]

1) Every time I try and add an ALPHA channel I get a "size error in layers" message so none of my buttons have an alpha channel.

What program are you using to add the alpha channel? It sounds like the alpha channel has been resized. Either that or the underlying button save file was resized. Some art programs do this spontaneously or there may be a reason it's happening in the way you're going about it.

If you are having the problem, send me the art file and I'll fix it with the alpha and send it back so you can place it into the mod wherever and however you are going about it. I'm not sure if you're packing the final in an FPK or not.

 

[strategyonly]

What would make the "thief" now after these changes go completely where i cant see them?? and i am not using the hide/seek or combat mod stuff??

 

[Dancing Hoskuld]

@DH: How are we making the player get a free gatherer when reaching gathering? I know the extra is coming in if you're the FIRST to gathering and I see how and why that works but I'm curious about the one everyone gets for free at reaching that tech. The reason I'm asking is because it needs to be adjusted so every member of a team gets it. Now... if I don't understand the current setup like I thought I did and it really is ONLY the first team to reach the tech, then I can figure out how to make it so that all team members get a free one if that happens by making it so that if the first free unit isn't a Great Person then both players get one. I know where that is in the code.

It is done in python on the OnTechAccquired event which passes the player. It also passes the team but as far as I know it fires for each player in the team.

I'll have a look at how Platyping or The_J or whoever does it in their mod that gives a free x on tech discovered.

What program are you using to add the alpha channel? It sounds like the alpha channel has been resized. Either that or the underlying button save file was resized. Some art programs do this spontaneously or there may be a reason it's happening in the way you're going about it.

If you are having the problem, send me the art file and I'll fix it with the alpha and send it back so you can place it into the mod wherever and however you are going about it. I'm not sure if you're packing the final in an FPK or not.

I am using GIMP 2. Currently all my files for the merchant promotions are in the My_Mods/Merchant_Promotions folder. That is where I add stuff that will be in core but is still being tested. Art wont get moved or packed into an FPK until nearer the release.

 

[Thunderbrd]

3) UNITCOMBAT_TRADE units are not getting access to the promotions.

           <TechPrereq>TECH_DUMMY</TechPrereq>

This tech prereq is to ensure the tech can only be given for free or by a direct, non-skill selection based method. This is on PROMOTION_CARAVAN_GUARD_I and PROMOTION_CARAVAN_MARINES_I and it seems most are based on these.

There's also:

           <PromotionPrereqOr1>PROMOTION_CARAVAN_GUARD_I</PromotionPrereqOr1>

This should not be used alone. Without an established <PromotionPrereq> it just means you can't ever qualify for this promo. This tag will only be checked if the <PromotionPrereq> isn't possessed by the unit.

This problem exists on PROMOTION_CARAVAN_MOVEMENT_I

 

[Thunderbrd]

What would make the "thief" now after these changes go completely where i cant see them?? and i am not using the hide/seek or combat mod stuff??

You CAN see them in game terms - you get a flag and a hover description... so it has to be the 3d art itself.

 

[Dancing Hoskuld]

           <TechPrereq>TECH_DUMMY</TechPrereq>

This tech prereq is to ensure the tech can only be given for free or by a direct, non-skill selection based method. This is on PROMOTION_CARAVAN_GUARD_I and PROMOTION_CARAVAN_MARINES_I and it seems most are based on these.

This is the problem. I forgot to set it to the same place the merchant units become available.

There's also:

           <PromotionPrereqOr1>PROMOTION_CARAVAN_GUARD_I</PromotionPrereqOr1>

This should not be used alone. Without an established <PromotionPrereq> it just means you can't ever qualify for this promo. This tag will only be checked if the <PromotionPrereq> isn't possessed by the unit.

This problem exists on PROMOTION_CARAVAN_MOVEMENT_I

It is in theory incorrect but it does work. However I had already fixed it as I suspected it was faster in the code that way.

 

[Dancing Hoskuld]

@DH: How are we making the player get a free gatherer when reaching gathering? I know the extra is coming in if you're the FIRST to gathering and I see how and why that works but I'm curious about the one everyone gets for free at reaching that tech. The reason I'm asking is because it needs to be adjusted so every member of a team gets it. Now... if I don't understand the current setup like I thought I did and it really is ONLY the first team to reach the tech, then I can figure out how to make it so that all team members get a free one if that happens by making it so that if the first free unit isn't a Great Person then both players get one. I know where that is in the code.

It is done in python on the OnTechAccquired event which passes the player. It also passes the team but as far as I know it fires for each player in the team.

I'll have a look at how Platyping or The_J or whoever does it in their mod that gives a free x on tech discovered.

It is based on The_J's code which gives a free nuke to the the player(s) when the tech is discovered. I still need to hunt through Platyping's stuff to see if he does anything similar.

 

[Thunderbrd]

It is done in python on the OnTechAccquired event which passes the player. It also passes the team but as far as I know it fires for each player in the team.

I'll have a look at how Platyping or The_J or whoever does it in their mod that gives a free x on tech discovered.

Thank you!

I am using GIMP 2. Currently all my files for the merchant promotions are in the My_Mods/Merchant_Promotions folder. That is where I add stuff that will be in core but is still being tested. Art wont get moved or packed into an FPK until nearer the release.

I've taken some time to adjust them. BTW, if you can, DDS DXT3 is all that's necessary in terms of graphic quality. You're saving it at a much heavier DDS save format.

Note: I'm also working on fixing the void CvUnitInfo::setQualifiedPromotionTypes() function to include NotOnDomain factors. Let me know if other factors have been overlooked that you can spot.

 

[JosEPh_II]

After updating to 9345 I can not get past the Uncached xml during the loading process. Luckily it did leave a MiniDump file.

JosEPh