Single Player bugs and crashes v36 plus (SVN) - After the 24th of October 2015

Status
Not open for further replies.
Get this error message then it CTDed after new SVN commit by TB . .

Also for DH

[737808.625] info type 'BONUS_GEOGLYPH_PLANS' not found, Current XML file is: modules\Platyping\Platyping_CIV4BuildingInfos.xml
[737891.859] info type 'BONUS_GEOGLYPH_PLANS' not found, Current XML file is: modules\Custom_Religions\Andean\Andean_CIV4BuildInfos.xml
Ok, I noticed Joe's comment on my option thread and had to check out what was posted here immediately.

That's exceedingly odd. I did some experimental stuff with load and save stuff on units but the tag it's having trouble keeping up with did not. I'll have to research this a bit further.

The GEOGLYPH plans are DH's. I did update before committing but I suppose I didn't load test between those steps or I would've spotted the problem. AKA - that wasn't me. But the load issue is and is very strange.

EDIT: Ok, so this tag is saved and loaded the same as another tag in the stream that doesn't cause problems. However, there MAY be an inability in this case to pass a function call to get a number within a variable here on these tags and I'm recompiling a new dll that should repair this. There may even be a bug in save and load I wasn't aware of due to this. Once I get it compiled, try to load the same game and let me know if there's a problem.

EDIT2: You know what's really odd though? I tested and loaded some older games before replacing the dll with the new 'fix' adjustments and didn't have any trouble. But since I'm still a bit suspicious of a potential bug in that tag's loading I'm putting the new dll in anyhow - it too loads games from before and after without issue.

But ... I would NOT advise changing to the new option mid-game. This will probably destabilize any game tremendously.
 
You've got a problem on your end then SO. I'll get your save and see what's taking place later when I can. But old saves load fine on this side.
 
You've got a problem on your end then SO. I'll get your save and see what's taking place later when I can. But old saves load fine on this side.

I didnt change a single thing, it was straight out of the NEW SVN.

EDIT: Infact i just made a BRAND new copy of the SVN and this error still pops up and CTD then . .

happens on SOME of my savedgames but NOT all of them, some of them work????, but i just started a NEW game and no error, so its got to be something in the "Compatibility" stuff . .
 
Also for DH

[737808.625] info type 'BONUS_GEOGLYPH_PLANS' not found, Current XML file is: modules\Platyping\Platyping_CIV4BuildingInfos.xml
[737891.859] info type 'BONUS_GEOGLYPH_PLANS' not found, Current XML file is: modules\Custom_Religions\Andean\Andean_CIV4BuildInfos.xml

The BONUS_GEOGLYPH_PLANS are defined on the SVN in the manufactured bonus file. They have been there for awhile now. Added in 8830.

edit

Save format incompatible

I am getting the same error as SO on a game I started on Saturday. no coffee means I forgot to sync with the SVN. Doing it now:blush: No it is still a problem :(

edit 2 Worse yet I get the error on a game I just started and saved then loaded:(
 
I didnt change a single thing, it was straight out of the NEW SVN.

EDIT: Infact i just made a BRAND new copy of the SVN and this error still pops up and CTD then . .

happens on SOME of my savedgames but NOT all of them, some of them work????, but i just started a NEW game and no error, so its got to be something in the "Compatibility" stuff . .

Same issue here as strategyonly.

The BONUS_GEOGLYPH_PLANS are defined on the SVN in the manufactured bonus file. They have been there for awhile now. Added in 8830.

edit

Save format incompatible

I am getting the same error as SO on a game I started on Saturday. no coffee means I forgot to sync with the SVN. Doing it now:blush: No it is still a problem :(

edit 2 Worse yet I get the error on a game I just started and saved then loaded:(

Ok. That explains why it tests fine on my end... just so happens I don't have a problem with the saves I've tested.

I have a theory here... I'll tinker with it. Looks like we may need to hardcode define the Invisible Types in the dll.

(And yeah, that save does show me the problem. Thanks SO. Theoretically, its very odd to be able to load one old save and not another so this is certainly something I've not seen before but I THINK I have a fix compiling right now. We'll see if it does the trick. Should be no reason it wouldn't - but it might make new games saved on this format screwed up.)

EDIT: Ok, so theory 1 was wrong. Working on a theory 2.

@SO: is that save a save from before the update entirely? Or is it a save from a game loaded with the updated version then resaved?NVM

EDIT2: I'm pleased to report I've figured out how to ensure save compatibility for both older games and games saved with the last few dll updates as well. However, I HAVE determined that if we add any new Domains there's probably going to be some issues that will need to be resolved in a similar fashion to the way this was resolved (note to self!)

Fix Committed.
 
Hi, back from a lot of work and a short holiday, what have you done? Cant butcher animals anymore???? Bug or change?
 
I have a theory here... I'll tinker with it. Looks like we may need to hardcode define the Invisible Types in the dll.

Hardcoding the Invisible Types in the dll should not be needed since most other things like buildings aren't. If Invisible Types are harcoded in the dll changes to the xml like adding or reordering or removing Invisible Types must also be done exactly the same in the dll.
 
Hardcoding the Invisible Types in the dll should not be needed since most other things like buildings aren't. If Invisible Types are harcoded in the dll changes to the xml like adding or reordering or removing Invisible Types must also be done exactly the same in the dll.

Yeah... I'll have to revert that portion since it didn't prove to be a solution anyhow. I thought perhaps the wrapper read method I was using needed a fixed number defined to work properly but I was wrong... instead, there's backwards compat stuff that Koshling's examples were able to guide me through setting up that needed to be done. It will take a little work now to reverse the hardcoding but I agree it should be done for the very reason you mentioned.

I'll take care of it before the next commit. The only reason I left the partial move to that in place was because it didn't need to be reversed right away and I was in a hurry to get a save compatible dll onto the SVN for everyone.
 
@Sparth a number of plot improvements are using the tech tree icons instead of their own. Tar Gatherer is one. You can get a proper list by looking in the CIV4ArtDefines_Improvement.XML file and searching for "/techtree/" ;)

Sorry, I see that you have done these. I had not synced my game version with the SVN:blush:
 
Status
Not open for further replies.
Back
Top Bottom