Single Player bugs and crashes v40 plus (SVN) - After Oct 2019

Both those warlord text xml files should exist in your warlord expansion folder.
The files referenced in those error messages are not necessarily where the xml error is though, but you should make sure that you have those files and that they are not modified in any way.
That is weird considering I never play that expansion. I will do a verify files through steam.
 
Malinese Completed Research and Founded Shinto in 1183 BC I started researching Shinto in 1053BC. Several turns after they had founded it. Yet other religions that have been founded are not researchable.
Does Shinto have a bug? A missing modifier?
See screenshot.
Civ4ScreenShot0013.JPG
 
The shinto tech has the correct bGlobal=1 modifier in its xml, meaning only 1 player may invent it, so one would have to suspect that no player have researched it yet even though an AI has founded its religion.
Are you playing with divine prophets or any other special religion options?
Are you 100% sure you started inventing it after it was founded?
 
The shinto tech has the correct bGlobal=1 modifier in its xml, meaning only 1 player may invent it, so one would have to suspect that no player have researched it yet even though an AI has founded its religion.
Are you playing with divine prophets or any other special religion options?
Are you 100% sure you started inventing it after it was founded?
Choose religions allows any religion to be selected when a religion may be selected, regardless of researching it. That's what the option is about.

EDIT: Reading deeper into the report, that's just confusing. Not sure how that could have happened. It doesn't look like choose religions is in use and I doubt Divine Prophets are since I'm pretty sure if its an option I made, Joe doesn't play with it. That said, without Choose Religion, I'm not sure how this would happen.
 
WRAPPER_WRITE_ARRAY(wrapper, "CvPlayer", NUM_PLAYEROPTION_TYPES, m_abOptions);

Player Option types are not save game compatible yet. Removing one will mess with saves.
 
WRAPPER_WRITE_ARRAY(wrapper, "CvPlayer", NUM_PLAYEROPTION_TYPES, m_abOptions);

Player Option types are not save game compatible yet. Removing one will mess with saves.
I was suspecting something like that. Have we messed up the save sequence?
 
The shinto tech has the correct bGlobal=1 modifier in its xml, meaning only 1 player may invent it, so one would have to suspect that no player have researched it yet even though an AI has founded its religion.
Are you playing with divine prophets or any other special religion options?
Are you 100% sure you started inventing it after it was founded?

No DP. No Choose either.
Only the Multiple Religion Spread found in BUG Options used for Religions.

It was queued up in my Tech tree string before the Malinese founded it. Once I started to research it I double checked the Religion Tab and saw that the Malinese had founded it before my Research queued path had gotten to Shinto. I always que up a string of Techs to research. Sometimes long strings sometimes shorter. But almost always more than 5.

It doesn't look like choose religions is in use and I doubt Divine Prophets are since I'm pretty sure if its an option I made, Joe doesn't play with it.

The Only Religion Option I use is Multiple Religion Spread. Has Nothing to do with who made any of the Religion Options at all. It's How I prefer to play with the Religions. I feel all other Religion Options allow you to cheat in the race to found a religion.

Save attached raxxo2222.
 

Attachments

You can't select Shinto religion in tech tree window, but most likely someone managed to research it while you were researching it.
Spoiler :

Civ4BeyondSword 2020-01-18 19-19-54-92.png


I set handicap to Settler to speed up techs for tech advisor, it didn't show religions too.
 
It was queued up in my Tech tree string before the Malinese founded it. Once I started to research it I double checked the Religion Tab and saw that the Malinese had founded it before my Research queued path had gotten to Shinto. I always que up a string of Techs to research. Sometimes long strings sometimes shorter. But almost always more than 5.
Ok, that means the tech queue with a global tech isn't invalidated if the global tech is invented by someone else after the queue was made. We should then look into the setResearch function that is called for the queue after a tech is researched, it needs a canEverResearch check there that can skip the tech if its invalid and then set the next queued tech as current research instead, removing the invalid tech from the queue when it comes up.

P.S. I don't know the setResearch function name, so I used a name that makes sense but might have a different name in our code.
 
Last edited:
Another possibility is that this tech was somewhere in middle of research queue.
For example you had it selected for research before someone got it.
We could do Nightmare test game - someone should select religious techs among other techs and let AI get them first.

Religious tech should be kicked out of queue if someone researches it in mean time.
EDIT: Its not this case - those techs were kicked out of queue.

So only thing that can happens is you researching religious tech and then AI manages to research it before you.
Spoiler :

Civ4BeyondSword 2020-01-18 19-50-50-03.png
Civ4BeyondSword 2020-01-18 19-50-27-07.png



EDIT: Went couple autosaves earlier and gave myself Animism.
I can still research Shamanism after someone got it first.
Spoiler :

Civ4BeyondSword 2020-01-18 19-58-51-00.png


I had Druidic Traditions selected as second tech in queue, I still can research it after someone else got it.
So this removal from queue was graphical only.

Here is save, just click away turns.
 

Attachments

Last edited:
@Thunderbrd can you check why global techs aren't removed from queue (doesn't matter if they are actually researched) when someone else researches them.

I prepared perfect save for this test.
 
Feel free to test the possible fix found in the religFoundTechTweaks branch.
I committed fix related to global techs to master (code that you had copied in comment).

@JosEPh_II this bug is now fixed (on Github):
Religious techs weren't cleared from research queue, if someone else got them first.
 
Thank you raxxo and Toffer. :D
Now this fix is in SVN, also commerce icons were messed up too for two weeks - bag of gold wasn't displayed for commerce tile output between 5 and 9.
You need to check if you have selected religious techs after update - they will be researched, if you don't reselect techs.
Unselected religious techs will be treated normally.

By the way how balancing of civics is going?
 
Last edited:
The Nanite Defuser "wonder" deletes all nukes belonging to all players. That is total BS:mad:! Since there is no reference to that effect in its xml, I had to delete it completely.

Where do these ridiculous ideas come from, and why don't they get vetoed or reverted?
 
Back
Top Bottom