v27 and above - Single Player Bug/Crashes report thread

Thunderbrd · Jan 21, 2013

strategyonly said:
I betcha this is the reason WHY the turn times have become sooo long now again??? They used to be 20-30 seconds, now they are over 1 minute, closer to 1 1/2 minutes long, and this is in Classical Era

You said just now in the other thread that units that should be able to get the blitz ability on promos weren't being able to.

ls612: I'm wondering now what you did to remove the filter... I checked where the filter is setup in isPromotionValid (there's two of them: one in CvUnit and one in CvGameCoreUtils.cpp, and its not disabled or commented out at all where it was put after my change which was in CvUnit. I'll take a closer look at both and see if I can spot something amiss in the meantime.

I'm wondering if this is somehow leading to a situation where units are evaluating that they want the promotion but they can't have the promotion so when they go to select it and its not there... uh oh... gotta reevaluate and will keep doing so until they can finally by luck evaluate something else as more valuable - in some cases not being able to because the random doesn't provide enough variation to and we have an infinite loop rather than just a delay.

But there's still something off here - some missing piece of the puzzle.

EDIT: Ah... according to your notes you'd already found the other one in CvGameCoreUtils.cpp that I'd already disabled. You must not have updated my changes before going in there and commenting that out or you would've seen it already was. I had put a new, more appropriate filter, as mentioned in the thread on this, in the CvUnit function. I believe now that commenting that out may be our solution but I'm not 100% positive on this. We'll see if it works. Easier to check when you know your situation is causing CTDs rather than just long delays/infinite loops unless you have a save that always hits that loop.

strategyonly · Jan 21, 2013

Thunderbrd said:
You said just now in the other thread that units that should be able to get the blitz ability on promos weren't being able to.

Wasn't me. :blush:

CURRENT SVN submitted by Koshling, SVN is not working correctly now, i get all kinds of debug error listing, ???

See attached and MORE when the game started. . . ??????

sp00n · Jan 21, 2013

In the meantime I was able to fix the 3rd occurrence of the freeze (after a lot of trial and error).
In the Goth city of Cherokee, the most southern of their cities, is a Stealth Fighter with an XP of 5 and a level of 2.
If I reduce the XP back to 4, the infinite AI Promotion loop never happens and the game finishes the round just fine (until it reaches 5xp again?).

I've attached the save game before the fix.

@Dancing Hoskuld
Going to try your modification now.
// Result:
Well, it fixes the python error entry, the log is empty now. But the loop still happens.

// Edit
I would also like to point out again that this happens in both v27 and in revision 4622, so it's nothing that was introduced recently.

Thunderbrd · Jan 21, 2013

strategyonly said:
Wasn't me.

CURRENT SVN submitted by Koshling, SVN is not working correctly now, i get all kinds of debug error listing, ???

See attached and MORE when the game started. . . ??????

I haven't seen or have any knowledge of any but #4 there. On that one, I just haven't removed the fAssert that shouldn't be there as we should be allowing specialist yields to go negative via civic or trait modifiers. Otherwise, its not a meaningful bug so far as I can tell. The others? Most may have something to do with the game itself using the modmods that aren't on the stock SVN version. Either they aren't in place and should be as you noted earlier, or they are and there are errors in them.

There's also the possibility that something that JUST changed within the last 12 hrs or so would be a culprit.

spOOn: that save should be very useful! Thanks!

ls612 · Jan 21, 2013

strategyonly said:
Wasn't me.

CURRENT SVN submitted by Koshling, SVN is not working correctly now, i get all kinds of debug error listing, ???

See attached and MORE when the game started. . . ??????

Who committed a Debug DLL to the SVN? :mischief:

That would be the source of those popups anyways.

Thunderbrd · Jan 21, 2013

This is what I'm getting when I run spOOn's save. I've never seen this before so I'm a bit confused by it.

Things seemed to be processing along nicely and then this pops up and the debugger gives me nothing further to go on at all.

This is after attempting the fix in the promo AI evaluation codes.
The Output has gone on and on with player 8 though. This is up to the point that it stops:

Spoiler :

So again I'm suspecting its something going on in the tech evaluations. I suppose this could simply be a matter of running out of memory? I don't know what I'm facing here at all.

Ok, so I'm looking at that report in review and it occurs to me that its not having an issue on the promotion evaluation but rather, it appears to be having trouble in finding the next tech to evaluate. I'm gonna look down that road a bit and see if I can find what may have caused an issue with that.

As a side note, I'm also getting this assert while loading under the debugger(and this is after the changes from the ones I posted a few days ago but I'm not using the MOST recent update either so that's not messing with this):

Sgtslick · Jan 21, 2013

ls612 said:
Post a BBAI log for that and we can potentially figure out what the AI is doing wrong (although probably not before release of V28).

OK here is the bbai log its pretty big since its on the GEM map. Xiongnu was the the team that had 30 odd missionaries just sitting around and great people undefended btw.

strategyonly · Jan 21, 2013

How old is that game from sp00n, because i went through Ori's modules and no olive anything there??

Thunderbrd · Jan 21, 2013

strategyonly said:
How old is that game from sp00n, because i went through Ori's modules and no olive anything there??

hmm... doesn't come from the savegame but rather from the file base when the mod is loading.

strategyonly · Jan 21, 2013

Thunderbrd said:
hmm... doesn't come from the savegame but rather from the file base when the mod is loading.

Hmm its actually in the TraitsInfo file.

Thunderbrd · Jan 21, 2013

I would've suspected as much but its strange that its relating to an event somehow isn't it?

strategyonly · Jan 21, 2013

Thunderbrd said:
I would've suspected as much but its strange that its relating to an event somehow isn't it?

I think i know what happened, it was going through TraitsInfo and found the error and it moved on to the next file and then listed that, thats about all i can think of, even if it isn't true :crazyeye:

sp00n · Jan 21, 2013

strategyonly said:
How old is that game from sp00n, because i went through Ori's modules and no olive anything there??

As I've said, the savegame itself is from v27, but the same freezes happen on r4622.

Thunderbrd · Jan 21, 2013

I have successfully sorted out sp00n's bug. Apparently units were qualified to take some promotions they weren't afterwards qualified to keep. This was due to the fact that the canKeep check was running a check on isPromotionValid and finding it false because it was expecting it was looking at the promo as if it were attempting to add it and the totals on interception values, if added again, would push past the barrier. The fix for this was to make sure that those sorts of calculatory checks would not take place if only checking to see if the promo could be retained.

Took a bit to sort it out but I got it!

Now, before I update the fix to the SVN, which could also be a repair to some of the delays (after a number of cycles these units could've chosen a different promotion unless they had no further valuable options), I want to make sure its safe to do so. I'd have to do a merge with Koshling's most recent change and apparently there's some problems there. So I can take a look at those.

There's also a known bug over on my end that I've been attempting to sort out... a number of python event errors if a game is begun without Developing Leaderheads but oddly fine if it's set to that option... ??? I might need some help to sort that out anyhow and the truth is its probably best fixed on the python end anyhow. Probably has something to do with the way leaders have or don't have traits and that's throwing off something in the python coding on those events.

Anyhow, that part's just for fair warning. It's a lot less critical an error than the one just repaired. I've also got a number of other updates here to push along with it too.

ls612 · Jan 21, 2013

I'd have to do a merge with Koshling's most recent change and apparently there's some problems there. So I can take a look at those.

The only problem is that Koshling committed a Debug DLL instead of what normally gets committed (Final_Release).

Thunderbrd · Jan 21, 2013

That and the fact that I'm seeing a LOT of new asserts up there in SO's report than I've seen on any of my debugger runs. I kinda thought there might've been another issue or two in there. But I suppose it won't hurt to merge and push and then we can sort it out from there huh?

ls612 · Jan 21, 2013

Thunderbrd said:
That and the fact that I'm seeing a LOT of new asserts up there in SO's report than I've seen on any of my debugger runs. I kinda thought there might've been another issue or two in there. But I suppose it won't hurt to merge and push and then we can sort it out from there huh?

It looks like that's because SO has some non-standard modules enabled. At any rate, none of those assertions look like anything to worry about.

strategyonly · Jan 22, 2013

CTD after next turn when clicking on defect and lead rebel armies.
SVN: 4631, NO viewports, but enabled ALL of DH's modules in his MLF areas.

attached autosavedgame and Minidump

Thunderbrd · Jan 22, 2013

I really must wonder why it seems that lately Rev is causing us so many new problems when I don't think we ever really messed with it much to get it to start! oyvay!

At least that crash can be diagnosed with the debugger. Thanks for the report SO!

bill2505 · Jan 22, 2013

strategyonly said:
CTD after next turn when clicking on defeat and lead rebel armies.
SVN: 4631, NO viewports, but enabled ALL of DH's modules in his MLF areas.

attached autosavedgame and Minidump

if i understand shouldnt be defect instead of defeat

v27 and above - Single Player Bug/Crashes report thread

C2C War Dog

C2C Supreme Commander

Prince

Attachments

C2C War Dog

Deity

C2C War Dog

Emperor

Attachments

C2C Supreme Commander

C2C War Dog

C2C Supreme Commander

C2C War Dog

C2C Supreme Commander

Prince

C2C War Dog

Deity

C2C War Dog

Deity

C2C Supreme Commander

C2C War Dog

King

Similar threads