Leugi's Israel for VP

[Zuizgond]

I'm currently playing Israel for the first time and really like it so far. Not sure if it's intended but I am allowed to build Kibbutz on hills on river tiles

Spoiler :

 

[pineappledan]

Not intended, but I have no idea how to disable it.

 

[notaspambot]

The reason looks to come from Improvement_ValidImprovements/GetImprovementMakesValid() essentially being treated as an OR condition to the freshwater requirement in CvPlot.cpp (lines 2196~2254), meaning so that it'll return true as long as it's both freshwater and has any improvement on it, not just a farm.

Not at all versed in the DLL or how the checks are intended to be used so take my words with a grain of salt, but looks like the easiest way to make it check specifically for farms seems to be to merge the IsRequiresImprovement() and GetImprovementMakesValid() checks and make the latter return false, like something below. It wouldn't break anything in vanilla or base VP at least (the only other usage is for landmarks, which are also paired with the archeological dig improvement).

	if(pkImprovementInfo->IsRequiresImprovement())
	{
		if (getImprovementType() == NO_IMPROVEMENT)
		{
			return false;
		}
		else if (!pkImprovementInfo->GetImprovementMakesValid(getImprovementType())
		{
			return false;
		}
	}

 

[pineappledan]

The reason looks to come from Improvement_ValidImprovements/GetImprovementMakesValid() essentially being treated as an OR condition to the freshwater requirement in CvPlot.cpp (lines 2196~2254), meaning so that it'll return true as long as it's both freshwater and has any improvement on it, not just a farm.

Not at all versed in the DLL or how the checks are intended to be used so take my words with a grain of salt, but looks like the easiest way to make it check specifically for farms seems to be to merge the IsRequiresImprovement() and GetImprovementMakesValid() checks and make the latter return false, like something below. It wouldn't break anything in vanilla or base VP at least (the only other usage is for landmarks, which are also paired with the archeological dig improvement).

    if(pkImprovementInfo->IsRequiresImprovement())
    {
        if (getImprovementType() == NO_IMPROVEMENT)
        {
            return false;
        }
        else if (!pkImprovementInfo->GetImprovementMakesValid(getImprovementType())
        {
            return false;
        }
    }

@Rekk

 

[HeroOfTheSword]

Hi, I can't get this mod to work anymore. I get that "This mod is missing required dependancies" error. Could you post a patched or updated version maybe? I know someone else mentioned changing some of the code but I'm not experienced enough to do that myself. Is this the link https://forums.civfanatics.com/resources/leugis-israel-for-vp.26836/updates?

Update: that version doesn't work either so I'm at a complete loss. Also I've the newest version of vox too.

 

[Bruhmoment]

Hi, I can't get this mod to work anymore. I get that "This mod is missing required dependancies" error. Could you post a patched or updated version maybe? I know someone else mentioned changing some of the code but I'm not experienced enough to do that myself. Is this the link https://forums.civfanatics.com/resources/leugis-israel-for-vp.26836/updates?

Update: that version doesn't work either so I'm at a complete loss. Also I've the newest version of vox too.

Same problem - the mod doesn't work for me. Needs to be updated

 

[Willy_the_Kid]

It really is very easy to do. I'm an absolute nOOb when it comes to this and even I managed to do it.

Check this topic on how to do it: https://forums.civfanatics.com/threads/mod-dependency-issues-with-vp-2-0.676112/

 

[Bruhmoment]

It really is very easy to do. I'm an absolute nOOb when it comes to this and even I managed to do it.

Check this topic on how to do it: https://forums.civfanatics.com/threads/mod-dependency-issues-with-vp-2-0.676112/

Right. But since you said you did it, technically, this means that you can upload the file for usage ?

 

[HeroOfTheSword]

It really is very easy to do. I'm an absolute nOOb when it comes to this and even I managed to do it.

Check this topic on how to do it: https://forums.civfanatics.com/threads/mod-dependency-issues-with-vp-2-0.676112/

Thanks for the link but I couldn't make head nor tail or what was written there I feel like I'm reading a foreign language! I think you might be underestimating your own abilities or overestimating mine lol. I'm just a game player, not a coder.

 

[Bruhmoment]

Thanks for the link but I couldn't make head nor tail or what was written there I feel like I'm reading a foreign language! I think you might be underestimating your own abilities or overestimating mine lol. I'm just a game player, not a coder.

Technically, it looks fairly simple to me, so I could do it and upload the file for you to use, but I'm doubtful that I would succeed. I might try though, if I have the time

 

[Skaz881]

For the dependency, all you have to do is delete the More Luxuries dependency to make it work.

 

[Skaz881]

I'm getting a database error though that's making everything TXT KEY out:
[140309.437] While executing - 'insert into Language_en_US('Tag', 'Text') values (?, ?);'
[140309.437] In XMLSerializer while inserting row into table insert into Language_en_US('Tag', 'Text') with values (TXT_KEY_IMPROVEMENT_KIBBUTZ, Kibbutz, ).
[140309.437] In XMLSerializer while updating table Language_en_US from file XML/Text/GameTextIsrael.xml.
[140309.437] columns Language, Tag are not unique

Edit: I found the problem. The Kibbutz text is in both the game text for Israel and the game text for the 3/4 unique components mod.

 

[HeroOfTheSword]

For the dependency, all you have to do is delete the More Luxuries dependency to make it work.

Cool, but where exactly is that in the folder, like is it in the Israel folder or the vox folder?

 

[HeroOfTheSword]

Technically, it looks fairly simple to me, so I could do it and upload the file for you to use, but I'm doubtful that I would succeed. I might try though, if I have the time

Apologies for the delay, life! Thanks for the offer to help, but there's no need to go out of your way, I'll try to sort it myself or just wait for an update.

 

[Hokiefan00]

Cool, but where exactly is that in the folder, like is it in the Israel folder or the vox folder?

Its the (7c) Leugi's Israel for VP.modinfo file in the (7c) Leugi's Israel for VP folder, which should be in the Mods folders where VP is installed.

 

[HeroOfTheSword]

Its the (7c) Leugi's Israel for VP.modinfo file in the (7c) Leugi's Israel for VP folder, which should be in the Mods folders where VP is installed.

Ah I see why I missed this now, these modinfo files aren't something I've ever opened before because I haven't a program to access them! What program do you use to open it?

Update: Figured it out how to open it!

Located what I think must be the More Luxuries dependency:

<Mod id="be2d13ee-d18d-410e-8f04-7cd19cd99a98" minversion="0" maxversion="999" title="(5) More Luxuries - CBO Edition" />

Is this it?

 

[Bruhmoment]

I think it is, I removed the problematic file a long time ago, but that should be it. If all else fails, you can try my version:

(7c) Leugi's Israel for VP.modinfo

drive.google.com

Just download the file and replace it

 

[HeroOfTheSword]

I think it is, I removed the problematic file a long time ago, but that should be it. If all else fails, you can try my version:

(7c) Leugi's Israel for VP.modinfo

drive.google.com

Just download the file and replace it

Thanks! Yeah comparing the two files that seems to be the main difference. Although in your file theres also this line which isn't in mine.

<File md5="7815696ecbf1c96e6894b779456d330e" import="1">DavidDOM.mp3</File>

Seems like a media file so probably won't break the mod without it. I might test both to see what the difference is.

 

[Bruhmoment]

Thanks! Yeah comparing the two files that seems to be the main difference. Although in your file theres also this line which isn't in mine.

<File md5="7815696ecbf1c96e6894b779456d330e" import="1">DavidDOM.mp3</File>

Seems like a media file so probably won't break the mod without it. I might test both to see what the difference is.

I checked the media file and DavidDOM.mp3 is just the narrator reading out the text at the Israelian civilization start-up screen. Perhaps if it's removed, there will be no one narrating the text? Test it out

 

[EdwardLiv]

The text is broken when also playing with 4UC mod.