It is actually very closely linked. All those modifiers built into the struct there are called upon for the display stuff.
If you reverted the changes to exactly what it was before I started messing with anything then that does have nothing to do with it and that's what I needed to isolate. I don't think this is purely a display issue as the calculation looked correct and the final odds value will reflect the independant calculation done in the code rather than a calculation taking place in the text manager. So if the display is all that's wrong then the display won't match the given odds at all.
I admit there's some noted errors in where and how some modifiers are displaying there that I've been trying to figure out but my real concern here is that according to that screen shot he's right. The attacker's CC modifier is actually working against himself. I wonder if this is always taking place or if its conditional in some way.
If its always taking place then there's something wrong in the section I'd tweaked and possibly something was reversed there. But since you say you just reverted that change... Is it possible this has been calculating this way for a very long time here and this is only the first time we're noticing it???
The other option is that its taking place conditionally and that would be just... odd. But at least it could probably be discovered if a proper save was delivered showing this kind of evaluation. I might be able to get some playtesting here to reveal the issue if its more easily replicable.