JosEPh_II
TBS WarLord
Yes I have seen this before and may have posted a screenie showing what you are seeing.
Single Player bugs and crashes v37 plus (SVN) - After the 24th of December 2016
- Thread starter Dancing Hoskuld
- Start date
Yes I have seen this before and may have posted a screenie showing what you are seeing.
Thunderbrd
C2C War Dog
Can you provide a save with instructions on replicating the help hover? I've not seen that before.
Thunderbrd
C2C War Dog
Indeed. While the video was helpful in guiding me to replicate the steps you took, my system processed the turn all the way through to the next turn without error.
Probably a wrong variable type used somewhere, so floating point becomes interger. Just a wild guess.
Last edited:
Noriad2
Emperor
- Joined
- Oct 23, 2014
- Messages
- 1,153
Hi TB, Thanks for looking. I made a fresh download of the latest SVN, deleted my cache and profile, and using the same savegame and same actions, the game still crashed reliably (I checked it multiple times).
So I did some additional investigation, and found out that if I check the option "quick combat (defense)" the crash does NOT occur, but if I leave that option unchecked, the crash WOULD occur.
When I have quick combat (defense) checked, at the moment the crash should occur but doesn't, I get the message that my tracker killed a predatory cave lion while defending. So I speculate that the crash I reported is a graphics bug related to specific combat animations between an attacking predatory cave lion and a defending tracker (predatory cave lion attacking from the north).
Last edited:
I've almost never seen it being right, unless I try to remember as far back as 1-2 years ago. It is wrong in 95% of all combat odds encountered in the entire game.
Not sure how you got that number, the total defense modifier should have been -35%.
The defenders unmodified strength was 3
, after the total defense modifier was applied it became 2.85. Another thing that is odd is that -35% should have resulted in 1.95I can honestly say that combat odds have begun to confuse me greatly after TB started on the combat mods,
The -10% attack
for the attacker nullifies the +10% strength the attacker has due to the group volume difference, then we are only left with the attackers +35% vs. animals.The 50% repel vs animals is not a defense modifier, in the same way that 1-2 first strikes are not considered a defense modifier. The total defense modifier should only show the % that the
of the defender is changed.
Last edited:
The attacker has these stats:
+10%
-10% when attacking ▬ Imo this should affect the attackers not the defender as it currently does.
+35% vs. animals
+5% vs. Each group volume larger ▬ The bison was two group volume sizes larger than the wanderer, hence a 10% total.
There are many other stats in play, but they shouldn't affect the total defense modifier.
Attacker:
-35% damage
+40% dodge
+5% precision
withdrawal stuff
repel stuff
etc
+10%
-10%
when attacking ▬ Imo this should affect the attackers not the defender as it currently does.+35%
vs. animals+5%
vs. Each group volume larger ▬ The bison was two group volume sizes larger than the wanderer, hence a 10% total.There are many other stats in play, but they shouldn't affect the total defense modifier.
Attacker:
-35% damage
+40% dodge
+5% precision
withdrawal stuff
repel stuff
etc
Last edited:
Neither do I.
A combination of jotting down the wrong numbers and not reading my own writing. When I did it again I got -38%. But that was using all modifiers.
Thunderbrd
C2C War Dog
Ah... I suspected this was the issue. This is a common and known problem and so far no solution has been found so basically C2C is strongly suggested to be played on the quick combat options (and that's a first check to make to see if you can get past any crash.)
Well the odds of survival is what counts anyhow. You're just referring to the total combat modifier. It is strange that's at all off and it does warrant looking at the code. The problem with the combat help hover is that it's one of the longest functions in the code... very confusing at this point. Very easy to get lost in. Where EXACTLY that number is coming from or what it is referring to I'm not sure yet.
This is tough because the underlying engine totals all modifiers up only on the defender. It stores a number of them and reports them to the exe and you cannot add to that list of stored variables. MOST of the combat help data derives itself from these side storage variables and everything non-vanilla is compiled otherwise and it's very difficult keeping them all organized correctly.-10%
I'm not yet sure if the final is just a display problem or deeper but I'm almost 100% confident it would just be a display issue because a negative number like that would likely crash the system otherwise.
strategyonly
C2C Supreme Commander
Thunderbrd
C2C War Dog
It actually is still something I'm trying to figure out. (the crash that is)
As for increasing the spawn frequency of neanders, it can be done in the spawn xml by lowering the base values they are given or in a global for the neanderthal spawn rate or by selecting raging barbs.
Noriad2
Emperor
- Joined
- Oct 23, 2014
- Messages
- 1,153
Is it possible to turn off combat animations for specific units? I don't see cave lions all that often. If cave lions are indeed problematic, turning off its combat animation would be a small sacrifice.
Hmm, this promotion tag always count for the attacker </iCombatPercent>, but I guess that happens entirely in the exe too...
Thunderbrd
C2C War Dog
It's not just cave lions. It's randomly just about anything.
I'd have to show you in code what I mean. It's not that the EXE is causing problems except to make it so that it's hard to follow suit with the original way in which modifiers were added. It doesn't keep us from adding more, just from using the same data transfer channels, which can confuse and frustrate the situation when modding it. Very hard to explain (and hard to work with!)
JosEPh_II
TBS WarLord
Basically have Neanderthal cities On and have Peace Among NPCs On. This way the Barbs and Neanders don't fight each other or the Predators or Beastly animals either. They will all come looking for you.
strategyonly
C2C Supreme Commander
Thunderbrd
C2C War Dog
Took a bit deeper analysis than usual to figure out how to resolve this properly but done and done. We're back to having a crash free mod aside from the graphics thing and anything that has yet to be reported.
Thunderbrd
C2C War Dog
This... just happens sometimes. There's already some efforts in the code to repair it when it takes place. But it's kinda funny because it causes the unit to run across the map from who knows where to the spot where they are supposed to be. AKA, wait and they tend to end up showing up.
Thunderbrd
C2C War Dog
Ok, I figured out why I've never seen this. This is a line coming from an odds panel BUG option. I've never had it on so I've never seen it and didn't even know it was there.
There is obviously some mathematicaly reviewing that needs to be done for some of the combat help hover stuff but this is truly confusing. This is the code for that display:
Code:
if (iView & getBugOptionINT("ACO__ShowTotalDefenseModifier", 2, "ACO_SHOW_TOTAL_DEFENSE_MODIFIER"))
{
//szString.append(L' ');//XXX
if (pDefender->maxCombatStr(pPlot,pAttacker)>pDefender->baseCombatStr()*100) // modifier is positive
{
szTempBuffer.Format(SETCOLR L"%d%%" ENDCOLR,
TEXT_COLOR("COLOR_NEGATIVE_TEXT"),(((pDefender->maxCombatStr(pPlot,pAttacker)))/pDefender->baseCombatStr())-100);
}
else // modifier is negative
{
szTempBuffer.Format(SETCOLR L"%d%%" ENDCOLR,
TEXT_COLOR("COLOR_POSITIVE_TEXT"),(100-((pDefender->baseCombatStr()*10000)/(pDefender->maxCombatStr(pPlot,pAttacker)))));
}
szString.append(gDLL->getText("TXT_ACO_TotalDefenseModifier"));
szString.append(szTempBuffer.GetCString());
}Similar threads
- Sticky
- Sticky
