Single Player bugs and crashes v39 plus (SVN) - After the 20th of July 2019

[JosEPh_II]

Now I know where I made the error: (basketweaver has 1 of 5 bonus requirements copied)
std::find(it1, it2, val) should end at it2 when nothing found, so my algorithm is wrong

int iSizeOrig = (int)target.size();
        target.reserve(iSizeOrig + (int)source.size());
        while (source.size())
        {
            T& Val = source.back();
            if (find(target.begin(), target.begin()+iSizeOrig, Val) == target.end()) // should be == target.begin()+iSizeOrig
            {
                target.push_back(Val);
            }
            source.pop_back();
        }

Good Luck!

 

[strategyonly]

after the last few updates, now there r NO buildings in the queue any longer????

i have the latest SVN update . .

 

[JosEPh_II]

after the last few updates, now there r NO buildings in the queue any longer????

i have the latest SVN update . .

Anq is working on it. SVN 10793 is last usable SVN version atm.

 

[raxo2222]

after the last few updates, now there r NO buildings in the queue any longer????

i have the latest SVN update . .

@Anq needs to fix this mistake too

 

[Toffer90]

@Anq needs to fix this mistake too

I'm looking into any python errors he may have made, I got a bit distracted when looking into one of the files he changed though, I started mass editing that python file where so much could be written better.

 

[Anq]

I need to revert 10797.

 

[olduser]

Now I know where I made the error: (basketweaver has 1 of 5 bonus requirements copied)
std::find(it1, it2, val) should end at it2 when nothing found, so my algorithm is wrong

int iSizeOrig = (int)target.size();
        target.reserve(iSizeOrig + (int)source.size());
        while (source.size())
        {
            T& Val = source.back();
            if (find(target.begin(), target.begin()+iSizeOrig, Val) == target.end()) // should be == target.begin()+iSizeOrig
            {
                target.push_back(Val);
            }
            source.pop_back();
        }

Why didn't you use target.end()?????

if (find(target.begin(), target.end(), Val) == target.end())

 

[Anq]

Why didn't you use target.end()?????

if (find(target.begin(), target.end(), Val) == target.end())

Because I am increasing its length in the process, so I think searching the original length would be a little more efficient

I'm going to revert last changes, I was too confident in myself to make those changes and mixed up things I am fixing with unsafe changes too often

 

[Anq]

Repeatable CTD at end turn, latest SVN 10795
Just end the turn. There are some ships that will not save their orders, but just ignore them.

Since @Anq has reported that he has introduced some crash-causing bugs that he can't fix yet, that might be the first place to look.

If you do find a save before yesterday (before updating to 10782 by alberts or 10781 by me), please play your game again from that progress, with the new update that I think may have reverted all breaking changes.

 

[JosEPh_II]

If you do find a save before yesterday (before updating to 10782 by alberts or 10781 by me), please play your game again from that progress, with the new update that I think may have reverted all breaking changes.

So you are saying that you need to play from a save game dated 7-27-2019 or earlier. Then update to SVN 10800 to see if it will progress. Is this correct?

Because updating from a save from this morning or yesterday the 28th does not make it past the Re-Calc it calls for.

 

[Anq]

So you are saying that you need to play from a save game dated 7-27-2019 or earlier. Then update to SVN 10800 to see if it will progress. Is this correct?

Because updating from a save from this morning or yesterday the 28th does not make it past the Re-Calc it calls for.

Yes. If you have ever played 10781~, chances are my code corrupts your save game, so you need to revert to a save before yesterday. Sorry I saw what the problem was too late, to even withhold my further modifications.

 

[JosEPh_II]

Okay I had already updated to 10802 and went back and found a save game from the 27th at 7:51 AM CDST USA. It would not work. CTD.

So Now I'm going to revert my working SVN version to 10780 or earlier. Load this 27th Save and play a turn. If it plays, then I will Update to working SVN to10802 and see if it will progress.

Lots of Hoop jumping today! But we will get it straightened out.

 

[JosEPh_II]

Okay reverted to SVN 10778 loaded save game from the 26th.Did Re-calc as game asked. Worked. Played turn and then saved .

Now I'm going to update SVN to latest and see if that new turn will Re-calc and play with latest SVN version.

 

[Yudishtira]

Okay reverted to SVN 10778 loaded save game from the 26th.Did Re-calc as game asked. Worked. Played turn and then saved .

Now I'm going to update SVN to latest and see if that new turn will Re-calc and play with latest SVN version.

I'm finding the same thing - no save progresses with 10800 (mine don't crash but they do hang). I think it's pretty clear that that revision is still broken.

Why 10778 rather than 10780, btw? Never mind, they are branch commits.

 

[JosEPh_II]

@Anq ,

SVN 10802/10803 Does Not work. CTD at Re-Calc every time. I have deleted 2 days worth of corrupted save games (27th and 28th of July save games). I can go back/revert to SVN 10778 and play my saves from the 26th of July.

 

[TaylorItaly]

I am playing with 10793.
No crashes,but an error with the Specialists.
Have a free citizen and i can not recruit him for example Spy-Specialist.
After closing City-Screen and open again , suddenly i had 15 Spy-Specialist.

Edit: Ah, i just see ,it is broken....

 

[KaTiON_PT]

Looks like a graphical glitch because your total espionage output doesn't change (upper-left corner).

 

[TaylorItaly]

yes,ok,good.
But ,i don`t know,is it cause the broken revision?

Edit: Nevermind , all is good now...

 

[JosEPh_II]

@Anq,
All is well. Thank you for SVN 10806. Important test game for me is saved.

 

[strategyonly]

newest SVN errors

Traceback (most recent call last):
File "BugEventManager", line 308, in _handleDefaultEvent
File "CvEventManager", line 2658, in onCityDoTurn
File "CvAdvisorUtils", line 322, in cityAdvise
UnboundLocalError: local variable 'iTurnFounded' referenced before assignment