Single Player bugs and crashes v39 plus (SVN) - After the 20th of July 2019

[billw2015]

Thanks, looks like I messed up one of the string formatters.

 

[JosEPh_II]

@raxo2222 ,

<BuildingHappinessChanges>
<BuildingHappinessChange>
<BuildingType>BUILDINGCLASS_CANNIBALISM</BuildingType>
- <iHappinessChange>-5</iHappinessChange>
+ <iHappinessChange>1</iHappinessChange>
</BuildingHappinessChange>
</BuildingHappinessChanges>

Why was this building changed from a -5 Happy to a +1 Happy?
And didn't this have a iHealthChange as well?

Or is this the result of Leaving Cannibalism?

 

[raxo2222]

@raxo2222 ,



Why was this building changed from a -5 Happy to a +1 Happy?
And didn't this have a iHealthChange as well?

Or is this the result of Leaving Cannibalism?

I was reverting Kation's changes, that reverted mine in this file - he didn't notice, that I merged module civic infos to core too.
@KaTiON_PT what changes here were meant to be here?

I'll replace it with copy from SVN to see what are differences.

Between SVN version and current github branch version there are only 3 differences in civic infos:
Line was adjusted a bit - no change to its content.
Tribal Warfare civic now is unlocked with Warfare instead of Tribalism.
Community Labor now is unlocked at Cooperation instead of Tribalism.

These things were here all time (where you noticed change of value), just being overridden with module stuff.
I then replaced it with stuff from modules, as I merged them to core.
Kation didn't update civic infos as I merged modules to core, so I updated it for him to match what is currently in SVN.

So basically only changes that were meant to be here is changing tech requirements of two civics compared to SVN.

 

[JosEPh_II]

Tribal Warfare civic now is unlocked with Warfare instead of Tribalism.

This one KaTiON and I had already discussed. And the Tech Warfare was placed after Tech Tribalism.

So basically only changes that were meant to be here is changing tech requirements of two civics compared to SVN.

So did you revert KatiON's changes? I'm not following very well what you did. Guess I need to go look into the Files to see.

 

[raxo2222]

So did you revert KatiON's changes? I'm not following very well what you did. Guess I need to go look into the Files to see.

He accidentally reverted my changes (I merged modules to core including their overrides of civic infos), when he put his prehistoric era revision as branch.
I fixed this stuff - he forgot to update civic infos, as I merged modules to core.

 

[billw2015]

there is minor graphical bug in GIT version, when you hover over floristry tech.

I had a very quick look over lunch, and I couldn't see anything that would cause this problem. Does it ONLY happen on that one tech?

 

[raxo2222]

I had a very quick look over lunch, and I couldn't see anything that would cause this problem. Does it ONLY happen on that one tech?

I'm not sure.

 

[Thunderbrd]

I was reverting Kation's changes, that reverted mine in this file - he didn't notice, that I merged module civic infos to core too.
@KaTiON_PT what changes here were meant to be here?

I'll replace it with copy from SVN to see what are differences.

Between SVN version and current github branch version there are only 3 differences in civic infos:
Line was adjusted a bit - no change to its content.
Tribal Warfare civic now is unlocked with Warfare instead of Tribalism.
Community Labor now is unlocked at Cooperation instead of Tribalism.

These things were here all time (where you noticed change of value), just being overridden with module stuff.
I then replaced it with stuff from modules, as I merged them to core.
Kation didn't update civic infos as I merged modules to core, so I updated it for him to match what is currently in SVN.

So basically only changes that were meant to be here is changing tech requirements of two civics compared to SVN.

I'm very glad you went through this Raxo. Thank you.

 

[billw2015]

I'm not sure.

Yeah it is ONLY the Floristry tech, so I think it is a data error, I am going to have a look, but I don't know what to look for really.

 

[KaTiON_PT]

@KaTiON_PT what changes here were meant to be here?

Not sure, most likely an error from trying to merge stuff?

As thunderbrd said, thank you for going through this.

 

[billw2015]

I checked the latest on SVN and the bug with the Floristry is still there in my save game. However on a NEW game it is not there. So I have no idea but I don't think it is anything I changed.

Spoiler :

 

[Thunderbrd]

I checked the latest on SVN and the bug with the Floristry is still there in my save game. However on a NEW game it is not there. So I have no idea but I don't think it is anything I changed.

Spoiler :

View attachment 533648

That's odd... that's just a string generation issue isn't it?

 

[JosEPh_II]

I checked the latest on SVN and the bug with the Floristry is still there in my save game. However on a NEW game it is not there. So I have no idea but I don't think it is anything I changed.

Spoiler :

View attachment 533648

If your game you checked was started Before the addition Of the New Preh Era, then you will still see the Old Tech tree. Once a game is started the Tech Tree is locked in.

When you started a New Game, Then you are seeing the New Preh Tech tree.

 

[Thunderbrd]

If your game you checked was started Before the addition Of the New Preh Era, then you will still see the Old Tech tree. Once a game is started the Tech Tree is locked in.

That's a bit odd isn't it? Hasn't it always immediatley updated?

 

[KaTiON_PT]

Have you recalculated modifiers?

 

[JosEPh_II]

That's a bit odd isn't it? Hasn't it always immediatley updated?

No and No.
An individual tech that has a change to what it gives or allows but is not moved from it's X-Y co-ords. will change with a re-Calc or restart of save after an Update. The Tech tree as a whole does not. At least that's the way it's been for ages.

EDIT: But now with all this coding changes that may not hold water anymore either.

 

[olduser]

An individual tech that has a change to what it gives or allows but is not moved from it's X-Y co-ords. will change with a re-Calc or restart of save after an Update. The Tech tree as a whole does not. At least that's the way it's been for ages.

Are you sure about that???

 

[raxo2222]

No and No.
An individual tech that has a change to what it gives or allows but is not moved from it's X-Y co-ords. will change with a re-Calc or restart of save after an Update. The Tech tree as a whole does not. At least that's the way it's been for ages.

EDIT: But now with all this coding changes that may not hold water anymore either.

Techs, that you researched will stay researched in ongoing game.
But techs always will change their position.
First column should have three techs on beginning.
There should be unresearched tech called Nocturialism or something like that (Prehistoric), as you are ion Classical or Medieval era by now in one of your games.

SVN revision doesn't have Prehistoric era revision in it yet.

 

[irishhombre]

I am getting this strange error message when I try to shift click multiple units. Game does not crash, at first I ignored it but it has been popping up more frequently. Save uploaded.
Edit: Forgot to say SVN 11024.
Edit again: Forgot to mention using Raxos no longitude or latitude mode of. Should not error report when lacking sleep, sorry.

Spoiler Error Message :

 

[JosEPh_II]

Are you sure about that???

That's how it used to be.

But anymore? No I'm not 100% sure on Anything in this Mod now today.