Single Player bugs and crashes v37 plus (SVN) - After the 24th of December 2016

[Raledon]

While it's a simple UI issue, it may point to a bigger issue.
When hovering over the number indicating promotions (in the picture below, the [2] at the corner of each promotion) we get a tooltip of a different description. for example, instead of might I, we get the description of Grape Shot. As it's a LE unit, it's obvious that it shouldn't have a ship's promotion.
Also, if anyone could check if it exists in pre-svn r9875, it will be helpful (I'm pretty sure I didn't affect this in any way, but better safe than sorry).
*hovering over the tooltip's icon works fine, just hovering over the number causes the issue

Spoiler :

 

[JosEPh_II]

The Ikhanda wonder requires a storage pit to be built, but if the Warehouse is built, the storage pit is removed and the Ikhanda can no longer be built.

Iirc this Wonder is a limited time usage Wonder, Early game Unit building booster. In other words not good for whole game. Many Wonders were built this way.

 

[JosEPh_II]

While it's a simple UI issue, it may point to a bigger issue.
When hovering over the number indicating promotions (in the picture below, the [2] at the corner of each promotion) we get a tooltip of a different description. for example, instead of might I, we get the description of Grape Shot. As it's a LE unit, it's obvious that it shouldn't have a ship's promotion.
Also, if anyone could check if it exists in pre-svn r9875, it will be helpful (I'm pretty sure I didn't affect this in any way, but better safe than sorry).
*hovering over the tooltip's icon works fine, just hovering over the number causes the issue

Spoiler :

View attachment 486928

This has been around for ever. If you don't get your mouse cursor squarely on the Promo it shows a different one. This has been around since T-brd starting expanding the promotions, years ago.

 

[Toffer90]

Guess I'm late to the party but 4% is way too low. Even If noriad2 does not agree. Not everyone plays NM Deity nor is obsessed with finding loopholes to exploit. The original 20% was more in line for avg players needs If they are going to abandon a city and sell off the buildings.

Never too late, I can easily adjust it up again if folks want it higher, but Noriad is probably right about 20% being a bit too high.
I have no strong opinion on the matter. Would a compromise of 10% be okay by you for the time being?

 

[JosEPh_II]

Never too late, I can easily adjust it up again if folks want it higher, but Noriad is probably right about 20% being a bit too high.
I have no strong opinion on the matter. Would a compromise of 10% be okay by you for the time being?

That's better than 4%. But still a few % points shy of a full compromise.

It's just that sometimes NM Deity Players go a bit overboard on their "wishes". Their input is usually good but you still have to adjust it for the average C2C player. And this perceived problem is really a niche thing that is not a general use "problem" by the main body of C2C users.

 

[Thunderbrd]

@Thunderbrd recosted all buildings.
Looks like he messed something here.
Water Departament has TECH_PLUMBING (X29) prereq and cost of 1660.
According to table base cost of Water Department would be 184 (*4 for being national wonder), that is 736

Should be x2 for national wonders now.

What file is this national wonder found in?

 

[Thunderbrd]

While it's a simple UI issue, it may point to a bigger issue.
When hovering over the number indicating promotions (in the picture below, the [2] at the corner of each promotion) we get a tooltip of a different description. for example, instead of might I, we get the description of Grape Shot. As it's a LE unit, it's obvious that it shouldn't have a ship's promotion.
Also, if anyone could check if it exists in pre-svn r9875, it will be helpful (I'm pretty sure I didn't affect this in any way, but better safe than sorry).
*hovering over the tooltip's icon works fine, just hovering over the number causes the issue

Spoiler :

View attachment 486928

I can't check into this at the moment but you're right this is the kind of thing that some of what you were playing with could impact. I've never seen what Joe's talking about except after an update a while back we saw some strange indexing for a while but it seemed to sort itself out. Do some stress tests and see if you can figure out what's going on there.

 

[raxo2222]

Should be x2 for national wonders now.

What file is this national wonder found in?

Then info in recosting thread under table should be edited accordingly

Caveman2Cosmos\Assets\XML\Buildings\NationalWonders_CIV4BuildingInfos

 

[Thunderbrd]

Then info in recosting thread under table should be edited accordingly

I thought I had edited that. Must've missed that step. Nat Wonders x2 Group Wonders x4 World Wonders x6 Team Projects x8 now. I'll update the modders info post with that soon as I can.

 

[Toffer90]

While it's a simple UI issue, it may point to a bigger issue.
When hovering over the number indicating promotions (in the picture below, the [2] at the corner of each promotion) we get a tooltip of a different description. for example, instead of might I, we get the description of Grape Shot. As it's a LE unit, it's obvious that it shouldn't have a ship's promotion.
Also, if anyone could check if it exists in pre-svn r9875, it will be helpful (I'm pretty sure I didn't affect this in any way, but better safe than sorry).
*hovering over the tooltip's icon works fine, just hovering over the number causes the issue

Just a display issue caused by sloppy python code, fixed in latest SVN.

 

[Thunderbrd]

Then info in recosting thread under table should be edited accordingly

Caveman2Cosmos\Assets\XML\Buildings\NationalWonders_CIV4BuildingInfos

https://forums.civfanatics.com/threads/modders-documentation.441325/page-10#post-14723083
This is the current base chart for costing. As you can see, it does include the new multipliers already. Perhaps you're looking at the wrong one? Is the first post link to this chart going to an older chart post?

 

[Thunderbrd]

From table, that lists cost of building depending on its tech prereq:
Base Production Costs by Tech X Grid
(of the latest prereq tech to unlock the building or unit)
4/13/2017(est. during v38 design cycle)

Column Base Production Cost
29 -------- 184 (X4 for NW would be 736 hammers)

Actual base cost for Water Department NW is 1660 - bit too high, as Raledon reported.

Unless there is different, more updated table, where base cost of building with latest tech requirement being at X29 is same as tech cost itself.
I'm using this table: https://forums.civfanatics.com/threads/building-re-costing-project.620246/ to check how expensive building should be.
Cost of Plumbing tech doesn't matter here at all.

Somehow it ended up being cost in the wrong x grid.

 

[Thunderbrd]

The Ikhanda wonder requires a storage pit to be built, but if the Warehouse is built, the storage pit is removed and the Ikhanda can no longer be built.

Addressed on next commit.

 

[Thunderbrd]

@Thunderbrd ,
Save game from Partisan thread discussions.

City of New Orleans which is located on NE shore of Asoka's mainland. Which is NE of my home island. Partisans are now on a Volcano tile defending east of NO along mountain range. Asoka has sent another Thug into N.O. as well. That makes 5. I just landed a troop transport with City guards and guard dogs to help fight the ever rising crime wave.

Ok, now I get what happened. I forgot that they get the Freedom Fighter promotion for free when generated by losing their cities and that it takes away their HN status. This makes sense but keeps them from being able to do certain things without causing problems. I wish that they could have their crime negated when this happens but unfortunately that's not possible.

Perhaps for now we need to remove the removal of HN status on the Freedom Fighter promotion so they don't get stuck in your territory spreading crime. I wish I had more power to control property modifiers in the code. I might have to get in and figure out a way to inhibit those for a unit with a promo boolean. What would be BEST is if they only create crime on plots of the nation that took the city they were once part of.

 

[Thunderbrd]

Playing with rev 9868. One of the more recent updates has broken one of the unique culture units.

I've got the Hurrian culture, which gives me "Teshub Priest". This unit used to have level 3 educate as it's special ability, but that's gone now and the unit is basically just an expensive bard - a quarter more expensive than the normal bard with no special ability. They should basically be the same unit type as the special Sabbatean culture unit "Magos" (which currently works as designed).

I'm certain that this is the case, as I have been planning to build both these units in all my cities, so I could turn my awful education levels around.

Also normal bards are pink, unless you click on them, in which case they turn into scantily clad women?

Savegame included.

For as long as these have been in the game they have never had stated free promos. I've looked all the way back to when they were placed into the file they are in on the change log and Whisperr had a much older copy and found it in one of her files there and it still didn't have these promos free. HOWEVER, you are right about them being the same as bards. Much as they should be given a special ability, this might not be what they should be given since Teshub is a warrior god (basically he is Enlil of Sumeria graduated one culture over and incarnated as a more martial god.) However, without some serious tweaking, for now I've given him the requested free promotions. I feel they should be changed later to be a blend of Entertainer and a more combat worthy unit rather than a more educational one. This wasn't a bug in code - they didn't have the free promos set to them in the first place.

Well folks, I'm holding off on committing tonight but I expect that unless I get hit with an unexpected NASTY bug tomorrow, Whisperr and I will be able to commit the final updates before we can package release.

 

[raxo2222]

https://forums.civfanatics.com/threads/modders-documentation.441325/page-10#post-14723083
This is the current base chart for costing. As you can see, it does include the new multipliers already. Perhaps you're looking at the wrong one? Is the first post link to this chart going to an older chart post?

Yep, I was looking here: https://forums.civfanatics.com/threads/building-re-costing-project.620246/
On THIS thread cost multipliers aren't changed.

 

[Raledon]

The the police helicopter's strategy text is bugged. Shows TXT_KEY_UNIT_POLICE_HELICOPTER_STRATEGY instead of the actual text.

Edit:
@Thunderbrd I think trade is way too profitable.
My caravan moves in 1-2 turns from my city (at the top) to seoul (at the bottom, size 22), and profits over 500g per run. This is an extreme amount, to the point I decided that even one is an abuse, and I shouldn't make another 4 to use it.
The distance multiplier should probably be higher (IE the further the city, the more gold should be more relevant), and it seems the base is a bit high. In this case, I'd consider 50g as a nice profit. (would mean a ROI in about 12 turns, instead of 2).
Another thing that could be taken into account is how much you travel outside of your borders. While your borders are relatively clean from criminals, you can't assume the same on the enemies. In this case, I'm extremely safe since I pass from my borders into his city in a single turn (it'll be worse later, when the roads are upgraded).
Another option is to have the unit get consumed in the process. In such a case, I think it might be quite good (risks+delay, but higher production-> gold return)
*It's interesting to note that Pussan (the 3rd city in the picture) will give me only ~60g. This is around the sum I'd expect.

Spoiler :

 

[JosEPh_II]

The the police helicopter's strategy text is bugged. Shows TXT_KEY_UNIT_POLICE_HELICOPTER_STRATEGY instead of the actual text.

Edit:
@Thunderbrd I think trade is way too profitable.
My caravan moves in 1-2 turns from my city (at the top) to seoul (at the bottom, size 22), and profits over 500g per run. This is an extreme amount, to the point I decided that even one is an abuse, and I shouldn't make another 4 to use it.
The distance multiplier should probably be higher (IE the further the city, the more gold should be more relevant), and it seems the base is a bit high. In this case, I'd consider 50g as a nice profit. (would mean a ROI in about 12 turns, instead of 2).
Another thing that could be taken into account is how much you travel outside of your borders. While your borders are relatively clean from criminals, you can't assume the same on the enemies. In this case, I'm extremely safe since I pass from my borders into his city in a single turn (it'll be worse later, when the roads are upgraded).
Another option is to have the unit get consumed in the process. In such a case, I think it might be quite good (risks+delay, but higher production-> gold return)
*It's interesting to note that Pussan (the 3rd city in the picture) will give me only ~60g. This is around the sum I'd expect.

Spoiler :

View attachment 487000

Can this wait till after v38 release? It's not a game breaker.

 

[Toffer90]

The the police helicopter's strategy text is bugged. Shows TXT_KEY_UNIT_POLICE_HELICOPTER_STRATEGY instead of the actual text.

I have it fixed on my end now.

 

[JosEPh_II]

I have it fixed on my end now.

Okay cool.