1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

Single Player bugs and crashes v38 plus (SVN) - After the 20th of February 2018

Discussion in 'Bugs and Crashes' started by Dancing Hoskuld, Feb 24, 2018.

  1. Thunderbrd

    Thunderbrd C2C War Dog

    Joined:
    Jan 2, 2010
    Messages:
    26,086
    Gender:
    Male
    Location:
    Las Vegas
    You did a great job and I only adjusted it due to further considerations that occurred to me was all. I overlook all kinds of stuff usually and this wasn't even that necessary a change to have made. I think it's to your credit you took a step into working on it. You insinuated that you've worked on some other code issues? I'm curious what those might be.
     
  2. Usul13

    Usul13 Chieftain

    Joined:
    Jan 15, 2016
    Messages:
    147
    So I tried it with turning off fixed borders, with and without IDW enabled. In both case the result is the same as before, RCS doesn't work properly in conquered cities on the first couple culture levels.
     
  3. Thunderbrd

    Thunderbrd C2C War Dog

    Joined:
    Jan 2, 2010
    Messages:
    26,086
    Gender:
    Male
    Location:
    Las Vegas
    hmm must be more going on than the portion I read in the code then. More to review yet.
     
  4. JosEPh_II

    JosEPh_II TBS WarLord

    Joined:
    Jun 20, 2007
    Messages:
    15,672
    Gender:
    Male
    Location:
    Western IL. cornfields
    In ages past If you captured a city to get the city influence to start growing you needed to build 1st thing a theatre or similar building that gave a good culture boost. Or use a GA to culture bomb it. With out doing so it would take many turns before the Culture would be sufficient for tiles around the city to show up as yours. The tiles would not become yours if you did not start adding Culture asap. This was especially true during Rise of Mankind, RoMAND, and the early ages of C2C playing days.

    I do not recall if it was changed when RCS was incorporated into C2C or if the change came after RCS was in C2C. But when the modding team back then added more Culture Levels (and that, the added Culture Levels was from an Afforess' Modmod for RoMAND) to the Mod, it was around versions 10 - 17 timeframe, RCS had significantly different playing effects. I stopped playing it (same for Fixed Borders and for City Limits thru Civics) for awhile after these changes. Cultural Influence was a big deal back then and AI Cities could become dominant thru Culture. And would encompass a Huge area around their biggest cities. The AI was very good back then at winning a Cultural victory. koshling and/or DH made some significant changes to these options back then, maybe even ls612.

    Whether any of this is relevant to today's perceived problem is not clear to me but it used to be different. Way different than it is now. (C2C History lesson number 35) ;)
     
  5. DC0

    DC0 Chieftain

    Joined:
    Dec 20, 2008
    Messages:
    251
    Gender:
    Male
    Location:
    Russia, Moscow
    If building is obsolete/replaced, it is still there somewhere in a city. It stands derelict and produces tales of horror for kids to spook other kids.
    And since it's derelict, there is a actually a higher chance for it to catch fire.
    The reason it is not displayed in buildings list of a city is simple: this list shows assets. Once building becomes obsolete it becomes liability, not an asset.

    So I'm sorry, but you change is counter-logical.
     
  6. Thunderbrd

    Thunderbrd C2C War Dog

    Joined:
    Jan 2, 2010
    Messages:
    26,086
    Gender:
    Male
    Location:
    Las Vegas
    That's one way to see it but there's no actual penalties to these derelict buildings and many are naturally and silently repurposed so it makes sense that events should be only targeting anything that can actually matter to the player when they take place.
     
  7. tmv

    tmv Chieftain

    Joined:
    Nov 24, 2015
    Messages:
    1,212
    Gender:
    Male
    Location:
    Germany
    These buildings could even be still maintained (as buildings) and used as museums. There are more than enough examples of old mines, mills or even farms that are used to show people how their ancestors lived. So you could have them still cost money but generate culture and education.
     
  8. Thunderbrd

    Thunderbrd C2C War Dog

    Joined:
    Jan 2, 2010
    Messages:
    26,086
    Gender:
    Male
    Location:
    Las Vegas
    You could establish that with the use of some tags specifically for that purpose that are already in use on some wonders (safeobsolete). Of course, I find there are a lot higher priorities in mod design at the moment ;)
     
    tmv likes this.
  9. Fermongu

    Fermongu Chieftain

    Joined:
    Oct 27, 2017
    Messages:
    172
    Gender:
    Male
    Last SVN. I got this python errors on my ongoing campaign:

    Traceback (most recent call last):

    File "CvRandomEventInterface", line 8433, in doMajorFire

    NameError: global name 'isObsoleteBuilding' is not defined
    ERR: Python function doMajorFire failed, module CvRandomEventInterface


    Traceback (most recent call last):

    File "CvRandomEventInterface", line 510, in canApplyLooters3

    NameError: global name 'player' is not defined
    ERR: Python function canApplyLooters3 failed, module CvRandomEventInterface
     
  10. raxo2222

    raxo2222 Time Traveller

    Joined:
    Jun 10, 2011
    Messages:
    6,142
    Location:
    Poland
    @Toffer90 could fix this one or @Thunderbrd
     
  11. Thunderbrd

    Thunderbrd C2C War Dog

    Joined:
    Jan 2, 2010
    Messages:
    26,086
    Gender:
    Male
    Location:
    Las Vegas
    Actually, this is probably from @Morlark 's most recent adjustment to that file. I wonder if he could possibly take a look at attempting to fix it.
     
    raxo2222 likes this.
  12. Toffer90

    Toffer90 C2C Modder

    Joined:
    Oct 16, 2011
    Messages:
    6,082
    Location:
    Norway
    Yeah, there's quite a few errors in CvRandomEventInterface, more than just what fermongu reported.
    I'll work a bit on it tonight.
     
    KaTiON_PT and Thunderbrd like this.
  13. strategyonly

    strategyonly C2C Supreme Commander

    Joined:
    Mar 13, 2006
    Messages:
    20,445
    Gender:
    Male
    Location:
    MN
    as requested from the discussion thread: Big Cars uncut/sizematters both checked arent working??
     

    Attached Files:

  14. Morlark

    Morlark Chieftain

    Joined:
    Aug 6, 2009
    Messages:
    192
    I'd been looking at some problem I had with event eligibility, and units being mistargetted for events, but during my analysis I wasn't able to satisfactorily determine the root cause of the problem, so I have no solution to present for now. I also had some thoughts regarding gamespeed scaling, but they can be discussed at another time.

    Whoops, yeah, looks like when I was making the edits to each of the events, I didn't copy/paste that line correctly in that event. Fixed file is attached.
     

    Attached Files:

  15. Thunderbrd

    Thunderbrd C2C War Dog

    Joined:
    Jan 2, 2010
    Messages:
    26,086
    Gender:
    Male
    Location:
    Las Vegas
    I'll let Toffer handle this from here but thanks for the debugging!
     
  16. glaucus.b

    glaucus.b Chieftain

    Joined:
    Jun 5, 2011
    Messages:
    62
    Location:
    UK
    SVN Revision 10333

    After Tool Making, I cannot build brutes anymore. I try to find the switch for obsolete units but couldn't find it. What is the problem?
     
  17. raxo2222

    raxo2222 Time Traveller

    Joined:
    Jun 10, 2011
    Messages:
    6,142
    Location:
    Poland
    In BUG there is option to hide obsolete things.
     
  18. Yudishtira

    Yudishtira Spiritual/Creative

    Joined:
    Nov 2, 2012
    Messages:
    2,424
    Location:
    Brisbane
    I built the Machu Picchu wonder. It placed its unique improvement on the city's obsidian peak. The loss of vicinity obsidian to the city in turn led to the extinction of the local Aztec culture.

    It is the only peak in the vanilla vicinity, but the city is Influential and that option is on, so there are two more resource-free candidates in the 'third ring'. Alternatively, the improvement could continue to provide any resource it is built on.

    Overall, you could call it a 'fun' freak occurrence, but it seems a large downside from a wonder.
     
  19. Thunderbrd

    Thunderbrd C2C War Dog

    Joined:
    Jan 2, 2010
    Messages:
    26,086
    Gender:
    Male
    Location:
    Las Vegas
    This strikes me as the best way to respond. Can someone go into the xml on this and make the macchu picchu's improvement give access to any bonus it may exist on? I didn't even know we had a wonder that did this but it's otherwise sounding like a cool effect.
     
  20. glaucus.b

    glaucus.b Chieftain

    Joined:
    Jun 5, 2011
    Messages:
    62
    Location:
    UK
    Could you please let me know under which menu it is? I spent 10 minutes to find but unfortunately was not successful.
     

Share This Page