Single Player bugs and crashes v39 plus (SVN) - After the 20th of July 2019

[gamer1978]

I tried several times. Should I just delete the whole game/reinstall and get the mod again?. Was working fine yesterday. I updated to revision today and poof gone. Not sure what dump file you want? is it called a mini dump?

 

[JosEPh_II]

As designed isn't the same as correctly, if other stuff changes,

In this case it is. Other stuff has not changed in regards to this specific design.

or if everyone else disagrees with the design then working "as designed" doesn't really say much!

And who are theses "everyone"? Pretty specious argument there don't you think?

 

[JosEPh_II]

I tried several times. Should I just delete the whole game/reinstall and get the mod again?. Was working fine yesterday. I updated to revision today and poof gone. Not sure what dump file you want? is it called a mini dump?

No don't re-install your game. that is not the answer.

Do you know how to revert thru the SVN to the previous version? You can always do that.

Also with major changes it might be a good practice to delete your User Settings folder Before you update to a New SVN version. The Mod will automatically make a new User settings folder for you.

Here is an example of where to find the minidump.dmp file. C:\Program Files (x86)\Firaxis Games\Sid Meier's Civilization 4\Beyond the Sword ---> in the Beyond the Sword folder.

Below is an example of a compressed MiniDump.dmp file. This was one of mine for SVN 10950. The MiniDump.dmp must be zipped, rar'ed or 7z'd for it to be uploaded.

 

[Thunderbrd]

Since pests mostly just hinder growth, even if they are causing some unhealth and unhappiness, it would seem silly to reduce your size so that you can alleviate growth hindrances. Not sure how that's much of a concern there.

And how am I being a jerk? Is reminding of the past now not a correct thing to do? (And yes I see the lol. )

I guess I felt like you were trying to say, "Do you even HAVE any honor?" Trying to play like you're being morally superior somehow when really, you've been on the attacking end of some of Hydro's stuff before and I felt like it was a dig at me for using that as a defense of the design as it was at those times as well. Sometimes your words are laden with a lot more subtext it seems than what they appear like on the surface. I'm laughing at it because I'm kinda thinking it can't be that you're thinking of it THAT deeply and trying as hard as it might seem to get under the skin. Perhaps you just don't realize the insinuation in your comment. I have it pointed out all the time that someone thinks I meant something so much more, deeper, or even just outright differently than I actually did, so I do tend to give folks the benefit of the doubt. By pointing to it, I thought you might see why I COULD take it that way. Didn't seem like a reminder so much as an attack - of course I remember that. But what I didn't remember was why he would want such a strange thing to want. Now that you've reminded me I do remember a conversation where he explained his position on that and I recall disagreeing then as well, though not strongly.

And who are theses "everyone"? Pretty specious argument there don't you think?

I think the 'everyone' in this case, just means a general overall agreement if it exists. Not necessarily claiming that it does, even now in this conversation.

 

[billw2015]

And who are theses "everyone"? Pretty specious argument there don't you think?

I was making a general argument not specific about this case, as I tried to clarify by adding "I'm not saying that is the case here, but that would be my criteria in general." Also I did say "almost everyone", you will never get literally everyone to agree on anything!

 

[Dancing Hoskuld]

There is a problem with the help description in many buildings due to caching of information and other. I had to remove a whole project because of it. The Scarecrow building is a good case it removes a Pest but it does not say it gets rid of them anywhere nor does it say the changes that will occur due to the removal of the Pest. The "actual values" are not actually "actual values" for a city but, I think, are some generic city, perhaps the capital which because it is bigger already has the building.

 

[Thunderbrd]

There is a problem with the help description in many buildings due to caching of information and other. I had to remove a whole project because of it. The Scarecrow building is a good case it removes a Pest but it does not say it gets rid of them anywhere nor does it say the changes that will occur due to the removal of the Pest. The "actual values" are not actually "actual values" for a city but, I think, are some generic city, perhaps the capital which because it is bigger already has the building.

Actual values apply to the city when you are looking at the actuals in the city build queue but in the pedia you don't have that. By saying it's an upgrade of the pest, it means it replaces it, though it does NOT remove it. IF the Scarecrow is removed, the pest is still there. This is how building upgrade chains work.

 

[gamer1978]

Ok I had to revert to 11034 and now the mod works fine again. The mini-dump file I deleted by mistake earlier sorry and it did not generate a new one. Wonder why it won't work for me at 11036.

 

[billw2015]

Reporting python error, SVN 11034. This repeats a lot of times:


Traceback (most recent call last):

File "CvRandomEventInterface", line 2668, in expireMasterBlacksmith1

AttributeError: 'NoneType' object has no attribute 'getCity'
ERR: Python function expireMasterBlacksmith1 failed, module CvRandomEventInterface

Looks like some civ dies same turn they completed master blacksmith perhaps? Certainly none of the Py event expire code is checking if the player is actually valid or not.

 

[billw2015]

Ok I had to revert to 11034 and now the mod works fine again. The mini-dump file I deleted by mistake earlier sorry and it did not generate a new one. Wonder why it won't work for me at 11036.

Could just be coincidence, just restarting game again and/or jiggling SVN files could have fixed the problem. If you now go back to 11036 and it is broken again I will be convinced! I am playing SVN-11036 myself right now.

 

[Dancing Hoskuld]

Actual values apply to the city when you are looking at the actuals in the city build queue but in the pedia you don't have that. By saying it's an upgrade of the pest, it means it replaces it, though it does NOT remove it. IF the Scarecrow is removed, the pest is still there. This is how building upgrade chains work.

But it does not tell you that it removes the values from the pests. Eg if the pest had a - it does not show you that building the scarecrow would give your city +

That was the main problem for players with the Demand mod I was working on, you got -1 for each pop over 6 but building the Market removed (replaced the demand buildings) so building the market could give your city +14 happiness if it was size 20. It never showed in the actual values even though you would actually get that value.

 

[Thunderbrd]

But it does not tell you that it removes the values from the pests. Eg if the pest had a - it does not show you that building the scarecrow would give your city +

It should. It may depend on the tag as to how accurate it's programmed to deliver such information. The commerce and yields do report the end total after replacing a previous building. This kind of thing would be programmed on a tag by tag basis and not all tags are equally well developed into the complicated 'actuals' totalling mechanism. Certainly something to improve on.

 

[Toffer90]

What on earth could the reasoning be for this? It seems obvious that pests should go away when the criteria to support them goes away.

Yeah, you misunderstood what Joe said a bit though, no building in the game goes away when the pop requirement fails, this has nothing to do with the pest design, this is just a dll quirk.
A lot of building prereqs are ignored after the building is built.
This is not a design choice per say, more probable that it was just an oversight when adding in new building requirements.

Hydro designed pest so that they should be a relevant game mechanic throughout all eras, I think this is what Joe meant with what he said.

 

[billw2015]

Yeah, you misunderstood what Joe said a bit though, no building in the game goes away when the pop requirement fails, this has nothing to do with the pest design, this is just a dll quirk.

Ah okay, that wasn't clear to me. Sorry @JosEPh_II!

more it is lazy dll programmers who never bothered adding in the new types of requirements in the code that decides if a building should stop functioning in a city.

Yeah, although, I would imagine they were more cowardly than lazy, not wanting to accidentally topple the house of cards that is the dll code.

 

[Thunderbrd]

Yeah, you misunderstood what Joe said a bit though, no building in the game goes away when the pop requirement fails, this has nothing to do with the pest design, this is just a dll quirk.
A lot of building prereqs are ignored after the building is built.
This is not a design choice per say, more probably it is lazy dll programmers who never bothered adding in the new types of requirements in the code that decides if a building should stop functioning in a city.

Hydro designed pest so that they should be a relevant game mechanic throughout all eras, I think this is what Joe meant with what he said.

Actually I remember the discussion now that he brought it up - Hydro DID want city size to not update whether the autobuild should be there for much the justification Joe gave. It was considered.

 

[Thunderbrd]

Ah okay, that wasn't clear to me. Sorry @JosEPh_II!

Yeah, although, I would imagine they were more cowardly than lazy, not wanting to accidentally topple the house of cards that is the dll code.

Guilty of that on numerous occasions. lol

 

[Toffer90]

Actually I remember the discussion now that he brought it up - Hydro DID want city size to not update whether the autobuild should be there for much the justification Joe gave. It was considered.

Ah, ok, I assumed it was an oversight rather than a design choice. Yeah there may be some building requirements that make sense not to deactivate buildings after they're built. Though the pop req seems kinda absolute to me...
Like a shopping mall is not something you build where there's no people living, but if people disappears after it's built, does it make sense for the shopping mall to function normally afterwards?

 

[Harrier]

Ah, ok, I assumed it was an oversight rather than a design choice. Yeah there may be some building requirements that make sense not to deactivate buildings after they're built. Though the pop req seems kinda absolute to me...
Like a shopping mall is not something you build where there's no people living, but if people disappears after it's built, does it make sense for the shopping mall to function normally afterwards?

Well if the shoppers disappear, the mall still remains and has to pay for its upkeep (rent, rates, business taxes, utilities etc.) even if it sacks all its staff (with the costs involved then - unless it goes bankrupt. Even then costs are involved).

If the building is left empty and unused - the city suffers as it is not gaining any revenue.

So if the population falls below the threshold for building and maintaining a unit, that unit should remain, (until deleted at a cost) but give a negative gold amount.

 

[MattCA]

Looks like some civ dies same turn they completed master blacksmith perhaps? Certainly none of the Py event expire code is checking if the player is actually valid or not.

I like that theory actually.

Alberts made a change to this line in structs.cpp. Slim chance its coincidence. Still doesn't make much sense though. Could it be trying to finish the blacksmith event for a different type of event that was started with differet args?

WRAPPER_WRITE_CLASS_ENUM(wrapper, "EventTriggeredData", REMAPPED_CLASS_TYPE_EVENT_TRIGGERS, m_eTrigger);

if this is the cause that means all save games have been given a bug the does nothing and won't appear again for new games.

Edit: might not have been Alberts actually idk. Doesn't really matter anyways

 

[olduser]

I like that theory actually.

Alberts made a change to this line in structs.cpp. Slim chance its coincidence. Still doesn't make much sense though. Could it be trying to finish the blacksmith event for a different type of event that was started with differet args?

WRAPPER_WRITE_CLASS_ENUM(wrapper, "EventTriggeredData", REMAPPED_CLASS_TYPE_EVENT_TRIGGERS, m_eTrigger);

if this is the cause that means all save games have been given a bug the does nothing and won't appear again for new games.

Edit: might not have been Alberts actually idk. Doesn't really matter anyways

I only made that change in the save compatiblility fixes branch because it breaks saves! Is that change now also present in the master branch?