Single Player bugs and crashes v39 plus (SVN) - After the 20th of July 2019

[Thunderbrd]

Yeah testing was coming up with some error in bug city event manager. Sounded like an easily replicable python issue to me. Maybe we can address it tomorrow.

 

[raxo2222]

newest SVN errors

Traceback (most recent call last):
File "BugEventManager", line 308, in _handleDefaultEvent
File "CvEventManager", line 2658, in onCityDoTurn
File "CvAdvisorUtils", line 322, in cityAdvise
UnboundLocalError: local variable 'iTurnFounded' referenced before assignment

@Toffer90

 

[olduser]

Because I am increasing its length in the process, so I think searching the original length would be a little more efficient

I'm going to revert last changes, I was too confident in myself to make those changes and mixed up things I am fixing with unsafe changes too often

This wont make real a difference because those vectors are usally very very small.

I originaly sorted these vectors to make them behave the same way as they did before with using an array. Sorting them also makes searching something in them a bit faster.

Take your time to test your changes modding C2C isn't a race try to make smaller commits this will make your life much easier.

 

[ssmage]

Assert Failed

File: CvArtFileMgr.cpp
Line: 96
SVN-Rev: 10807
Expression: false
Message: ArtInfo: '' was not found

Seems to be myth of the bull, due to the in-game text having a speedup of ngai buildings.

 

[raxo2222]

Assert Failed

File: CvArtFileMgr.cpp
Line: 96
SVN-Rev: 10807
Expression: false
Message: ArtInfo: '' was not found

Seems to be myth of the bull, due to the in-game text having a speedup of ngai buildings.

Upload save

I used debug dll, looked at art def xml log, and nothing found.
Browsing pedia for all animals/regilious buildings also didn't gave error....

 

[Toffer90]

File "CvAdvisorUtils", line 322, in cityAdvise
UnboundLocalError: local variable 'iTurnFounded' referenced before assignment

Fixed in 10810.

 

[ssmage]

Upload save

I used debug dll, looked at art def xml log, and nothing found.
Browsing pedia for all animals/regilious buildings also didn't gave error....

Nevermind, It was a corrupted file from when I updated to that svn version, a redownload fixed it.

 

[strategyonly]

got these errors on latest SVN:

[WARN] GPUtil.getUnitIcon
No GP icon for UNIT_GREAT_STATESMAN

 

[raxo2222]

got these errors on latest SVN:

[WARN] GPUtil.getUnitIcon
No GP icon for UNIT_GREAT_STATESMAN

Fixed that typo.

As for no GP icon for statesman it could be something else - maybe old bug.

 

[Yudishtira]

Can someone please tell me what version's save I have to go back to before it works with the latest SVN?

 

[raxo2222]

Can someone please tell me what version's save I have to go back to before it works with the latest SVN?

If you were playing on corrupted revisions, then you should revert to 10778 (Sunday save), recalculate it, save, and then update to last revision.

 

[Yudishtira]

If you were playing on corrupted revisions, then you should revert to 10778 (Sunday save), recalculate it, save, and then update to last revision.

Wow I can hardly believe it! Can you confirm that I can take my latest save from 10790, load it in 10778 (which I already have a copy of), recalc & save, and then it will work with 10806+ (which I also already have a copy of)?

 

[raxo2222]

Wow I can hardly believe it! Can you confirm that I can take my latest save from 10790, load it in 10778 (which I already have a copy of), recalc & save, and then it will work with 10806+ (which I also already have a copy of)?

I'm not sure if taking game saved in 10790 and recalculating in 10778 will clean it, but you can give it try.

 

[Yudishtira]

I'm not sure if taking game saved in 10790 and recalculating in 10778 will clean it, but you can give it try.

Yes it does seem unlikely doesn't it? It's worth a try, but it is unlikely to even load in an earlier version.

But if I take a save from my previous version which was 10763, that should all work?

 

[raxo2222]

But if I take a save from my previous version which was 10763, that should all work?

Newer save may load but may crash on recalculation.

Older one should go just fine on last svn.

 

[raxo2222]

@Toffer90 can you remove this message: "debug event: CityTabOptions" when changing icon size? It isn't needed - looks like bug.

 

[raxo2222]

[WARN] GPUtil.getUnitIcon
No GP icon for UNIT_GREAT_STATESMAN

It appears this line was "printed" in python, so I just removed it.

Probably it was some debugging remainder.
It was since beginning of SVN, and then Toffer just edited it a little in PPIO merge.

 

[Elberet]

Updated for latest SVN 10817, recalculated assets in the game and got an infinite load on the next move. Should I redo to Sunday save or..?

 

[Toffer90]

@Toffer90 can you remove this message: "debug event: CityTabOptions" when changing icon size? It isn't needed - looks like bug.

Where does that message appear?

 

[raxo2222]

Updated for latest SVN 10817, recalculated assets in the game and got an infinite load on the next move. Should I redo to Sunday save or..?

Yeah, load your Sunday save and then recalculate.