Single Player bugs and crashes v39 plus (SVN) - After the 20th of July 2019

It may well be that if you saved the game during the corrupt period, you aren't going to be able to get an uncorrupted save at this point. :(
What revisions make up the corrupt period?
 
You said you could recalc that save. I can recalc just about any save - the problem is that they hang/freeze during end turn. Did you progress that save in 10806 or later?

Just now I even tried to progress a save from 10729... unsuccessfully. Can some kind dll modder (maybe you Kation) have a quick look into why these saves hang in 10807 (currently this is the latest dll update) and not in 10778?

Attached is the save I'd most like to progress ie. the latest, the one I originally had the CTD on, but this version has been loaded and recalcd in 10778. Okay now you're telling me that doesn't help at all, in that case you can just use the 10790 save I uploaded earlier (post 235 this thread). If you are unwilling to look at either of these saves and want another, well ok that can be arranged, if reluctantly.

@alberts2 ,
have you heard the terrible things they're saying about you:D? How confident are you that 10762 and 10766 don't corrupt saves?
 

Attachments

@alberts2 ,
have you heard the terrible things they're saying about you:D? How confident are you that 10762 and 10766 don't corrupt saves?
I actually was the first one to report problems with the game either crashing or taking really long to process a turn. However i didn't make any changes at the place where this happens and didn't have time to look at it again. Do you have a save from a week ago?
There seems to be a issue with CvSelectionGroup::splitGroup it's either really slow
View attachment 530783
or crashes sometimes.
View attachment 530785

Or maybe this is caused by CvUnitAI::AI_load?
 
I actually was the first one to report problems with the game either crashing or taking really long to process a turn. However i didn't make any changes at the place where this happens and didn't have time to look at it again. Do you have a save from a week ago?
Well I remember that post, but it nowhere mentions that you were blaming yourself for the problem. Nor does it say it corrupts saves.

And yes I do have saves from a week ago, before uploading can I just confirm you mean from before 10762?
 
Well I remember that post, but it nowhere mentions that you were blaming yourself for the problem. Nor does it say it corrupts saves.

And yes I do have saves from a week ago, before uploading can I just confirm you mean from before 10762?

I made that post because i have no idea what causes these issues and i didn't have have time to really look at it. This migh not even be a save corruption but a processing issue somewhere in the dll. I didn't change anything in the functions which cause problems now so i simply don't know if these issues are side effects of my changes or if they are caused by something else everything is possible.
A save from before 10762 would do.
 
I made that post because i have no idea what causes these issues and i didn't have have time to really look at it. This migh not even be a save corruption but a processing issue somewhere in the dll. I didn't change anything in the functions which cause problems now so i simply don't know if these issues are side effects of my changes or if they are caused by something else everything is possible.

That's what I thought: it is very very unlikely that 10762 or 10766 caused any part of the corrupted saves debacle.

A save from before 10762 would do.

Happy to help. This is from 10729. I also have saves from 10762, if you want one of those. I don't have any saves between there and 10790, apart from the ones I'm playing on currently (in 10778).
 

Attachments

That's what I thought: it is very very unlikely that 10762 or 10766 caused any part of the corrupted saves debacle.
When there is save corruption going around then the latest dll changes are the default suspects, alberts commits were close enough to the reported issues to be included as suspects along with Anq's dll changes. That's all there was to that debacle.
We've moved on since then, anq's changes were reverted and saves are not getting corrupted on the SVN now (afawk).
 
Last edited:
That set of changes fixed my problems thanks!!!!!!!!!:thumbsup:

But these problems already existed before 10796 that makes me think it really could fix the problems @Yudishtira had as well.
Save that he posted here crashes on load.
 

Attachments

Which of his saves is that? He posted a few.
Lower one on this page.

Got asserts on debug dll.
Game loaded on debug DLL though.
Code:
Assert Failed

File:  CvUnit.cpp
Line:  20016
SVN-Rev:  10807
Expression:  bIsLoadVolumeCorrect
Message:

----------------------------------------------------------
Assert Failed

File:  CvUnit.cpp
Line:  20053
SVN-Rev:  10807
Expression:  bIsLoadVolumeCorrect
Message:

----------------------------------------------------------
Assert Failed

File:  CvUnit.cpp
Line:  23009
SVN-Rev:  10807
Expression:  pTransportUnit->SMcargoSpaceAvailable(getSpecialUnitType(), getDomainType()) > 0
Message:  Cargo space is expected to be available

----------------------------------------------------------
Assert Failed

File:  CvUnit.cpp
Line:  19982
SVN-Rev:  10807
Expression:  SMgetCargo() >= 0
Message:

----------------------------------------------------------
Assert Failed

File:  CvUnit.cpp
Line:  20018
SVN-Rev:  10807
Expression:  getCargo() == aUnits.size()
Message:

----------------------------------------------------------
Assert Failed

File:  CvUnit.cpp
Line:  20120
SVN-Rev:  10807
Expression:  getCargo() == iCount
Message:

----------------------------------------------------------
Assert Failed

File:  CvPlayer.cpp
Line:  15971
SVN-Rev:  10807
Expression:  getAssets() >= 0
Message:

----------------------------------------------------------

Took some time to save lol, I didn't recalculate it though.
Now its bit bigger.
 

Attachments

Lower one on this page.

Got asserts on debug dll.
Game loaded on debug DLL though.
Code:
Assert Failed

File:  CvUnit.cpp
Line:  20016
SVN-Rev:  10807
Expression:  bIsLoadVolumeCorrect
Message:

----------------------------------------------------------
Assert Failed

File:  CvUnit.cpp
Line:  20053
SVN-Rev:  10807
Expression:  bIsLoadVolumeCorrect
Message:

----------------------------------------------------------
Assert Failed

File:  CvUnit.cpp
Line:  23009
SVN-Rev:  10807
Expression:  pTransportUnit->SMcargoSpaceAvailable(getSpecialUnitType(), getDomainType()) > 0
Message:  Cargo space is expected to be available

----------------------------------------------------------
Assert Failed

File:  CvUnit.cpp
Line:  19982
SVN-Rev:  10807
Expression:  SMgetCargo() >= 0
Message:

----------------------------------------------------------
Assert Failed

File:  CvUnit.cpp
Line:  20018
SVN-Rev:  10807
Expression:  getCargo() == aUnits.size()
Message:

----------------------------------------------------------
Assert Failed

File:  CvUnit.cpp
Line:  20120
SVN-Rev:  10807
Expression:  getCargo() == iCount
Message:

----------------------------------------------------------
Assert Failed

File:  CvPlayer.cpp
Line:  15971
SVN-Rev:  10807
Expression:  getAssets() >= 0
Message:

----------------------------------------------------------

Took some time to save lol.

I have no problems loading that save and the first turn also processes without crashing or taking extremely long.
 
I have no problems loading that save and the first turn also processes without crashing or taking extremely long.
Probably one of the Win 7 crashes then I suspect.
 
I have no problems loading that save and the first turn also processes without crashing or taking extremely long.
So its some sort of pointer corruption or whatever was fault then - Win7 is worse at this.

Also save tried to be funny after loading on debugdll.
Code:
Assert Failed

File:  CvGame.cpp
Line:  6220
SVN-Rev:  10807
Expression:  getUnitClassCreatedCount(eIndex) <= GC.getUnitClassInfo(eIndex).getMaxGlobalInstances()
Message:  Index is expected to be within maximum bounds (invalid Index)

----------------------------------------------------------
Now I'm recalculating it.

During recalc I got this assert:
Code:
Assert Failed

File:  CvCity.cpp
Line:  10569
SVN-Rev:  10807
Expression:  getNumWorldWonders() >= 0
Message:

----------------------------------------------------------
Assert Failed

File:  CvCity.cpp
Line:  10595
SVN-Rev:  10807
Expression:  getNumNationalWonders() >= 0
Message:

----------------------------------------------------------
Assert Failed

File:  CvPlot.cpp
Line:  11141
SVN-Rev:  10807
Expression:  getVisibilityCount(eTeam) >= 0
Message:

----------------------------------------------------------
Assert Failed

File:  CvCity.cpp
Line:  10582
SVN-Rev:  10807
Expression:  getNumTeamWonders() >= 0
Message:

----------------------------------------------------------
Save couldn't be recalculated - it froze.

It recalculated on normal dll.
 

Attachments

Last edited:
the revolt/?? is not showing up in the city except when u enter the city and look?? cant tell just by looking at it, like it used to be??

also still need those extra 2 commerce arrows, then i am ALMOST set with things . ..
 

Attachments

  • revolt (1).JPG
    revolt (1).JPG
    186.4 KB · Views: 77
  • revolt (2).JPG
    revolt (2).JPG
    249.6 KB · Views: 56
the revolt/?? is not showing up in the city except when u enter the city and look?? cant tell just by looking at it, like it used to be??
On left screenshot you have city named Kis, and on right you are viewing Kazallu.
 
the revolt/?? is not showing up in the city except when u enter the city and look?? cant tell just by looking at it, like it used to be??
Umm the pictures show two different cities, on two different turns...
 
Back
Top Bottom