Yudishtira
Spiritual/Creative
What revisions make up the corrupt period?It may well be that if you saved the game during the corrupt period, you aren't going to be able to get an uncorrupted save at this point.![]()
What revisions make up the corrupt period?It may well be that if you saved the game during the corrupt period, you aren't going to be able to get an uncorrupted save at this point.![]()
Corrupt revisions:What revisions make up the corrupt period?
You said you could recalc that save. I can recalc just about any save - the problem is that they hang/freeze during end turn. Did you progress that save in 10806 or later?
I actually was the first one to report problems with the game either crashing or taking really long to process a turn. However i didn't make any changes at the place where this happens and didn't have time to look at it again. Do you have a save from a week ago?@alberts2 ,
have you heard the terrible things they're saying about you? How confident are you that 10762 and 10766 don't corrupt saves?
There seems to be a issue with CvSelectionGroup::splitGroup it's either really slow
View attachment 530783
or crashes sometimes.
View attachment 530785
Or maybe this is caused by CvUnitAI::AI_load?
Well I remember that post, but it nowhere mentions that you were blaming yourself for the problem. Nor does it say it corrupts saves.I actually was the first one to report problems with the game either crashing or taking really long to process a turn. However i didn't make any changes at the place where this happens and didn't have time to look at it again. Do you have a save from a week ago?
Well I remember that post, but it nowhere mentions that you were blaming yourself for the problem. Nor does it say it corrupts saves.
And yes I do have saves from a week ago, before uploading can I just confirm you mean from before 10762?
I made that post because i have no idea what causes these issues and i didn't have have time to really look at it. This migh not even be a save corruption but a processing issue somewhere in the dll. I didn't change anything in the functions which cause problems now so i simply don't know if these issues are side effects of my changes or if they are caused by something else everything is possible.
A save from before 10762 would do.
When there is save corruption going around then the latest dll changes are the default suspects, alberts commits were close enough to the reported issues to be included as suspects along with Anq's dll changes. That's all there was to that debacle.That's what I thought: it is very very unlikely that 10762 or 10766 caused any part of the corrupted saves debacle.
10822
- Fixed an infinite loop bug that I introduced in revision 10796.
- @Yudishtira, this might be what you have experienced, not a CTD but an end turn freeze.
Save that he posted here crashes on load.That set of changes fixed my problems thanks!!!!!!!!!
But these problems already existed before 10796 that makes me think it really could fix the problems @Yudishtira had as well.
I see, I thought he was having the game freeze on end turns.Save that he posted here crashes on load.
Which of his saves is that? He posted a few.Save that he posted here crashes on load.
Lower one on this page.Which of his saves is that? He posted a few.
Assert Failed
File: CvUnit.cpp
Line: 20016
SVN-Rev: 10807
Expression: bIsLoadVolumeCorrect
Message:
----------------------------------------------------------
Assert Failed
File: CvUnit.cpp
Line: 20053
SVN-Rev: 10807
Expression: bIsLoadVolumeCorrect
Message:
----------------------------------------------------------
Assert Failed
File: CvUnit.cpp
Line: 23009
SVN-Rev: 10807
Expression: pTransportUnit->SMcargoSpaceAvailable(getSpecialUnitType(), getDomainType()) > 0
Message: Cargo space is expected to be available
----------------------------------------------------------
Assert Failed
File: CvUnit.cpp
Line: 19982
SVN-Rev: 10807
Expression: SMgetCargo() >= 0
Message:
----------------------------------------------------------
Assert Failed
File: CvUnit.cpp
Line: 20018
SVN-Rev: 10807
Expression: getCargo() == aUnits.size()
Message:
----------------------------------------------------------
Assert Failed
File: CvUnit.cpp
Line: 20120
SVN-Rev: 10807
Expression: getCargo() == iCount
Message:
----------------------------------------------------------
Assert Failed
File: CvPlayer.cpp
Line: 15971
SVN-Rev: 10807
Expression: getAssets() >= 0
Message:
----------------------------------------------------------
Lower one on this page.
Got asserts on debug dll.
Game loaded on debug DLL though.
Code:Assert Failed File: CvUnit.cpp Line: 20016 SVN-Rev: 10807 Expression: bIsLoadVolumeCorrect Message: ---------------------------------------------------------- Assert Failed File: CvUnit.cpp Line: 20053 SVN-Rev: 10807 Expression: bIsLoadVolumeCorrect Message: ---------------------------------------------------------- Assert Failed File: CvUnit.cpp Line: 23009 SVN-Rev: 10807 Expression: pTransportUnit->SMcargoSpaceAvailable(getSpecialUnitType(), getDomainType()) > 0 Message: Cargo space is expected to be available ---------------------------------------------------------- Assert Failed File: CvUnit.cpp Line: 19982 SVN-Rev: 10807 Expression: SMgetCargo() >= 0 Message: ---------------------------------------------------------- Assert Failed File: CvUnit.cpp Line: 20018 SVN-Rev: 10807 Expression: getCargo() == aUnits.size() Message: ---------------------------------------------------------- Assert Failed File: CvUnit.cpp Line: 20120 SVN-Rev: 10807 Expression: getCargo() == iCount Message: ---------------------------------------------------------- Assert Failed File: CvPlayer.cpp Line: 15971 SVN-Rev: 10807 Expression: getAssets() >= 0 Message: ----------------------------------------------------------
Took some time to save lol.
Probably one of the Win 7 crashes then I suspect.I have no problems loading that save and the first turn also processes without crashing or taking extremely long.
So its some sort of pointer corruption or whatever was fault then - Win7 is worse at this.I have no problems loading that save and the first turn also processes without crashing or taking extremely long.
Assert Failed
File: CvGame.cpp
Line: 6220
SVN-Rev: 10807
Expression: getUnitClassCreatedCount(eIndex) <= GC.getUnitClassInfo(eIndex).getMaxGlobalInstances()
Message: Index is expected to be within maximum bounds (invalid Index)
----------------------------------------------------------
Assert Failed
File: CvCity.cpp
Line: 10569
SVN-Rev: 10807
Expression: getNumWorldWonders() >= 0
Message:
----------------------------------------------------------
Assert Failed
File: CvCity.cpp
Line: 10595
SVN-Rev: 10807
Expression: getNumNationalWonders() >= 0
Message:
----------------------------------------------------------
Assert Failed
File: CvPlot.cpp
Line: 11141
SVN-Rev: 10807
Expression: getVisibilityCount(eTeam) >= 0
Message:
----------------------------------------------------------
Assert Failed
File: CvCity.cpp
Line: 10582
SVN-Rev: 10807
Expression: getNumTeamWonders() >= 0
Message:
----------------------------------------------------------
On left screenshot you have city named Kis, and on right you are viewing Kazallu.the revolt/?? is not showing up in the city except when u enter the city and look?? cant tell just by looking at it, like it used to be??
Umm the pictures show two different cities, on two different turns...the revolt/?? is not showing up in the city except when u enter the city and look?? cant tell just by looking at it, like it used to be??
On left screenshot you have city named Kis, and on right you are viewing Kazallu.
yes i know, i was just using the second one as an example of the icon missing , , ,lolUmm the pictures show two different cities, on two different turns...