[MOD] v41 SVN and GithubDesktop Bugs and Crashes Single player

[Toffer90]

SVN 11261

Encountered a nasty bug immediately after updating and allowing it to recalc stats. My Sculptors Workshop in Delhi was one turn away from being built and then after ending the turn it did not build, instead it completely vansihed, neither appearing in my built buildings list nor in my available building list. I also tried exiting the game and loading a save from the turn before I updated with Scultptors Workshop 2 turns away, and after ending turn while other buildings in my other cities succesfully built themselves the Sculptors Workshop once again completely disapeared from my build queue

Edit: I've also noticed that the Trading Post that was being built in Vijayanagara and 2 turns from completion also after ending turn, disapears from it's bulld queue and it's list of available buildings, interestingly in Delhi it's still shown as built.

Edit 2: Updated to version 11262 and the problem still remains.

Think I know what causes it, will fix asap.

Edit: As a test of my hypothesis, try turning off "hide replaced buildings" in BUG option, if that allows you to build it I know for sure what the problem is.
Edit2: New SVN rev with potential fix is on the way (est. 35 minutes).

 

[jatkinson]

Can confirm that when I turn off "hide replaced buildings" I was able to build the Sculptors Workshop.

 

[Toffer90]

Can confirm that when I turn off "hide replaced buildings" I was able to build the Sculptors Workshop.

Could you confirm that the newest SVN allows you to build it with the option on as well?

 

[jatkinson]

Yes latest SVN allows me to build it with Hide Replaced Building ticked again. Thanks for the fix.


Edit: Unfortunately it seems as though the Hide Replaced Buildings BUG option is no longer functioning properly, as you can see in Delhi's available buildings, Rope Bridge, Log Bridge, Bamboo Bridge, Stone Bridge and Brick Bridge are all available to build. Likewise with both Abatis' and the Wooden Watchtower and Fortified Outpost.

 

[JosEPh_II]

After just updating thru Github now getting CTD as game is loading. Get Hint message screen and running man, but when you would expect the main screen to launch crashes to desktop.

Had No chance to do ctrl/shift/t.

Save game below which was played yesterday.

EDIT: It did not get to the Options pop up (left side of screen) before Main screen loads.
EDIT2: Loaded next to last save game. It loaded and asked for Re-Calc. I saved and overwrote that game. Then from in game menu loaded The above save that CTD'd. It loaded and asked for Re-calc. Did re-calc and overwrote this save. Am now playing.

 

[Toffer90]

After just updating thru Github now getting CTD as game is loading. Get Hint message screen and running man, but when you would expect the main screen to launch crashes to desktop.

Had No chance to do ctrl/shift/t.

Save game below which was played yesterday.

EDIT: It did not get to the Options pop up (left side of screen) before Main screen loads

I could load your save just fine... Maybe something wrong on your side?

 

[JosEPh_II]

I could load your save just fine... Maybe something wrong on your side?

See edited post above. For the work around I did to get game going again.

 

[jatkinson]

Yes latest SVN allows me to build it with Hide Replaced Building ticked again. Thanks for the fix.


Edit: Unfortunately it seems as though the Hide Replaced Buildings BUG option is no longer functioning properly, as you can see in Delhi's available buildings, Rope Bridge, Log Bridge, Bamboo Bridge, Stone Bridge and Brick Bridge are all available to build. Likewise with both Abatis' and the Wooden Watchtower and Fortified Outpost.

Did anyone see the edit to my post about Hide Replaced Buildings no longer working?

 

[MattCA]

last svn might have fixed that.

 

[jatkinson]

last svn might have fixed that.

No I'm using the latest SVN (11263) what I reported was a consequence of the fix to a previous bug that I reported to Toffer that has now prevented Hide Replaced Buildings from working.

 

[Toffer90]

Edit: Unfortunately it seems as though the Hide Replaced Buildings BUG option is no longer functioning properly, as you can see in Delhi's available buildings, Rope Bridge, Log Bridge, Bamboo Bridge, Stone Bridge and Brick Bridge are all available to build. Likewise with both Abatis' and the Wooden Watchtower and Fortified Outpost.

Strange, will have another look at that.

Edit: I see the mistake, fix on the way. This time it should be good regardless of option on and off.
Edit2: There, hopefully fixed now.

 

[jatkinson]

I can confirm it's fixed with SVN 11264, thanks for all the fixes

 

[Blazenclaw]

1. pic: how come the "tar" and "salt" r on the same plot??

What script did you use to generate the map?

3. Can someone please, go thru the "ships" sizes and get them all in size, some r huge and some that r newer, r waaay smaller??

4. On the size stuff can someone please, please re-size the dreadnaught tank, looks totally ridiculous ..

Will add to the git issue list...

 

[Thunderbrd]

1. pic: how come the "tar" and "salt" r on the same plot??

Tar is not a resource. It is a feature that can qualify you to make a building get a resource out of.

 

[kormer]

On v41.0.3373

1. It looks like there is a bug with loading Propeller Naval Aircraft onto carriers when one or both has been upgraded from the earlier unit types. I can do some more testing to narrow it down exactly if it isn't obvious from looking at the code.
2. Recon planes and their upgrade the Hypersonic Recon Plane are getting their promotions from the land based explorer unit types, and none of the aircraft promotions.

 

[Thunderbrd]

On v41.0.3373

1. It looks like there is a bug with loading Propeller Naval Aircraft onto carriers when one or both has been upgraded from the earlier unit types. I can do some more testing to narrow it down exactly if it isn't obvious from looking at the code.
2. Recon planes and their upgrade the Hypersonic Recon Plane are getting their promotions from the land based explorer unit types, and none of the aircraft promotions.

There's some issues here, yes. Some stuff I do have plans to resolve in the unit review. That said, it's a little messy atm.

 

[Thunderbrd]

why do certain civs have so many of a |really| not needed unit, like in pic??

I know the reason and understand the bug and at a point will fix it. It's a type evaluation problem.

 

[Blazenclaw]

after the latest SVN change my game crashes after clicking on "next turn:

Rip. Probably something I missed.

Taking a look...

Edit: Found the issue with Toffer's help (really, he found it) and a fix is being made. Will be up within an hour-ish.

 

[jatkinson]

SVN 11266

I had a fire event in Delhi but oddly the building that burnt down was my Active Asian Culture, pretty sure this shouldn't happen....

 

[Toffer90]

SVN 11266

I had a fire event in Delhi but oddly the building that burnt down was my Active Asian Culture, pretty sure this shouldn't happen....

MattCA fixed this today. I'll make a new SVN revision soon.