Single Player bugs and crashes - After the 16th of May

Testing with SVN 5521, I'm still having problems with the Hunter III promotion not being available to Trackers. To test, I started a new game, entered WB to give myself a Tracker with Hunter II, Woodsman II, & 40 experience, and also gave myself Hunting Tactics, and when I exit WB I can't upgrade to Hunter III even though I have all of the prereqs.

Sorry if I'm being a pain, but this problem still exists with SVN 5558 - as DH said, apparently you need both Woodsman II & Guerilla II to promote to Hunter III, even though the pedia clearly says you should only need either (which is how it's always been).
 
Sorry if I'm being a pain, but this problem still exists with SVN 5558 - as DH said, apparently you need both Woodsman II & Guerilla II to promote to Hunter III, even though the pedia clearly says you should only need either (which is how it's always been).

Hah... how ironic! I JUST found and repaired this bug and am testing the fix now before pushing the fix to the SVN.

@SO: This includes the problems you were having with the chariots and archers. Apparently one of the coders did some tweaking in the canAcquirePromotion function in the dll and did not realize that the OR prereqs is an AND/OR rather than an AND/AND statement. He did a great job improving some of the coding but incidentally broke this function, probably due to not knowing the intention of the code - when I read the code there the first time, I thought it was a bug too until it was explained to me what it was supposed to do. No big harm... it should be fixed now.
 
I picked scientific, idealistic and agricultural traits (creative, too, but it's not part of the bug). When building a granary the production window says I get +100% for sci, ide, agr although only agr gives the "builds faster with" bonus for grenary.

The window says I get 245 hammers but the production bar says only 131 and seems to get it right (or at least ignore the buggy window estimates)

EDIT: Using yesterdays SVN but the bug appeared already before, just reporting it now.
If you like, I can provide a save.

This should be fixed with the push I'm putting through now.
 
This should be fixed with the push I'm putting through now.

Hey thx, time for me to continue my game now,
was mostly only discussing/suggesting stuff these days and also afk a few days in between.
Time for my beloved Japan to continue to take on the #1 score Zulu (quite some space in between, still, on GEM^^). Let's see if I can still build a "bug catcher" somewhere :p :crazyeye: :lol: :cool: :scan: :D


btw... do we have a bug catcher - street cleaner - waste collection services building chain upgrade line yet?
 
Apparently one of the coders did some tweaking in the canAcquirePromotion function in the dll and did not realize that the OR prereqs is an AND/OR rather than an AND/AND statement. He did a great job improving some of the coding but incidentally broke this function, probably due to not knowing the intention of the code - when I read the code there the first time, I thought it was a bug too until it was explained to me what it was supposed to do. No big harm... it should be fixed now.
That happens when variable names that do not tell what they are supposed to do are used. Anyway, cleaned it up some more (this time hopefully without changing the meaning).
 
@DH:

I'm getting some asserts in the debug build on load. They have to do with study outcomes, it gives 8 or so but I only took two screenshots.
 

Attachments

  • Assert.PNG
    Assert.PNG
    11.8 KB · Views: 57
  • Assert2.PNG
    Assert2.PNG
    11.7 KB · Views: 55
That happens when variable names that do not tell what they are supposed to do are used. Anyway, cleaned it up some more (this time hopefully without changing the meaning).

lol... are you saying bbypass doesn't clarify itself? I was purposely not calling you out here out of respect (I'm going to try to minimize that sort of thing if I can since I know how blamable I can be myself for issues ;) ) but when you reply its tough to keep things on the 'downlow' :mischief:
 
lol... are you saying bbypass doesn't clarify itself? I was purposely not calling you out here out of respect (I'm going to try to minimize that sort of thing if I can since I know how blamable I can be myself for issues ;) ) but when you reply its tough to keep things on the 'downlow' :mischief:
Mistakes happen. No need to keep anything 'downlow'.

Anyway, before I clean up that code some more (and possibly misinterpret some of the code), what is the purpose of the following code:
Code:
	for (int iI = 0; iI < NUM_DOMAIN_TYPES; iI++)
	{
		if (getDomainType() == ((DomainTypes)iI) && ...
Why go through all domain types if you only want to do something for a specific one?
 
Can units not be more than one domain type? I suppose not huh... yeah I suppose it would be a mite bit faster to do a direct check without cycling through all the domains.

Just to clarify what I'm sure you already know... that section is just making sure that if the promotionline tag NotOnDomain is used that the unit is NOT one of the domains noted there.
 
@DH:

I'm getting some asserts in the debug build on load. They have to do with study outcomes, it gives 8 or so but I only took two screenshots.

It is OK they are not active on any units yet so wont be called. I had to get a fix in there for a CTD which was being caused by another part of the Subdue Animals Unit Combat file. I thought I had commented out all the new ones I was working on but obviously not. I'll put up the new Subdue Animals Outcomes file that should remove the error.
 
Yes, I have 1
But...
Im not toally sure, just look the print. You can see I have 1 Dye, 1 Crime (graffiti), but.... All calcul in the detail are so wrong...

The culture given in city screen is not the base culture, nor the total culture...

To me everything looks just fine there.

The -2 :culture: crime graffiti is to be found "inside" the base 146 "culture by buildings" value which is added to base 198 "culture by specialists" and then exposed to the % modifiers.
 
I have finally made it to the Modern Era without either been really far ahead or far behind the AI , but now I have struck a couple of minor bugs and one big one.
I'm playing v28 downloaded version, so if the bugs have been fixed already, pls excuse me :)

The big one is that all of a sudden my culture points in the victory screen has gone negative. (Screenshot0 and Screenshot1).
This is pretty big, since my total points are subtracted from the total mastery points, and the mercy rule has been started - so now I have 43 turns to kill everybody on the planet, or I loose...
Also; notice the Power score. My 35 points is OK, but Charlemagne's 214821 is not based on a percentage...
I've been playing for 170 hrs, and were on a winning path, so it's pretty annoying to loose now :sad:
But then again I can start a v30 game:D

Small bug 1:
I can't Airlift. The button is there, but when I try clicking on a city the mouse courser changes, but the unit isn't moved - And there is an airport or equal in both cities.

Small bug 2: I don't know whether this is a bug or feature - But my advanced bombers don't have the advanced bombing capabilities, but my propeller bombers has them, so they are activated. On Screenshot3 you can see that my Jet Bomber can't even bomb city defense.

These are minor bugs compare to the rest of the super cool mod :cool::goodjob::king:
 
i have revision from yesterday and political achievement doesnt give bonus +1 free specialist/city
 
Back
Top Bottom