Single Player bugs and crashes v39 plus (SVN) - After the 20th of July 2019

[olduser]

So the palace is not appearing in any cities wonder tab build lists.

I looked into it on the python side by making python print out every single building in the dll cache for buildable buildings; like so:

print GC.getBuildingInfo(CyCity.getBuildingListType(iGroup, i)).getType()​

The result was that the palace is never included in the dll's cache of build-able buildings.
So python has to assume that it is currently under construction in one of your cities and is thus not a valid thing to build anywhere at that time.
@alberts2: you recently fixed an issue with group wonders in this very same dll cache, perhaps you could look into why the palace is not included anymore. It is a special case as it is a national wonder that you can always build 1 extra of.

There's no obvious issue in the code so this needs a deeper investigation.

 

[Toffer90]

There's no obvious issue in the code so this needs a deeper investigation.

Ok, I'll doublecheck the python side, maybe I didn't look through the entire buildable buildings cache for that city when I checked last time.

 

[JosEPh_II]

Updated to SVN 10948 from 10935. Did Re-Calc. Currency 1 turn to finish. Clicked EoT red button. Currency finished. Went in to change Civics. Adopted Coinage, Monarchy, Military Training, and I think one other. Anarchy pops up to 5242596 turns.

I'm thinking okay Bug in calculations or a display bug. So I play till anarchy is at 5242549, 7 turns. Okay so Not a display Bug but a calculation bug. I'm still in anarchy which should've ended after 4 turns, 5 max.

While I'm in anarchy my research times are elongated as is normal. But I notice that Wrub my neighbor who was 1 turn from finishing Meritocracy is now over 2000+ turns to finish that tech. Did he go into anarchy too?

If I go into the build queue in the City screen in any city I have certain Smelters that are now going to give 20 Hammers vs the 4 or 2 they normally would. Another bug in calculations

Attaching save game that has been in anarchy for past 7 turns. Also attaching series of screenshots to show what I'm talking about.

As it stands now going from SVN 10935 to 10948 has caused the game play to go wonky. You can play and advance to next turn with no problem but if you go into Anarchy all else get's warped.

 

[billw2015]

Someone in discord mentioned long anarchy time friday morning, and asked what they should do, but they didn't specify how long or make it clear it was a bug so I think no one paid attention.

/edit Easy repo in my own game, literally just go into anarchy get the same number you get exactly

 

[Thunderbrd]

Updated to SVN 10948 from 10935. Did Re-Calc. Currency 1 turn to finish. Clicked EoT red button. Currency finished. Went in to change Civics. Adopted Coinage, Monarchy, Military Training, and I think one other. Anarchy pops up to 5242596 turns.

I'm thinking okay Bug in calculations or a display bug. So I play till anarchy is at 5242549, 7 turns. Okay so Not a display Bug but a calculation bug. I'm still in anarchy which should've ended after 4 turns, 5 max.

While I'm in anarchy my research times are elongated as is normal. But I notice that Wrub my neighbor who was 1 turn from finishing Meritocracy is now over 2000+ turns to finish that tech. Did he go into anarchy too?

If I go into the build queue in the City screen in any city I have certain Smelters that are now going to give 20 Hammers vs the 4 or 2 they normally would. Another bug in calculations

Attaching save game that has been in anarchy for past 7 turns. Also attaching series of screenshots to show what I'm talking about.

As it stands now going from SVN 10935 to 10948 has caused the game play to go wonky. You can play and advance to next turn with no problem but if you go into Anarchy all else get's warped.

Obviously a very serious problem. I may be able to look into it a little later if there hasn't been a solution introduced yet. No promises I'll see what the issue is as much that's being done lately is dealing with stuff outside my comprehension.

 

[Anq]

I'll look into the anarchy length calculation to see if it's introduced by me changing the info classes

 

[billw2015]

So I'm going to make a slight leap and suggest this is the first and probably not last victim of changing the memory allocator. Previously it zeroed all newly allocated memory, now it does not. The m_iMinAnarchyTurns member of CvPlayer is never initialized during construction, so just has garbage value in that happens to be the one we are seeing.

However it is 2am here and too late for me to make any kind of good fix.

 

[Thunderbrd]

So I'm going to make a slight leap and suggest this is the first and probably not last victim of changing the memory allocator. Previously it zeroed all newly allocated memory, now it does not. The m_iMinAnarchyTurns member of CvPlayer is never initialized during construction, so just has garbage value in that happens to be the one we are seeing.
View attachment 532136

However it is 2am here and too late for me to make any kind of good fix.

Yep. I suspected it would be something like that because I wasn't seeing where anyone was saying they were messing with the calculation itself.

 

[MattCA]

I added a couple lines to this that supposed to set anarchy turns to 2 turns if it is above 15.
havn't tested it tho.

 

[olduser]

So I'm going to make a slight leap and suggest this is the first and probably not last victim of changing the memory allocator. Previously it zeroed all newly allocated memory, now it does not. The m_iMinAnarchyTurns member of CvPlayer is never initialized during construction, so just has garbage value in that happens to be the one we are seeing.
View attachment 532136

However it is 2am here and too late for me to make any kind of good fix.

With the CvAllocator it wasn't zeroing the newly allocated memory either. At least there's no guarantee that it happend maybe on some windows versions it did and on others it didn't or the used hardware made a difference as well hard to tell.
The issue with the anarchy also came up before the memory allocator change but only in a few mysterious cases.

 

[billw2015]

With the CvAllocator it wasn't zeroing the newly allocated memory either. At least there's no guarantee that it happend maybe on some windows versions it did and on others it didn't or the used hardware made a difference as well hard to tell.

Sorry it was these changes I was referring to, not to the CvAllocator but to the new overrides (2am was too late for my subconscious to be differentiating between allocator and new override apparently!):

 

[raxo2222]

With the CvAllocator it wasn't zeroing the newly allocated memory either. At least there's no guarantee that it happend maybe on some windows versions it did and on others it didn't or the used hardware made a difference as well hard to tell.
The issue with the anarchy also came up before the memory allocator change but only in a few mysterious cases.

In same save there are errors in yield modifier calculations (screenshot 126) too.
10x increase in production shouldn't be possible in Classical.

On unrelated note it seems like era icon isn't working for Classical era.
Instead shortened era name is displayed.
Not sure if that thing is toggleable in BUG.

 

[strategyonly]

when someone changed the era's around for the game to better see them, they forgot to put the TXT correctly, see pic .. .not all but most. . .

Toffer: the commerce arrows r working out greatly, heck dont know why Firaxis didnt think of this, thx .. ..SO

 

[raxo2222]

when someone changed the era's around for the game to better see them, they forgot to put the TXT correctly, see pic .. .not all but most. . .

@Toffer90 @KaTiON_PT
I noticed unnecessary black background behind era icons too.

 

[olduser]

Sorry it was these changes I was referring to, not to the CvAllocator but to the new overrides (2am was too late for my subconscious to be differentiating between allocator and new override apparently!):
View attachment 532169

I'am not sure who added these memset calls they don't exist in the original code. Mabye this was someone trying to fix issues which where caused by uninitiated variables but he didn't notice that they aren't initiated.

 

[SteelSterling]

When I saw you released 39, I started a new game (wow! Version 39!). I'm on SVN 10950 with Toffer's new interface but I don't see the Era names displayed nor on the bottom of the screen where it would read "Press enter to end turn". Are we still supposed to install a special font as before? I have a new PC and don't think I have it.

 

[raxo2222]

When I saw you released 39, I started a new game (wow! Version 39!). I'm on SVN 10950 with Toffer's new interface but I don't see the Era names displayed nor on the bottom of the screen where it would read "Press enter to end turn". Are we still supposed to install a special font as before? I have a new PC and don't think I have it.

Instead of era names there are era icons on top.
I'm not sure if its toggleable between that and shortened era names.

Also that special font was unneeded for long time - way before V39 was released.

 

[KaTiON_PT]

@Toffer90 @KaTiON_PT
I noticed unnecessary black background behind era icons too.

They are necessary or else you wouldn't be able to clearly see the icons.

 

[raxo2222]

They are necessary or else you wouldn't be able to clearly see the icons.

I saw some screenshot from prehistoric era, and its era icon didn't have black background.

When I looked into sourceforge I saw that only two era icons were added.

 

[olduser]

Ok, I'll doublecheck the python side, maybe I didn't look through the entire buildable buildings cache for that city when I checked last time.

Found it there where changes in 10704 and 10800 which cause it.