Better Trade Screen - Gathering Storm update released! 4.4

[bladex]

when you select repeat route do you have to check both boxes? i'm still getting requests to select trade routes afterwards.

 

[astog]

when you select repeat route do you have to check both boxes? i'm still getting requests to select trade routes afterwards.

No only one, but I have encountered a bug where the routes will not automate. That might be what is occurring to you too.

 

[ctudor]

i have a problem, when i have a lot of trade routes and i want each city to have a similar numbers of traders assigned to them i would like to see all the routes alphabetically.
atm if i selec Group by city of origin i get:

basically the mod sorts them by distance or smth. i would like to see [City of origin 1] to [destination 1] and [city of origin 1] to [destination 2] one bellow the other if it possible.

 

[astog]

i have a problem, when i have a lot of trade routes and i want each city to have a similar numbers of traders assigned to them i would like to see all the routes alphabetically.
atm if i selec Group by city of origin i get:
View attachment 462283

basically the mod sorts them by distance or smth. i would like to see [City of origin 1] to [destination 1] and [city of origin 1] to [destination 2] one bellow the other if it possible.

Currently the grouping does not affect tabs other than available routes, but I plan to change the grouping pulldown into a sort by pulldown in those tabs. This sort by pulldown will contain all the other sort options we want, namely alphabetically (either origin or destination). This alphabetical sort is not useful in Available routes, because of the amount of routes present, but is very useful in My Routes when you want check if every city has route to the capital (for example). This is definitely in my feature list to work on.

 

[astog]

astog updated Better Trade Screen with a new update entry:

Performance and other improvements

Changelog
Performance

1. Implemented caching to greatly improve performance. Details here. Note: If playing on a huge map, late game you will have a noticeable delay, but significantly better than v3.0.
2. Routes will not sort/group/filter unless absolutely needed. Collapsing and expanding routes should be really fast.
3. Increased animation speed of opening trade panels....

Read the rest of this update entry...

 

[ctudor]

thnks very much for the hard work

 

[ATG]

Thanks for the update.

For CQUI users, can we just replace the BTS folder with the one from your mod or should we wait for chaorace to merge it?

Edit: I've edited the CQUI modinfo file as well to match the new changes. It appears to be working ok.

 

[10KEyeCandy]

astog updated Better Trade Screen with a new update entry:

Performance and other improvements



Read the rest of this update entry...

Hi astog! Just downloaded v3.1 and there are a few things I'd like to discuss with you.


---- Firstly, I've created a Chinese (both simplified and traditional) translation for your mod.
I can upload the files in this thread if that's okay for you.


---- Secondly, when doing the translation, I found that the format of the text file is not optimal.
There is no need to write into BaseGameText, use LocalizedText with Language tags is a better way to add localizable text into the game.
Currently in v3.1 the texts have a format like this:

Spoiler :

<GameData>
  <BaseGameText>
    <Row Tag="SOME_TAG">
        <Text>Some text.</Text>
    </Row>
  </BaseGameText>
</GameData>

And as stated above, a better way to add texts is to change it to this:

Spoiler :

<GameData>
  <LocalizedText>
    <Row Tag="SOME_TAG" Language="en_US">
        <Text>Some text.</Text>
    </Row>
  </LocalizedText>
</GameData>

This way the BaseGameText that are used as raw text don't get touched at all. It also enables easier localization for the added texts.


---- Thirdly, the .modinfo file has some small issues, too.
The section below is not needed for your mod and is in wrong format as well. More info on this thread.

Spoiler :

    <Settings>
        <Custom id="BTS_SETTINGS">
            <Items>
                <Component>BTS_IMPORT_FILES</Component>
                <Component>BTS_TEXT</Component>
            </Items>
        </Custom>
    </Settings>

It's also unnecessary to localize <Author> as well for obvious reasons.


---- Lastly, I also found some texts in the code files that are plain English rather than LocaleID, and some LocaleIDs in the text files that are not in use, which I believe are just a small oversight.

Now, I think I should be able to fix them for you since I've already found them in the codes.
I'll also add small tags such as my username for every line I changed of course so you can easily find them.

So I'm here asking if it's okay for me to change the code.
I know that some modders don't like other people to touch their code, and I fully understand that if you wanted the same.

 

[astog]

Thanks for the update.

For CQUI users, can we just replace the BTS folder with the one from your mod or should we wait for chaorace to merge it?

Edit: I've edited the CQUI modinfo file as well to match the new changes. It appears to be working ok.

I will be making a pull request soon with the updated BTS.

Hi astog! Just downloaded v3.1 and there are a few things I'd like to discuss with you.


---- Firstly, I've created a Chinese (both simplified and traditional) translation for your mod.
I can upload the files in this thread if that's okay for you.


---- Secondly, when doing the translation, I found that the format of the text file is not optimal.
There is no need to write into BaseGameText, use LocalizedText with Language tags is a better way to add localizable text into the game.
Currently in v3.1 the texts have a format like this:

Spoiler :

<GameData>
  <BaseGameText>
    <Row Tag="SOME_TAG">
        <Text>Some text.</Text>
    </Row>
  </BaseGameText>
</GameData>

And as stated above, a better way to add texts is to change it to this:

Spoiler :

<GameData>
  <LocalizedText>
    <Row Tag="SOME_TAG" Language="en_US">
        <Text>Some text.</Text>
    </Row>
  </LocalizedText>
</GameData>

This way the BaseGameText that are used as raw text don't get touched at all. It also enables easier localization for the added texts.


---- Thirdly, the .modinfo file has some small issues, too.
The section below is not needed for your mod and is in wrong format as well. More info on this thread.

Spoiler :

    <Settings>
        <Custom id="BTS_SETTINGS">
            <Items>
                <Component>BTS_IMPORT_FILES</Component>
                <Component>BTS_TEXT</Component>
            </Items>
        </Custom>
    </Settings>

It's also unnecessary to localize <Author> as well for obvious reasons.


---- Lastly, I also found some texts in the code files that are plain English rather than LocaleID, and some LocaleIDs in the text files that are not in use, which I believe are just a small oversight.

Now, I think I should be able to fix them for you since I've already found them in the codes.
I'll also add small tags such as my username for every line I changed of course so you can easily find them.

So I'm here asking if it's okay for me to change the code.
I know that some modders don't like other people to touch their code, and I fully understand that if you wanted the same.

1) Thanks for taking the time to write the translation. You can PM me the files, or upload them in thread. Either works.

2) I did not know about that. Thanks for letting me know.

3) I also read that thread and made those changes for More Lenses, but forgot to make them to BTS. I'll have them corrected in v3.1

 

[bladex]

Routes will not sort/group/filter unless absolutely needed. Collapsing and expanding routes should be really fast.

not liking this at all. now 1st it default selects my routes so i have to select available routes than select sort by gold every time..

 

[10KEyeCandy]

I will be making a pull request soon with the updated BTS.



1) Thanks for taking the time to write the translation. You can PM me the files, or upload them in thread. Either works.

2) I did not know about that. Thanks for letting me know.

3) I also read that thread and made those changes for More Lenses, but forgot to make them to BTS. I'll have them corrected in v3.1

You're welcome!
I'll upload it here then. It only contains files that I've changed.
You can easily find all the code changes by searching for my username.
Though I do noticed that "GroupExpandAllCheckBox" and "GroupCollapseAllCheckBox" (the 2 expand/collapse checkbox in overview screen) can only support 4 character string before overlapping with other stuff. Maybe the solution in v3.0 is better?

 

[astog]

not liking this at all. now 1st it default selects my routes so i have to select available routes than select sort by gold every time..

My idea behind that was late game, it takes too long to initially display the screen (since it needs to sort). But you have a good point that early and mid game, it can get quite annoying. An easy way to revert that change is to comment/delete these lines in TradeOverview.lua at 1589

-- Reset sort settings
m_SortBySettings = {};
m_GroupSortBySettings = {};

-- Reset tab
m_currentTab = TRADE_TABS.MY_ROUTES;

 -- Reset filter
 m_filterSelected = 1;

I am thinking of reverting this change in an upcoming update.

 

[bladex]

well it's taking longer now the way it is. in late game when you choose available routes you get a pause than when you select sort by gold you get another pause instead of just one pause.

 

[Xur]

"Repeat route" doesn't seem to work anymore...

 

[Gyrofalcon]

"Repeat route" doesn't seem to work anymore...

Check this:

Edit: v3.1 is released. The beta version uploaded here is deprecate, hence I removed it.

There are few scenarios that can occur using the beta version. I'll explain them below:

• You started automated routes in v3.0. If you load that game, the mod is not able to track those automated routes, so routes will not repeat across loads.
• You started automated routes in v3.0. Changed the mod to v3.1-beta, the routes will still not automate across saves since automated settings are saved when the route began. So if you began automated routes in v3.0 they will not repeat across loads.
• You started automated routes in v3.1-beta, and loaded a save from here, then the routes should automate across saves. If they are not automating in this scenario, then it is a bug and let me know if it is occurring.

If you are still encountering issues, try the latest beta (v3.1 beta.2). This has the button hookups added, and I have tested it personally to see if the routes repeat. This is the final beta before release.

And now we have 3.1 release

 

[Xur]

Check this:

And now we have 3.1 release

Yes? I'm using 3.1 release and it seems to break at random.

 

[Gyrofalcon]

So new trade route, started after you upgraded to v3.1, doesn't repeat?

Suggest you provide info on how to reproduce, so astog can have a look at it.
For me, it works just fine.

 

[Mordino]

i have startet a new game with new CQUI (BTS 3.1 include) , repeat route not works

 

[Xur]

So new trade route, started after you upgraded to v3.1, doesn't repeat?

Suggest you provide info on how to reproduce, so astog can have a look at it.
For me, it works just fine.

Dunno if you are trolling to be honest.

Anyway I hope this feature gets fixed. I dont care much for anything else in this mod - "repeat route" button is all I need.

 

[Gyrofalcon]

Based on this information, how do you suggest the author should fix this?
So far we know:

1. It doesn't work for a few
2. It is working for the rest

I'm not very good with coding, but I do believe this is somehow weak reports.

Spoiler Sarcastic: :

Sooo... Was dropping my car at the workshop today. Told the mechanics to "Fix my car, was making some noise" and left.