A New Dawn Bug Reports and Feedback

[dexy]

Okay Dexy, I ran an AI autoplay, and got the save for you. I checked, it's the same crash as Os79, and some previous one's I've seen. To load the save, get RoM 2.81 full, and install AND over it. Do not change any of the checkboxes for components in AND, I left it to a completely DEFAULT install. The Save is running in AI Autoplay, so you may want to stop it right away.

You will need to use my source code and create a debug dll. I assume you understand how to do all that.

Ah man! Such a stupid bug... But at least it was easy to find and Iron it

Details:

Spoiler :

It was occurring when AI had a unit on the end of the world (a tile on the edge of a non-globe map). Then one of adjacent plots would be illegal (i.e. NULL). And the code was trying to calculate AI's interest in claiming this NULL tile.

Instructions for fix:

Spoiler :

CvUnitAI::AI_claimTerritoryValue():

for (iI = 0; iI < NUM_DIRECTION_TYPES; iI++)
	{
		pAdjacentPlot = plotDirection(getX_INLINE(), getY_INLINE(), ((DirectionTypes)iI));

		if (pAdjacentPlot->getOwnerINLINE() == pPlot->getOwnerINLINE())
		{
			iNumEnemyAdjacentPlots++;
		}
		else if (pAdjacentPlot->getOwnerINLINE() == getID())
		{
			iNumOurAdjacentPlots++;
		}
	}

should be replaced by:

for (iI = 0; iI < NUM_DIRECTION_TYPES; iI++)
	{
		pAdjacentPlot = plotDirection(getX_INLINE(), getY_INLINE(), ((DirectionTypes)iI));

		[B]if (pAdjacentPlot != NULL)[/B]
		{
			if (pAdjacentPlot->getOwnerINLINE() == pPlot->getOwnerINLINE())
			{
				iNumEnemyAdjacentPlots++;
			}
			else if (pAdjacentPlot->getOwnerINLINE() == getID())
			{
				iNumOurAdjacentPlots++;
			}
		}
	}

(added null check on adjacent plot)

Afforess, you'll build and post the new dll, right? I can post it here, but it's better if it goes in the OP as the new patch.

It'll be savegame compatible, no worries.

I believe it's the last CTD bug RoM has, so it would be nice to get it Ironed out.

I really hope it's the last one, but to be honest... I think we'll never get there

 

[Afforess]

Ah man! Such a stupid bug... But at least it was easy to find and Iron it

Details:

Spoiler :

It was occurring when AI had a unit on the end of the world (a tile on the edge of a non-globe map). Then one of adjacent plots would be illegal (i.e. NULL). And the code was trying to calculate AI's interest in claiming this NULL tile.

Instructions for fix:

Spoiler :

CvUnitAI::AI_claimTerritoryValue():

for (iI = 0; iI < NUM_DIRECTION_TYPES; iI++)
    {
        pAdjacentPlot = plotDirection(getX_INLINE(), getY_INLINE(), ((DirectionTypes)iI));

        if (pAdjacentPlot->getOwnerINLINE() == pPlot->getOwnerINLINE())
        {
            iNumEnemyAdjacentPlots++;
        }
        else if (pAdjacentPlot->getOwnerINLINE() == getID())
        {
            iNumOurAdjacentPlots++;
        }
    }

should be replaced by:

for (iI = 0; iI < NUM_DIRECTION_TYPES; iI++)
    {
        pAdjacentPlot = plotDirection(getX_INLINE(), getY_INLINE(), ((DirectionTypes)iI));

        [B]if (pAdjacentPlot != NULL)[/B]
        {
            if (pAdjacentPlot->getOwnerINLINE() == pPlot->getOwnerINLINE())
            {
                iNumEnemyAdjacentPlots++;
            }
            else if (pAdjacentPlot->getOwnerINLINE() == getID())
            {
                iNumOurAdjacentPlots++;
            }
        }
    }

(added null check on adjacent plot)

Afforess, you'll build and post the new dll, right? I can post it here, but it's better if it goes in the OP as the new patch.

It'll be savegame compatible, no worries.



I really hope it's the last one, but to be honest... I think we'll never get there

Awesome! Null pointers are the 2nd biggest reason for crashes, I know your pain.

I'll run some preliminary tests, and launch a patch this evening.

 

[strategyonly]

EDIT: I just tried a quick game on play now(no rev) and it did not also give me a choose to get KRC but i also got this error?

Traceback (most recent call last):

File "CvScreensInterface", line 547, in showWorldBuilderScreen

File "CvWorldBuilderScreen", line 122, in interfaceScreen

File "CvWorldBuilderScreen", line 2367, in refreshPlayerTabCtrl

RuntimeError: unidentifiable C++ exception
Error in sys.excepthook:
Traceback (most recent call last):

Original exception was:
Traceback (most recent call last):
ERR: Python function showWorldBuilderScreen failed, module CvScreensInterface

 

[NBAfan]

I am playing with Rev on and I can build King Richards Crusade.

 

[NBAfan]

Just downloaded the latest patch and I get these to errors.

 

[Afforess]

Just downloaded the latest patch and I get these to errors.

Dang, I forgot the new schema file. Go grab the new patch (it has the same name), and run it and see if you still get the error.

 

[NBAfan]

Dang, I forgot the new schema file. Go grab the new patch (it has the same name), and run it and see if you still get the error.

You also forgot to attach a file in the OP of the main download thread.

 

[Afforess]

You also forgot to attach a file in the OP of the main download thread.

No, it was still uploading, I don't have high speed internet right now...

It is there now.

 

[NBAfan]

It starts up fine now.

 

[Redman77]

I'm getting a xml error barbarian class???

 

[Redman77]

To be more specific on start up I get xml error "IADER_Barbarian Info class was incorrect" xml\gameInfo/CIV4ForceControl Infos.xml How can I fix this thanks

 

[Afforess]

I'm getting a xml error barbarian class???

To be more specific on start up I get xml error "IADER_Barbarian Info class was incorrect" xml\gameInfo/CIV4ForceControl Infos.xml How can I fix this thanks

You need to install the main 1.53 expansion pack before applying the patch.

 

[strategyonly]

EDIT: Talk about weird, after installing the patch 1.54, my USA civ converted to China?? (Look at the city names?

 

[Redman77]

Thanks deleted everything and started clean. Now getting a app error on 1.53 "error in Install Uninstaller" permission denied? Any help

 

[Afforess]

Thanks deleted everything and started clean. Now getting a app error on 1.53 "error in Install Uninstaller" permission denied? Any help

If you are having trouble, follow the step by step instructions on the bottom of the FAQ.

@StrategyOnly,

Are you sure you have ALL of the prerequisites?

 

[strategyonly]

@StrategyOnly,
Are you sure you have ALL of the prerequisites?

Yeah they were, but i started another game with Rev, and NOW the KRC is there, like i said in the other post(373), must have been a weird game is all.

 

[Flay]

Thanks afforess, it works like a charm !!!
I do add the stone modmod from Sarkyn, could you include it in your next Dawn, we didn.t report any bugs (3 players + 6 AI on terra large)

Since you do not take money for your work I'll sent an 10€ to UNICEF if thats ok for you.

 

[RobO]

You need to install the main 1.53 expansion pack before applying the patch.

What patch? Where is it?
Main Download Information does not list a patch to 1.54

 

[Hydromancerx]

A couple of balance issue with the Early Buildings Mod ...

1. I think the Apiary should be a little cheaper. Maybe like 75% cheaper. It always seems so expensive compared to all the other early buildings.

2. The Beadmaker's Hut seems not to give any gold from clams even though it says it does. Where it says like "actual" nothing comes up for me. However it gives happiness just fine.

I posted these things in the original thread and the "A New Dawn" section.

Please don't forget to adjust these in your next update.

 

[strategyonly]

Just for Info is all: with the new 1.54 i have gotten 5 random crashes now within turn 225(with Rev on), one of them was because i tried to use the mini-map to go to another location??(That has happened before also, but usually around 4 - 6 different games in the medieval era).

Has two python errors one i forgot to mark down, but here's the recent one:

PY: Revolt - Creating new player in slot 15
05:53:59 TRACE: Error in EndPlayerTurn event handler <bound method Revolution.onEndPlayerTurn of <Revolution.Revolution instance at 0x08D17F80>>
05:53:59 TRACE: unidentifiable C++ exception