Single Player bugs and crashes v37 plus (SVN) - After the 24th of December 2016

[strategyonly]

Well... you've found one that has me stumped for the moment.

I cannot promise I'll be able to fix this issue.

Now isnt that the normal case for me, lol, no biggy, do what u can, and if not oh well. . .

 

[Thunderbrd]

Now isnt that the normal case for me, lol, no biggy, do what u can, and if not oh well. . .

Well... without manipulating the files at all but rather just recompiling the dll, I've been able to get the turn to go through. I suspect there was some kind of compile corruption in the last dll that allowed this to be an issue. I admit I could not figure out how, following the coding, we were having a problem. There may be another answer that I'm not seeing but apparently a newly compiled dll works so I'll get it up and on the SVN shortly here.

EDIT:
hmm... then next test with a completed final dll it hits the inf loop again. grr... perhaps the debug dll is fixing the problem before I can see the problem?

More tests needed.

 

[Thunderbrd]

A while back I had made the debug dll capable of being run to correct a gamestate problem I couldn't figure out how to solve for. Back then I stated that some crashes may be correctable by running the round on the debug dll. Since the debug dll does fix this loop, this may have been one of those issues.

Rather than having you run the turn on the debug dll, I've run it here and saved the game upon entry into the next turn. The tech choice was prompted for on the opening of the turn so you'll want to review what you wish to really select as I took the first given option.

As for a real fix, it's kinda hard to get a bead on the problem when the debug dll won't hit the problem but the actual dll will. This may end up being a persistent beast though.

 

[JosEPh_II]

@SO and T-brd,
I took SOs save game and did the Re-Calc when it popped up. I have SVN 9654 active from July 2nd.

After the Re-Calc I clicked the red EoT button and the turn processed. I selected Hydroelectric as the Research tech and then saved the game. Below is the save.

I have not updated to SVN 9658 yet.

 

[strategyonly]

@SO and T-brd,
I took SOs save game and did the Re-Calc when it popped up. I have SVN 9654 active from July 2nd.

After the Re-Calc I clicked the red EoT button and the turn processed. I selected Hydroelectric as the Research tech and then saved the game. Below is the save.

I have not updated to SVN 9658 yet.

what would really be the difference if u had updated, i looked and didnt see that much of a change really except some python and bamboo textures, and fixes

i also looked at the size difference, tb's is smaller than joes??? see pic the one with the fall on it is tb's . .

 

[JosEPh_II]

what would really be the difference if u had updated, i looked and didnt see that much of a change really except some python and bamboo textures, and fixes

i also looked at the size difference, tb's is smaller than joes??? see pic the one with the fall on it is tb's . .

Pepper2000 removed his older Mars Colony buildings, that is the difference.

I updated late last night but did not have time to rerun your save game. Plus I had another "problem" to address at that time as well.

 

[Toffer90]

It might have been caused by those wonders that Pepper added which had no names/icons/art.
But they got removed in 9658....

 

[JosEPh_II]

Save game compatibility was broken when this Class was removed, SPECIALBUILDINGS_GROUP_ANCIENT_WAYS .
Pop up reads:
Save format is not compatible due to missing class
SPECIALBUILDINGS_GROUP_ANCIENT_WAYS

Both SVN 9655 and 9657 have this pop up during initialization.

Further there are 2 conflicts in SVN 9656:
1. Assets/Modules/Pepper2000
2. Assets/python/Entrypoints/CvRandomEventInterface.py (Toffer may have fixed this one, maybe)

SVN 9654 will play SO's save game. All these revisions in between 9654 to 9658 will not.

I do not recommend to the Players to Update past SVN 9654 with older save games.

 

[Toffer90]

SPECIALBUILDINGS_GROUP_ANCIENT_WAYS
That one shouldn't have been removed as far as I know.
Who removed it at what revision, and why?

Edit:
SPECIALBUILDINGS_GROUP_ANCIENT_WAYS Never existed to begin with.
SPECIALBUILDING_GROUP_ANCIENT_WAYS Haven't been tampered with in a long time.

 

[JosEPh_II]

Did not dig that deep as I've spent the last 2+ hours just testing each SVN revision on SO's game.

The removal of the Class SPECIALBUILDINGS_GROUP_ANCIENT_WAYS has broken all save games made prior to SVN 9655. This maybe Peppers removal of the Old Mars Colony assets Pepper posted about.

 

[Toffer90]

Had a quick look in latest SVN and found:
SPECIALBUILDING_GROUP_ANCIENT_WAYS
It hasn't been changed since it was added in rev. 9609

I did not find any trace of:
SPECIALBUILDINGS_GROUP_ANCIENT_WAYS
I looked through rev.9626 and all the way up to rev.9658

EDIT:

Save game compatibility was broken when this Class was removed, SPECIALBUILDINGS_GROUP_ANCIENT_WAYS .
Pop up reads:
Save format is not compatible due to missing class
SPECIALBUILDINGS_GROUP_ANCIENT_WAYS

SVN 9654 will play SO's save game. All these revisions in between 9654 to 9658 will not.

I tested SO's savegame (the one he posted, not the ones you and TB posted) on rev.9658.
I got no errors when loading the game, I got no messages after a recalc.
I did not try to click end turn, it would probably just end up in an infinite loop as SO said it did for him..

 

[pepper2000]

Trying to figure out what's going on here ... I can't tell, but what seems most likely is that I did the old Mars colony removals at the same time someone else was working with the Ancient Ways wonder, causing a conflict. I didn't touch the Ancient Ways stuff, at least not on purpose.

 

[Thunderbrd]

Trying to figure out what's going on here ... I can't tell, but what seems most likely is that I did the old Mars colony removals at the same time someone else was working with the Ancient Ways wonder, causing a conflict. I didn't touch the Ancient Ways stuff, at least not on purpose.

You must remember to update before working on a file, and again before committing! This keeps problems like this from happening.

You'll probably have to back up to the SVN version before you committed the flaw and rework the file from there as a copy. Then update. Then replace with your copy you've fixed up. Then update again (this will merge in any changes anyone else may have made in the meantime). Then commit if you don't have conflicts to resolve first.

 

[pepper2000]

You must remember to update before working on a file, and again before committing! This keeps problems like this from happening.

Yeah, I know. I thought that's what I did; maybe I lapsed or did it wrong.

Further there are 2 conflicts in SVN 9656:
1. Assets/Modules/Pepper2000

How did you check that?

 

[Thunderbrd]

Yeah, I know. I thought that's what I did; maybe I lapsed or did it wrong.

If you ignored a conflict in the process then this can still happen.

 

[Toffer90]

I'm still not convinced that there is a problem at all.
There doesn't seem to be any problems with the ancient way wonders.

There were no errors in peppers latest commits as far as I can see.

 

[JosEPh_II]

Maybe it's because I updated tortoise/svn yesterday to it's newest version? I don't know.

All I can say is what it gave me when I tried to play SO's game on each svn version between 9654 and 9658. It played fine for me on 9654. And fine for T-brd on 9658. But Not for me once I updated to 9658.

I tried to help but guess I failed. I'll stay out of it from now on.

 

[JosEPh_II]

How did you check that?

That is what came up on the SVN pop up screen when I reverted the revision to 9656. I just copied it down and posted it here. Then I did a resolve conflict on that version in the SVN command list.

 

[pepper2000]

(quoting mechanism doesn't seem to be working)

I'm still not convinced that there is a problem at all.
There doesn't seem to be any problems with the ancient way wonders.

There were no errors in peppers latest commits as far as I can see.

There are other possibilities, e.g. maybe taking out the Mars buildings messed up the internal numbering system somehow. But for now things appear to be working.

Maybe it's because I updated tortoise/svn yesterday to it's newest version? I don't know.

All I can say is what it gave me when I tried to play SO's game on each svn version between 9654 and 9658. It played fine for me on 9654. And fine for T-brd on 9658. But Not for me once I updated to 9658.

I tried to help but guess I failed. I'll stay out of it from now on.

I appreciate you looking into this and trying to make it work. I try to avoid mistakes but make them anyway, and it is better to error on the side of diligence rather than ignoring potential problems. Besides, I don't think we've gotten to the bottom of this one.

That is what came up on the SVN pop up screen when I reverted the revision to 9656. I just copied it down and posted it here. Then I did a resolve conflict on that version in the SVN command list.

OK, thanks for indicating that. I didn't see a conflict in my system. Regardless of what happened here, I will keep my eyes more open for conflicts.

 

[Toffer90]

There are other possibilities, e.g. maybe taking out the Mars buildings messed up the internal numbering system somehow. But for now things appear to be working.

Maybe...
I've checked almost every change that's been made since rev.9626 today.
The only changes I've not kept track of are the ones that's been made within the pepper2000 module folder, so much have happened there so fast that I gave up keeping track of that folders content quickly after it was first created.
I saw nothing wrong, so if something is wrong there's a good chance that it is within your module folder.

I tried to help but guess I failed. I'll stay out of it from now on.

There's no reason to resign, you might be right about there being a problem somewhere even though I've raised doubt about what the problem might be.